Merge "Remove symlink to the build.ninja"

This commit is contained in:
Kiyoung Kim
2023-06-16 08:06:06 +00:00
committed by Gerrit Code Review

View File

@@ -531,8 +531,6 @@ func main() {
var finalOutputFile string var finalOutputFile string
writeSymlink := false
// Run Soong for a specific activity, like bp2build, queryview // Run Soong for a specific activity, like bp2build, queryview
// or the actual Soong build for the build.ninja file. // or the actual Soong build for the build.ninja file.
switch configuration.BuildMode { switch configuration.BuildMode {
@@ -555,13 +553,8 @@ func main() {
maybeQuit(err, "") maybeQuit(err, "")
} }
} }
writeSymlink = true
} else { } else {
finalOutputFile = runSoongOnlyBuild(ctx, extraNinjaDeps) finalOutputFile = runSoongOnlyBuild(ctx, extraNinjaDeps)
if configuration.BuildMode == android.AnalysisNoBazel {
writeSymlink = true
}
} }
writeMetrics(configuration, ctx.EventHandler, metricsDir) writeMetrics(configuration, ctx.EventHandler, metricsDir)
} }
@@ -578,24 +571,6 @@ func main() {
// are ninja inputs to the main output file, then ninja would superfluously // are ninja inputs to the main output file, then ninja would superfluously
// rebuild this output file on the next build invocation. // rebuild this output file on the next build invocation.
touch(shared.JoinPath(topDir, finalOutputFile)) touch(shared.JoinPath(topDir, finalOutputFile))
// TODO(b/277029044): Remove this function once build.<product>.ninja lands
if writeSymlink {
writeBuildNinjaSymlink(configuration, finalOutputFile)
}
}
// TODO(b/277029044): Remove this function once build.<product>.ninja lands
func writeBuildNinjaSymlink(config android.Config, source string) {
targetPath := shared.JoinPath(topDir, config.SoongOutDir(), "build.ninja")
sourcePath := shared.JoinPath(topDir, source)
if targetPath == sourcePath {
return
}
os.Remove(targetPath)
os.Symlink(sourcePath, targetPath)
} }
func writeUsedEnvironmentFile(configuration android.Config) { func writeUsedEnvironmentFile(configuration android.Config) {