StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Allow modules to override --error-when-new UnflaggedApi"

Browse Source 
This reverts commit 3001ce3bf5.

Reason for revert: Droidmonitor created revert due to b/363016109

Change-Id: Iaf3ca41520b4328fc727af8837e5dff6def41f2b
This commit is contained in:
Priyanka Advani (xWF)
2024-08-29 18:48:14 +00:00
committed by Gerrit Code Review
parent 3001ce3bf5
commit b09c0d25c9
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/droidstubs.go
View File

@@ -970,14 +970,10 @@ func (d *Droidstubs) everythingOptionalCmd(ctx android.ModuleContext, cmd *andro
d.apiLintReport = android.PathForModuleOut(ctx, Everything.String(), "api_lint_report.txt") d.apiLintReport = android.PathForModuleOut(ctx, Everything.String(), "api_lint_report.txt")
cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint" cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint"
// If UnflaggedApi issues have not already been configured then make sure that existing // Make sure that existing UnflaggedApi issues are reported as warnings but issues in
// UnflaggedApi issues are reported as warnings but issues in new/changed code are treated as // new/changed code are treated as errors by the Build Warnings Aye Aye Analyzer in Gerrit.
// errors by the Build Warnings Aye Aye Analyzer in Gerrit.
// Once existing issues have been fixed this will be changed to error. // Once existing issues have been fixed this will be changed to error.
// TODO(b/362771529): Switch to --error cmd.Flag("--error-when-new UnflaggedApi")
if !strings.Contains(cmd.String(), " UnflaggedApi ") {
cmd.Flag("--error-when-new UnflaggedApi")
}
// TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released. // TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released.
if d.Name() != "android.car-system-stubs-docs" && if d.Name() != "android.car-system-stubs-docs" &&