From b0fda8f594868287dfc1bbbd6fb12e623ff92ba3 Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Mon, 5 Dec 2022 17:09:55 +0900 Subject: [PATCH] Fix incorrect command line from avb_add_hash_footer This change fixes an error that the command line generated from avb_add_hash_footer contains "a_file --prop_from_file prop_name:a_file", which is invalid. The file should be an implicit dependency. Bug: 256148237 Test: N/A Change-Id: Id0a832bd552d5d79cbc79f250681928140255f91 --- filesystem/avb_add_hash_footer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filesystem/avb_add_hash_footer.go b/filesystem/avb_add_hash_footer.go index 1ee0edc96..2ee420cdb 100644 --- a/filesystem/avb_add_hash_footer.go +++ b/filesystem/avb_add_hash_footer.go @@ -149,7 +149,7 @@ func addAvbProp(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, prop cmd.FlagWithArg("--prop ", proptools.ShellEscape(fmt.Sprintf("%s:%s", name, value))) } else { p := android.PathForModuleSrc(ctx, file) - cmd.Input(p) + cmd.Implicit(p) cmd.FlagWithArg("--prop_from_file ", proptools.ShellEscape(fmt.Sprintf("%s:%s", name, cmd.PathForInput(p)))) } }