StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Expand visiblity error"

Browse Source
This commit is contained in:
Liz Kammer
2020-10-19 15:01:09 +00:00
committed by Gerrit Code Review
parent 509a9d35ac e501bb4d48
commit b51d6d13a8
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/visibility.go
View File

@@ -443,7 +443,7 @@ func visibilityRuleEnforcer(ctx TopDownMutatorContext) {
rule := effectiveVisibilityRules(ctx.Config(), depQualified) rule := effectiveVisibilityRules(ctx.Config(), depQualified)
if !rule.matches(qualified) { if !rule.matches(qualified) {
ctx.ModuleErrorf("depends on %s which is not visible to this module", depQualified) ctx.ModuleErrorf("depends on %s which is not visible to this module\nYou may need to add %q to its visibility", depQualified, "//"+ctx.ModuleDir())
} }
}) })
} }

4
android/visibility_test.go
View File

@@ -731,7 +731,7 @@ var visibilityTests = []struct {
}`), }`),
}, },
expectedErrors: []string{ expectedErrors: []string{
`module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module`, `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
}, },
}, },
{ {
@@ -760,7 +760,7 @@ var visibilityTests = []struct {
}`), }`),
}, },
expectedErrors: []string{ expectedErrors: []string{
`module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module`, `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
}, },
}, },
{ {