StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Add tests for "unset" select statements" into main am: 767a1fe663

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3016592

Change-Id: I60298949b6e41a7abc72b1048b89cd94726354d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Cole Faust
2024-04-04 18:25:18 +00:00
committed by Automerger Merge Worker
parent aceac30fd5 767a1fe663
commit b5965ed9a5
1 changed files with 97 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

98
android/selects_test.go
View File

@@ -121,7 +121,21 @@ func TestSelects(t *testing.T) {
}),
}
`,
expectedError: `can't assign bool value to string property "my_string\[1\]"`,
expectedError: `Android.bp:8:5: Found select statement with differing types "string" and "bool" in its cases`,
},
{
name: "Select type doesn't match property type",
bp: `
my_module_type {
name: "foo",
my_string: select(soong_config_variable("my_namespace", "my_variable"), {
"a": false,
"b": true,
_: true,
}),
}
`,
expectedError: `can't assign bool value to string property "my_string\[0\]"`,
},
{
name: "String list non-default",
@@ -272,6 +286,88 @@ func TestSelects(t *testing.T) {
my_string: proptools.StringPtr("my_arm64"),
},
},
{
name: "Unset value",
bp: `
my_module_type {
name: "foo",
my_string: select(soong_config_variable("my_namespace", "my_variable"), {
"a": unset,
"b": "b",
_: "c",
})
}
`,
vendorVars: map[string]map[string]string{
"my_namespace": {
"my_variable": "a",
},
},
provider: selectsTestProvider{},
},
{
name: "Unset value on different branch",
bp: `
my_module_type {
name: "foo",
my_string: select(soong_config_variable("my_namespace", "my_variable"), {
"a": unset,
"b": "b",
_: "c",
})
}
`,
provider: selectsTestProvider{
my_string: proptools.StringPtr("c"),
},
},
{
name: "unset + unset = unset",
bp: `
my_module_type {
name: "foo",
my_string: select(soong_config_variable("my_namespace", "my_variable"), {
_: unset,
}) + select(soong_config_variable("my_namespace", "my_variable2"), {
_: unset,
})
}
`,
provider: selectsTestProvider{},
},
{
name: "unset + string = string",
bp: `
my_module_type {
name: "foo",
my_string: select(soong_config_variable("my_namespace", "my_variable"), {
_: unset,
}) + select(soong_config_variable("my_namespace", "my_variable2"), {
_: "a",
})
}
`,
provider: selectsTestProvider{
my_string: proptools.StringPtr("a"),
},
},
{
name: "unset + bool = bool",
bp: `
my_module_type {
name: "foo",
my_bool: select(soong_config_variable("my_namespace", "my_variable"), {
"a": true,
_: unset,
}) + select(soong_config_variable("my_namespace", "my_variable2"), {
_: true,
})
}
`,
provider: selectsTestProvider{
my_bool: proptools.BoolPtr(true),
},
},
}
for _, tc := range testCases {