From 831f2bfbe5d8e21f53d7bf9f0bbc772b5fc06ac0 Mon Sep 17 00:00:00 2001 From: Cole Faust Date: Wed, 25 Oct 2023 15:10:38 -0700 Subject: [PATCH] Remove certificate genrules from denylist The denylist was built by running `genrule_sandbox_test.py` on all modules in the tree. `genrule_sandbox_test.py` checks that the sandboxed genrules build, but also that they get the same results as the unsandboxed version. In this case, the genrule actually builds with sandboxing just fine, but they have non-deterministic results, which caused `genrule_sandbox_test.py` to think that they didn't work with sandboxing. Test: m com.android.apex.apkrollback.test.pem com.android.apex.apkrollback.test.pubkey com.android.apex.cts.shim.debug.pem com.android.apex.cts.shim.debug.pubkey com.android.apex.cts.shim.pem com.android.apex.cts.shim.pubkey com.android.apex.cts.shim.v2_no_pb com.android.apex.cts.shim.v2_signed_bob com.android.apex.cts.shim.v2_signed_bob_rot com.android.apex.cts.shim.v2_signed_bob_rot_rollback com.android.apex.cts.shim.v2_unsigned_apk_container com.android.apex.cts.shim.v3_signed_bob com.android.apex.cts.shim.v3_signed_bob_rot com.android.apex.cts.shim_not_pre_installed.pem com.android.apex.cts.shim_not_pre_installed.pubkey com.android.apex.rotation.key.bob.pem com.android.apex.rotation.key.bob.pk8 com.android.apex.rotation.key.bob.rot com.android.apex.rotation.key.bob.rot.rollback com.android.apex.rotation.key.bob.x509.pem com.android.overlaytest.overlaid.pem com.android.overlaytest.overlaid.pubkey com.android.overlaytest.overlay.pem com.android.overlaytest.overlay.pubkey Change-Id: I950767449025163d8c71bb5a7b2e2f15a1ce4a84 --- genrule/allowlists.go | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/genrule/allowlists.go b/genrule/allowlists.go index b3c662d4f..294084820 100644 --- a/genrule/allowlists.go +++ b/genrule/allowlists.go @@ -109,36 +109,12 @@ var ( "camera-its", "checkIn-service-stub-lite", "chre_atoms_log.h", - "com.android.apex.apkrollback.test.pem", - "com.android.apex.apkrollback.test.pubkey", - "com.android.apex.cts.shim.debug.pem", - "com.android.apex.cts.shim.debug.pubkey", - "com.android.apex.cts.shim.pem", - "com.android.apex.cts.shim.pubkey", - "com.android.apex.cts.shim.v2_no_pb", - "com.android.apex.cts.shim.v2_signed_bob", - "com.android.apex.cts.shim.v2_signed_bob_rot", - "com.android.apex.cts.shim.v2_signed_bob_rot_rollback", - "com.android.apex.cts.shim.v2_unsigned_apk_container", - "com.android.apex.cts.shim.v3_signed_bob", - "com.android.apex.cts.shim.v3_signed_bob_rot", - "com.android.apex.cts.shim_not_pre_installed.pem", - "com.android.apex.cts.shim_not_pre_installed.pubkey", - "com.android.apex.rotation.key.bob.pem", - "com.android.apex.rotation.key.bob.pk8", - "com.android.apex.rotation.key.bob.rot", - "com.android.apex.rotation.key.bob.rot.rollback", - "com.android.apex.rotation.key.bob.x509.pem", "com.android.apex.test.bar_stripped", "com.android.apex.test.baz_stripped", "com.android.apex.test.foo_stripped", "com.android.apex.test.pony_stripped", "com.android.apex.test.sharedlibs_generated", "com.android.apex.test.sharedlibs_secondary_generated", - "com.android.overlaytest.overlaid.pem", - "com.android.overlaytest.overlaid.pubkey", - "com.android.overlaytest.overlay.pem", - "com.android.overlaytest.overlay.pubkey", "common-profile-text-protos", "core-tests-smali-dex", "cronet_aml_base_android_runtime_jni_headers",