diff --git a/bp2build/cc_library_conversion_test.go b/bp2build/cc_library_conversion_test.go index e5bf8e0ee..776129f58 100644 --- a/bp2build/cc_library_conversion_test.go +++ b/bp2build/cc_library_conversion_test.go @@ -153,10 +153,10 @@ cc_library { "//build/bazel/platforms/os:linux_glibc": ["linux.cpp"], "//conditions:default": [], })`, - "sdk_version": `"current"`, - "min_sdk_version": `"29"`, - "use_version_lib": `True`, - "implementation_whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, + "sdk_version": `"current"`, + "min_sdk_version": `"29"`, + "use_version_lib": `True`, + "whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, }), }) } diff --git a/bp2build/cc_library_shared_conversion_test.go b/bp2build/cc_library_shared_conversion_test.go index f5d62c692..47dff8a57 100644 --- a/bp2build/cc_library_shared_conversion_test.go +++ b/bp2build/cc_library_shared_conversion_test.go @@ -516,8 +516,8 @@ func TestCcLibrarySharedUseVersionLib(t *testing.T) { }`, ExpectedBazelTargets: []string{ MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{ - "use_version_lib": "True", - "implementation_whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, + "use_version_lib": "True", + "whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, }), }, }) diff --git a/bp2build/cc_library_static_conversion_test.go b/bp2build/cc_library_static_conversion_test.go index f89f2dd3f..948801486 100644 --- a/bp2build/cc_library_static_conversion_test.go +++ b/bp2build/cc_library_static_conversion_test.go @@ -1613,7 +1613,7 @@ func TestCcLibraryStaticUseVersionLib(t *testing.T) { }`, ExpectedBazelTargets: []string{ MakeBazelTarget("cc_library_static", "foo", AttrNameToString{ - "implementation_whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, + "whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`, }), }, }) diff --git a/cc/bp2build.go b/cc/bp2build.go index 1f2653e29..749fce59a 100644 --- a/cc/bp2build.go +++ b/cc/bp2build.go @@ -1053,11 +1053,7 @@ func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversion _, staticLibs = android.RemoveFromList(versionLib, staticLibs) // only add the dep if it is not in progress if !versionLibAlreadyInDeps { - if isBinary { - wholeStaticLibs = append(wholeStaticLibs, versionLib) - } else { - la.implementationWholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, []string{versionLib}, props.Exclude_static_libs)) - } + wholeStaticLibs = append(wholeStaticLibs, versionLib) } } }