From 774bac189a9983976f10504967be5a8e82d7088e Mon Sep 17 00:00:00 2001 From: Matthias Maennich Date: Wed, 7 Jun 2023 11:57:03 +0100 Subject: [PATCH 1/2] NDK library: enable feature flags for dumping ABI representations Bug: 156513478 Change-Id: I95ebfef65bcadb34f7ed03e34f29e3d6ca363a9f Signed-off-by: Matthias Maennich --- cc/ndk_library.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/cc/ndk_library.go b/cc/ndk_library.go index 56c57b94c..9df628f3d 100644 --- a/cc/ndk_library.go +++ b/cc/ndk_library.go @@ -334,13 +334,7 @@ func canDumpAbi(config android.Config) bool { return false } // http://b/156513478 - // http://b/277624006 - // This step is expensive. We're not able to do anything with the outputs of - // this step yet (canDiffAbi is flagged off because libabigail isn't able to - // handle all our libraries), disable it. There's no sense in protecting - // against checking in code that breaks abidw since by the time any of this - // can be turned on we'll need to migrate to STG anyway. - return false + return true } // Feature flag to disable diffing against prebuilts. From 0a6c5c2ffbb417e41070bd34ed8861e588f863d8 Mon Sep 17 00:00:00 2001 From: Matthias Maennich Date: Fri, 30 Jun 2023 23:22:56 +0100 Subject: [PATCH 2/2] NDK library: enable feature flags for diffing ABI representations Bug: 156513478 Change-Id: I94a0e2de051da9d9d82414a7189399553981c53f Signed-off-by: Matthias Maennich --- cc/ndk_library.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cc/ndk_library.go b/cc/ndk_library.go index 9df628f3d..40bf218c1 100644 --- a/cc/ndk_library.go +++ b/cc/ndk_library.go @@ -339,7 +339,7 @@ func canDumpAbi(config android.Config) bool { // Feature flag to disable diffing against prebuilts. func canDiffAbi() bool { - return false + return true } func (this *stubDecorator) dumpAbi(ctx ModuleContext, symbolList android.Path) {