From f034cb4d7b9037541b31d149247c95b37b3d8497 Mon Sep 17 00:00:00 2001 From: Wei Li Date: Wed, 19 Jan 2022 15:54:31 -0800 Subject: [PATCH] Add bp2build support for property "compressible" of apex module. Bug: 214466457 Bug: 207551677 Test: b build //build/bazel/examples/apex/minimal:build.bazel.examples.apex.minimal Test: b test //build/bazel/tests/apex:build.bazel.examples.apex.minimal_apex Test: b test //build/bazel/tests/apex:build.bazel.examples.apex.minimal_capex Change-Id: I6bf12c1b0c52d4486968bb430a67a3c3110766db --- apex/apex.go | 7 +++++++ bp2build/apex_conversion_test.go | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/apex/apex.go b/apex/apex.go index a6c63de35..0ac6eaa89 100644 --- a/apex/apex.go +++ b/apex/apex.go @@ -3289,6 +3289,7 @@ type bazelApexBundleAttributes struct { Prebuilts bazel.LabelListAttribute Native_shared_libs_32 bazel.LabelListAttribute Native_shared_libs_64 bazel.LabelListAttribute + Compressible bazel.BoolAttribute } type convertedNativeSharedLibs struct { @@ -3366,6 +3367,11 @@ func (a *apexBundle) ConvertWithBp2build(ctx android.TopDownMutatorContext) { installableAttribute.Value = a.properties.Installable } + var compressibleAttribute bazel.BoolAttribute + if a.overridableProperties.Compressible != nil { + compressibleAttribute.Value = a.overridableProperties.Compressible + } + attrs := &bazelApexBundleAttributes{ Manifest: manifestLabelAttribute, Android_manifest: androidManifestLabelAttribute, @@ -3379,6 +3385,7 @@ func (a *apexBundle) ConvertWithBp2build(ctx android.TopDownMutatorContext) { Native_shared_libs_64: nativeSharedLibs.Native_shared_libs_64, Binaries: binariesLabelListAttribute, Prebuilts: prebuiltsLabelListAttribute, + Compressible: compressibleAttribute, } props := bazel.BazelTargetModuleProperties{ diff --git a/bp2build/apex_conversion_test.go b/bp2build/apex_conversion_test.go index 4b141c954..90571893c 100644 --- a/bp2build/apex_conversion_test.go +++ b/bp2build/apex_conversion_test.go @@ -104,6 +104,7 @@ apex { certificate: "com.android.apogee.certificate", updatable: false, installable: false, + compressible: false, native_shared_libs: [ "native_shared_lib_1", "native_shared_lib_2", @@ -150,7 +151,8 @@ apex { ":pretend_prebuilt_1", ":pretend_prebuilt_2", ]`, - "updatable": "False", + "updatable": "False", + "compressible": "False", }), }}) }