Merge changes I09902215,I4f86780c
* changes: convert java_plugin with bp2build convert java static dependencies
This commit is contained in:
@@ -1969,7 +1969,7 @@ var _ ModuleWithStem = (*Module)(nil)
|
||||
|
||||
func (j *Module) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
|
||||
switch ctx.ModuleType() {
|
||||
case "java_library", "java_library_host":
|
||||
case "java_library", "java_library_host", "java_library_static":
|
||||
if lib, ok := ctx.Module().(*Library); ok {
|
||||
javaLibraryBp2Build(ctx, lib)
|
||||
}
|
||||
@@ -1978,5 +1978,4 @@ func (j *Module) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
|
||||
javaBinaryHostBp2Build(ctx, binary)
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
|
16
java/java.go
16
java/java.go
@@ -2010,7 +2010,7 @@ type javaLibraryAttributes struct {
|
||||
Javacopts bazel.StringListAttribute
|
||||
}
|
||||
|
||||
func javaLibraryBp2Build(ctx android.TopDownMutatorContext, m *Library) {
|
||||
func (m *Library) convertLibraryAttrsBp2Build(ctx android.TopDownMutatorContext) *javaLibraryAttributes {
|
||||
srcs := bazel.MakeLabelListAttribute(android.BazelLabelForModuleSrcExcludes(ctx, m.properties.Srcs, m.properties.Exclude_srcs))
|
||||
attrs := &javaLibraryAttributes{
|
||||
Srcs: srcs,
|
||||
@@ -2020,9 +2020,21 @@ func javaLibraryBp2Build(ctx android.TopDownMutatorContext, m *Library) {
|
||||
attrs.Javacopts = bazel.MakeStringListAttribute(m.properties.Javacflags)
|
||||
}
|
||||
|
||||
var deps bazel.LabelList
|
||||
if m.properties.Libs != nil {
|
||||
attrs.Deps = bazel.MakeLabelListAttribute(android.BazelLabelForModuleDeps(ctx, m.properties.Libs))
|
||||
deps.Append(android.BazelLabelForModuleDeps(ctx, m.properties.Libs))
|
||||
}
|
||||
if m.properties.Static_libs != nil {
|
||||
//TODO(b/217236083) handle static libs similarly to Soong
|
||||
deps.Append(android.BazelLabelForModuleDeps(ctx, m.properties.Static_libs))
|
||||
}
|
||||
attrs.Deps = bazel.MakeLabelListAttribute(deps)
|
||||
|
||||
return attrs
|
||||
}
|
||||
|
||||
func javaLibraryBp2Build(ctx android.TopDownMutatorContext, m *Library) {
|
||||
attrs := m.convertLibraryAttrsBp2Build(ctx)
|
||||
|
||||
props := bazel.BazelTargetModuleProperties{
|
||||
Rule_class: "java_library",
|
||||
|
@@ -14,7 +14,12 @@
|
||||
|
||||
package java
|
||||
|
||||
import "android/soong/android"
|
||||
import (
|
||||
"android/soong/android"
|
||||
"android/soong/bazel"
|
||||
|
||||
"github.com/google/blueprint/proptools"
|
||||
)
|
||||
|
||||
func init() {
|
||||
registerJavaPluginBuildComponents(android.InitRegistrationContext)
|
||||
@@ -24,7 +29,6 @@ func registerJavaPluginBuildComponents(ctx android.RegistrationContext) {
|
||||
ctx.RegisterModuleType("java_plugin", PluginFactory)
|
||||
}
|
||||
|
||||
// A java_plugin module describes a host java library that will be used by javac as an annotation processor.
|
||||
func PluginFactory() android.Module {
|
||||
module := &Plugin{}
|
||||
|
||||
@@ -32,9 +36,13 @@ func PluginFactory() android.Module {
|
||||
module.AddProperties(&module.pluginProperties)
|
||||
|
||||
InitJavaModule(module, android.HostSupported)
|
||||
|
||||
android.InitBazelModule(module)
|
||||
|
||||
return module
|
||||
}
|
||||
|
||||
// Plugin describes a java_plugin module, a host java library that will be used by javac as an annotation processor.
|
||||
type Plugin struct {
|
||||
Library
|
||||
|
||||
@@ -50,3 +58,32 @@ type PluginProperties struct {
|
||||
// parallelism and cause more recompilation for modules that depend on modules that use this plugin.
|
||||
Generates_api *bool
|
||||
}
|
||||
|
||||
type pluginAttributes struct {
|
||||
*javaLibraryAttributes
|
||||
Processor_class *string
|
||||
Target_compatible_with bazel.LabelListAttribute
|
||||
}
|
||||
|
||||
// ConvertWithBp2build is used to convert android_app to Bazel.
|
||||
func (p *Plugin) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
|
||||
libAttrs := p.convertLibraryAttrsBp2Build(ctx)
|
||||
attrs := &pluginAttributes{
|
||||
libAttrs,
|
||||
nil,
|
||||
bazel.LabelListAttribute{},
|
||||
}
|
||||
|
||||
if p.pluginProperties.Processor_class != nil {
|
||||
attrs.Processor_class = p.pluginProperties.Processor_class
|
||||
}
|
||||
|
||||
var enabledProperty bazel.BoolAttribute
|
||||
enabledProperty.SetSelectValue(bazel.OsConfigurationAxis, android.Android.Name, proptools.BoolPtr(false))
|
||||
|
||||
props := bazel.BazelTargetModuleProperties{
|
||||
Rule_class: "java_plugin",
|
||||
}
|
||||
|
||||
ctx.CreateBazelTargetModuleWithRestrictions(props, android.CommonAttributes{Name: p.Name()}, attrs, enabledProperty)
|
||||
}
|
||||
|
Reference in New Issue
Block a user