StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid invoking sdk member to add empty list of dependencies

Browse Source 
Simplifies debugging sdk membership code when it is only called if an
appropriate member is present.

Test: m nothing
Change-Id: I32bc93e0484c829bdbd6b050822249feb6404f89
This commit is contained in:
Paul Duffin
2020-02-27 13:29:56 +00:00
parent 08798aae0b
commit cc1b3da17a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/sdk.go
View File

@@ -323,11 +323,13 @@ func memberMutator(mctx android.BottomUpMutatorContext) {
if s.Enabled() { if s.Enabled() {
for _, memberListProperty := range s.memberListProperties() { for _, memberListProperty := range s.memberListProperties() {
names := memberListProperty.getter(s.dynamicMemberTypeListProperties) names := memberListProperty.getter(s.dynamicMemberTypeListProperties)
if len(names) > 0 {
tag := memberListProperty.dependencyTag tag := memberListProperty.dependencyTag
memberListProperty.memberType.AddDependencies(mctx, tag, names) memberListProperty.memberType.AddDependencies(mctx, tag, names)
} }
} }
} }
}
} }
// Step 2: record that dependencies of SDK modules are members of the SDK modules // Step 2: record that dependencies of SDK modules are members of the SDK modules