From d75507fff7f542753f2cc3b2c8b6d022c762650d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20M=C3=A1rquez=20P=C3=A9rez=20Mu=C3=B1=C3=ADz=20D?= =?UTF-8?q?=C3=ADaz=20P=C3=BAras=20Thaureaux?= Date: Fri, 20 Aug 2021 21:02:43 +0000 Subject: [PATCH] Fix inverted error message The code checks to see if the `child` is not a Python library, but then when reporting the error it uses the module name as the dependency name and the child (dependency) as the module name Test: Existing tests pass Change-Id: Ied606342291312d8485a8fd2ddcc580ad24ae82f --- python/python.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/python.go b/python/python.go index 0f5b7880e..83844e642 100644 --- a/python/python.go +++ b/python/python.go @@ -675,7 +675,7 @@ func (p *Module) collectPathsFromTransitiveDeps(ctx android.ModuleContext) { if !isPythonLibModule(child) { ctx.PropertyErrorf("libs", "the dependency %q of module %q is not Python library!", - ctx.ModuleName(), ctx.OtherModuleName(child)) + ctx.OtherModuleName(child), ctx.ModuleName()) } // collect source and data paths, checking that there are no duplicate output file conflicts if dep, ok := child.(pythonDependency); ok {