StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Improve documentation around go/allowed-deps-error"

Browse Source
This commit is contained in:
Treehugger Robot
2023-02-14 15:00:31 +00:00
committed by Gerrit Code Review
parent 811f5c9471 87c88176fe
commit da92c3ecba
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apex/apex_singleton.go
View File

@@ -55,17 +55,17 @@ var (
touch ${out}; touch ${out};
else else
echo -e "\n******************************"; echo -e "\n******************************";
echo "ERROR: go/apex-allowed-deps-error"; echo "ERROR: go/apex-allowed-deps-error contains more information";
echo "******************************"; echo "******************************";
echo "Detected changes to allowed dependencies in updatable modules."; echo "Detected changes to allowed dependencies in updatable modules.";
echo "To fix and update packages/modules/common/build/allowed_deps.txt, please run:"; echo "To fix and update packages/modules/common/build/allowed_deps.txt, please run:";
echo -e "$$ (croot && packages/modules/common/build/update-apex-allowed-deps.sh)\n"; echo -e "$$ (croot && packages/modules/common/build/update-apex-allowed-deps.sh)\n";
echo "When submitting the generated CL, you must include the following information"; echo "When submitting the generated CL, you must include the following information";
echo "in the commit message if you are adding a new dependency:"; echo "in the commit message if you are adding a new dependency:";
echo "Apex-Size-Increase:"; echo "Apex-Size-Increase: Expected binary size increase for affected APEXes (or the size of the .jar / .so file of the new library)";
echo "Previous-Platform-Support:"; echo "Previous-Platform-Support: Are the maintainers of the new dependency committed to supporting previous platform releases?";
echo "Aosp-First:"; echo "Aosp-First: Is the new dependency being developed AOSP-first or internal?";
echo "Test-Info:"; echo "Test-Info: What’s the testing strategy for the new dependency? Does it have its own tests, and are you adding integration tests? How/when are the tests run?";
echo "You do not need OWNERS approval to submit the change, but mainline-modularization@"; echo "You do not need OWNERS approval to submit the change, but mainline-modularization@";
echo "will periodically review additions and may require changes."; echo "will periodically review additions and may require changes.";
echo -e "******************************\n"; echo -e "******************************\n";