From c9e360ac8a13fdba172181f5977f100ada11ac42 Mon Sep 17 00:00:00 2001 From: Tobias Thierer Date: Tue, 27 Mar 2018 00:15:29 +0100 Subject: [PATCH] javadoc/droidoc: Don't add .jar files to sourcepath. javadoc expects directories on the sourcepath, not jar files. The original commit 88b607994a148f4af5bffee163e39ce8296750c6 in 2009 was already passing the jar files, and every revision since then seems to have kept this habit through cargo cult. This CL removes the superfluous jar file arguments from the sourcepath argument to javadoc. Test: Treehugger Bug: 76436487 Change-Id: I3a8503ae089cd6657a698c0552dc194156311849 --- java/droiddoc.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/java/droiddoc.go b/java/droiddoc.go index c65911ce3..3d279769e 100644 --- a/java/droiddoc.go +++ b/java/droiddoc.go @@ -340,8 +340,6 @@ func (j *Javadoc) collectDeps(ctx android.ModuleContext) deps { j.properties.Local_sourcepaths = append(j.properties.Local_sourcepaths, ".") } j.sourcepaths = android.PathsForModuleSrc(ctx, j.properties.Local_sourcepaths) - j.sourcepaths = append(j.sourcepaths, deps.bootClasspath...) - j.sourcepaths = append(j.sourcepaths, deps.classpath...) return deps }