Fix: deps to sanitizer runtime libs are with correct 'image' variant

am: 3b1746a212

Change-Id: Ie04156a9528e39d378d7eddec3500e789381303b
This commit is contained in:
Jiyong Park
2019-01-30 09:24:27 -08:00
committed by android-build-merger
2 changed files with 15 additions and 9 deletions

View File

@@ -1175,15 +1175,9 @@ func (c *Module) DepsMutator(actx android.BottomUpMutatorContext) {
depTag = headerExportDepTag
}
if buildStubs {
imageVariation := "core"
if c.useVndk() {
imageVariation = "vendor"
} else if c.inRecovery() {
imageVariation = "recovery"
}
actx.AddFarVariationDependencies([]blueprint.Variation{
{Mutator: "arch", Variation: ctx.Target().String()},
{Mutator: "image", Variation: imageVariation},
{Mutator: "image", Variation: c.imageVariation()},
}, depTag, lib)
} else {
actx.AddVariationDependencies(nil, depTag, lib)
@@ -1845,6 +1839,16 @@ func (c *Module) IsInstallableToApex() bool {
return false
}
func (c *Module) imageVariation() string {
variation := "core"
if c.useVndk() {
variation = "vendor"
} else if c.inRecovery() {
variation = "recovery"
}
return variation
}
//
// Defaults
//

View File

@@ -787,7 +787,7 @@ func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
}
if mctx.Device() && runtimeLibrary != "" {
if inList(runtimeLibrary, llndkLibraries) && !c.static() {
if inList(runtimeLibrary, llndkLibraries) && !c.static() && c.useVndk() {
runtimeLibrary = runtimeLibrary + llndkLibrarySuffix
}
@@ -802,12 +802,14 @@ func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
// static executable gets static runtime libs
mctx.AddFarVariationDependencies([]blueprint.Variation{
{Mutator: "link", Variation: "static"},
{Mutator: "image", Variation: c.imageVariation()},
{Mutator: "arch", Variation: mctx.Target().String()},
}, staticDepTag, runtimeLibrary)
} else if !c.static() {
// dynamic executable andshared libs get shared runtime libs
// dynamic executable and shared libs get shared runtime libs
mctx.AddFarVariationDependencies([]blueprint.Variation{
{Mutator: "link", Variation: "shared"},
{Mutator: "image", Variation: c.imageVariation()},
{Mutator: "arch", Variation: mctx.Target().String()},
}, earlySharedDepTag, runtimeLibrary)
}