From e17caa63a61a53a7832b59e7a53ac1c3d82801b4 Mon Sep 17 00:00:00 2001 From: Jooyung Han Date: Wed, 8 Apr 2020 14:13:04 +0900 Subject: [PATCH] Apex: add NeverAllowRule for updatable to enforce that apexes that set updatable: true also set min_sdk_version Bug: 152655956 Test: m Change-Id: I0d2e9f9b3234873de073ab82d91211faedd16498 --- apex/apex.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/apex/apex.go b/apex/apex.go index 8e3e56216..3f790dcf9 100644 --- a/apex/apex.go +++ b/apex/apex.go @@ -1005,6 +1005,12 @@ func makeApexAvailableWhitelist() map[string][]string { } func init() { + android.AddNeverAllowRules(android.NeverAllow(). + ModuleType("apex"). + With("updatable", "true"). + With("min_sdk_version", ""). + Because("All updatable apexes should set min_sdk_version.")) + android.RegisterModuleType("apex", BundleFactory) android.RegisterModuleType("apex_test", testApexBundleFactory) android.RegisterModuleType("apex_vndk", vndkApexBundleFactory)