StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Allow libcore to have NewApi warnings"

Browse Source
This commit is contained in:
Treehugger Robot
2022-08-19 14:32:57 +00:00
committed by Gerrit Code Review
parent 3651a5dccb b816652ee0
commit e29d230b75
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/lint.go
View File

@@ -331,12 +331,18 @@ func (l *linter) lint(ctx android.ModuleContext) {
if l.minSdkVersion != l.compileSdkVersion { if l.minSdkVersion != l.compileSdkVersion {
l.extraMainlineLintErrors = append(l.extraMainlineLintErrors, updatabilityChecks...) l.extraMainlineLintErrors = append(l.extraMainlineLintErrors, updatabilityChecks...)
// Skip lint warning checks for NewApi warnings for libcore where they come from source
// files that reference the API they are adding (b/208656169).
if ctx.ModuleDir() != "libcore" {
_, filtered := android.FilterList(l.properties.Lint.Warning_checks, updatabilityChecks) _, filtered := android.FilterList(l.properties.Lint.Warning_checks, updatabilityChecks)
if len(filtered) != 0 { if len(filtered) != 0 {
ctx.PropertyErrorf("lint.warning_checks", ctx.PropertyErrorf("lint.warning_checks",
"Can't treat %v checks as warnings if min_sdk_version is different from sdk_version.", filtered) "Can't treat %v checks as warnings if min_sdk_version is different from sdk_version.", filtered)
} }
_, filtered = android.FilterList(l.properties.Lint.Disabled_checks, updatabilityChecks) }
_, filtered := android.FilterList(l.properties.Lint.Disabled_checks, updatabilityChecks)
if len(filtered) != 0 { if len(filtered) != 0 {
ctx.PropertyErrorf("lint.disabled_checks", ctx.PropertyErrorf("lint.disabled_checks",
"Can't disable %v checks if min_sdk_version is different from sdk_version.", filtered) "Can't disable %v checks if min_sdk_version is different from sdk_version.", filtered)