StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Disable dtor inlining for clang-tidy"

Browse Source 
am: 5e011a2531

Change-Id: I40e7ba8727a5e8f1b79193aef308b3f9b8a4c899
This commit is contained in:
George Burgess IV
2018-05-15 15:34:46 -07:00
committed by android-build-merger
parent faa09cd8c2 5e011a2531
commit e4f8bd3770
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
cc/tidy.go
View File

@@ -83,9 +83,21 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags {
flags.TidyFlags = append(flags.TidyFlags, "-extra-arg-before=-fno-caret-diagnostics") flags.TidyFlags = append(flags.TidyFlags, "-extra-arg-before=-fno-caret-diagnostics")
} }
// We might be using the static analyzer through clang tidy. extraArgFlags := []string{
// https://bugs.llvm.org/show_bug.cgi?id=32914 // We might be using the static analyzer through clang tidy.
flags.TidyFlags = append(flags.TidyFlags, "-extra-arg-before=-D__clang_analyzer__") // https://bugs.llvm.org/show_bug.cgi?id=32914
"-D__clang_analyzer__",
// A recent change in clang-tidy (r328258) enabled destructor inlining, which
// appears to cause a number of false positives. Until that's resolved, this turns
// off the effects of r328258.
// https://bugs.llvm.org/show_bug.cgi?id=37459
"-Xclang", "-analyzer-config", "-Xclang", "c++-temp-dtor-inlining=false",
}
for _, f := range extraArgFlags {
flags.TidyFlags = append(flags.TidyFlags, "-extra-arg-before="+f)
}
tidyChecks := "-checks=" tidyChecks := "-checks="
if checks := ctx.Config().TidyChecks(); len(checks) > 0 { if checks := ctx.Config().TidyChecks(); len(checks) > 0 {