From e6840726bd255f141ae3dba614c9286528d71281 Mon Sep 17 00:00:00 2001 From: Pirama Arumuga Nainar Date: Wed, 12 Jan 2022 11:48:13 -0800 Subject: [PATCH] [coverage] Override -Wframe-larger-than Bug: http://b/214221000 Bug: http://b/194128476 Adding `-mllvm -runtime-counter-relocation` for continuous coverage has caused -Wframe-larger-than warnings when linking libart. These warnings need not be enforced on coverage builds, so override the flag. Test: NATIVE_COVERAGE_PATHS=art CLANG_COVERAGE=true m libart; also go/abtd on failing target. Change-Id: I8f5ac725ff5c674e6dd0831136d3d8b2e42b0428 --- cc/coverage.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cc/coverage.go b/cc/coverage.go index 59c886439..cd7b199d8 100644 --- a/cc/coverage.go +++ b/cc/coverage.go @@ -104,6 +104,8 @@ func (cov *coverage) flags(ctx ModuleContext, flags Flags, deps PathDeps) (Flags } else if clangCoverage { flags.Local.CommonFlags = append(flags.Local.CommonFlags, profileInstrFlag, "-fcoverage-mapping", "-Wno-pass-failed", "-D__ANDROID_CLANG_COVERAGE__") + // Override -Wframe-larger-than that a module may use. + flags.Local.CFlags = append(flags.Local.CFlags, "-Wno-frame-larger-than=") if EnableContinuousCoverage(ctx) { flags.Local.CommonFlags = append(flags.Local.CommonFlags, "-mllvm", "-runtime-counter-relocation") }