From 8bf6cad1708b3552a2895e4b2ff9514b8e57c9d1 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Mon, 28 Feb 2022 13:07:03 -0800 Subject: [PATCH] Increase errorprone heap size Increase the size of the errorprone heap to fix OOM exceptions. Bug: 221480398 Test: forrest Change-Id: Ia74fd4ecc57f08bcbaa1388e0734ee0cce8ae1a4 --- java/base.go | 2 +- java/config/config.go | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/java/base.go b/java/base.go index 42d7733ca..1537a780a 100644 --- a/java/base.go +++ b/java/base.go @@ -839,7 +839,7 @@ func (j *Module) collectBuilderFlags(ctx android.ModuleContext, deps deps) javaB } errorProneFlags = append(errorProneFlags, j.properties.Errorprone.Javacflags...) - flags.errorProneExtraJavacFlags = "${config.ErrorProneFlags} " + + flags.errorProneExtraJavacFlags = "${config.ErrorProneHeapFlags} ${config.ErrorProneFlags} " + "'" + strings.Join(errorProneFlags, " ") + "'" flags.errorProneProcessorPath = classpath(android.PathsForSource(ctx, config.ErrorProneClasspath)) } diff --git a/java/config/config.go b/java/config/config.go index ea2f93449..39584cb83 100644 --- a/java/config/config.go +++ b/java/config/config.go @@ -68,6 +68,12 @@ func init() { pctx.StaticVariable("JavacHeapSize", "2048M") pctx.StaticVariable("JavacHeapFlags", "-J-Xmx${JavacHeapSize}") + + // ErrorProne can use significantly more memory than javac alone, give it a higher heap + // size (b/221480398). + pctx.StaticVariable("ErrorProneHeapSize", "4096M") + pctx.StaticVariable("ErrorProneHeapFlags", "-J-Xmx${ErrorProneHeapSize}") + pctx.StaticVariable("DexFlags", "-JXX:OnError='cat hs_err_pid%p.log' -JXX:CICompilerCount=6 -JXX:+UseDynamicNumberOfGCThreads") pctx.StaticVariable("CommonJdkFlags", strings.Join([]string{