StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lto: Rename Disabled to Never to reduce confusion

Browse Source 
Having different name from the underlying property is confusing...

Test: build
Change-Id: Ia24b664d6cded68abed2966455193f0e20757e06
This commit is contained in:
Yi Kong
2020-09-28 14:41:50 +08:00
parent d124b6b4e8
commit f43ff059ff
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cc/lto.go
View File

@@ -133,7 +133,7 @@ func (lto *lto) flags(ctx BaseModuleContext, flags Flags) Flags {
// Can be called with a null receiver
func (lto *lto) LTO() bool {
if lto == nil || lto.Disabled() {
if lto == nil || lto.Never() {
return false
}
@@ -146,7 +146,7 @@ func (lto *lto) FullLTO() bool {
func (lto *lto) ThinLTO() bool {
if Bool(lto.Properties.GlobalThin) {
if !lto.Disabled() && !lto.FullLTO() {
if !lto.Never() && !lto.FullLTO() {
return true
}
}
@@ -155,8 +155,8 @@ func (lto *lto) ThinLTO() bool {
}
// Is lto.never explicitly set to true?
func (lto *lto) Disabled() bool {
return lto.Properties.Lto.Never != nil && *lto.Properties.Lto.Never
func (lto *lto) Never() bool {
return Bool(lto.Properties.Lto.Never)
}
// Propagate lto requirements down from binaries
@@ -184,7 +184,7 @@ func ltoDepsMutator(mctx android.TopDownMutatorContext) {
}
if dep, ok := dep.(*Module); ok && dep.lto != nil &&
!dep.lto.Disabled() {
!dep.lto.Never() {
if full && !dep.lto.FullLTO() {
dep.lto.Properties.FullDep = true
}