StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check ABI stability of all NDK libs

Browse Source 
This commit extends ABI stability checks to all NDK shared libs
(including the framework-related ones such as libandroid.so).

Bug: 112404572
Bug: 79576032
Test: make findlsdumps  # (and check the output)
Change-Id: I0147c60ce0c90d187f85b996911d98326a0c37ae
This commit is contained in:
Logan Chien
2018-08-02 02:27:02 +08:00
parent 2d31ace93e
commit f4b79c684a
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cc/cc.go
View File

@@ -585,6 +585,9 @@ func (ctx *moduleContextImpl) shouldCreateVndkSourceAbiDump() bool {
if inList(ctx.baseModuleName(), llndkLibraries) { if inList(ctx.baseModuleName(), llndkLibraries) {
return true return true
} }
if inList(ctx.baseModuleName(), ndkMigratedLibs) {
return true
}
if ctx.useVndk() && ctx.isVndk() { if ctx.useVndk() && ctx.isVndk() {
// Return true if this is VNDK-core, VNDK-SP, or VNDK-Ext and this is not // Return true if this is VNDK-core, VNDK-SP, or VNDK-Ext and this is not
// VNDK-private. // VNDK-private.

2
cc/library.go
View File

@@ -604,7 +604,7 @@ func (library *libraryDecorator) linkShared(ctx ModuleContext,
} }
func getRefAbiDumpFile(ctx ModuleContext, vndkVersion, fileName string) android.Path { func getRefAbiDumpFile(ctx ModuleContext, vndkVersion, fileName string) android.Path {
isLlndk := inList(ctx.baseModuleName(), llndkLibraries) isLlndk := inList(ctx.baseModuleName(), llndkLibraries) || inList(ctx.baseModuleName(), ndkMigratedLibs)
refAbiDumpTextFile := android.PathForVndkRefAbiDump(ctx, vndkVersion, fileName, isLlndk, false) refAbiDumpTextFile := android.PathForVndkRefAbiDump(ctx, vndkVersion, fileName, isLlndk, false)
refAbiDumpGzipFile := android.PathForVndkRefAbiDump(ctx, vndkVersion, fileName, isLlndk, true) refAbiDumpGzipFile := android.PathForVndkRefAbiDump(ctx, vndkVersion, fileName, isLlndk, true)