bp2build conversion for Sanitize.Integer_overflow

and Sanitize.Misc_undefined.

This is a redo of aosp/2277186 with changes to account for issues
in mixed builds. Specifically, for now we're disabling mixed builds
for modules that use ubsan. This bug tracks enabling it:
b/261058727.

Bug: 253428057
Test: Unit tests
Change-Id: I9dbec1d99353f8cbe6751d5241283ab19592dc27
This commit is contained in:
Trevor Radcliffe
2022-10-28 16:48:18 +00:00
parent c03724c442
commit f82482db31
6 changed files with 377 additions and 3 deletions

View File

@@ -789,3 +789,82 @@ func TestCcBinaryWithSyspropSrcsSomeConfigs(t *testing.T) {
},
})
}
func TestCcBinaryWithIntegerOverflowProperty(t *testing.T) {
runCcBinaryTestCase(t, ccBinaryBp2buildTestCase{
description: "cc_binary with integer overflow property specified",
blueprint: `
{rule_name} {
name: "foo",
sanitize: {
integer_overflow: true,
},
}`,
targets: []testBazelTarget{
{"cc_binary", "foo", AttrNameToString{
"local_includes": `["."]`,
"features": `["ubsan_integer_overflow"]`,
}},
},
})
}
func TestCcBinaryWithMiscUndefinedProperty(t *testing.T) {
runCcBinaryTestCase(t, ccBinaryBp2buildTestCase{
description: "cc_binary with miscellaneous properties specified",
blueprint: `
{rule_name} {
name: "foo",
sanitize: {
misc_undefined: ["undefined", "nullability"],
},
}`,
targets: []testBazelTarget{
{"cc_binary", "foo", AttrNameToString{
"local_includes": `["."]`,
"features": `[
"ubsan_undefined",
"ubsan_nullability",
]`,
}},
},
})
}
func TestCcBinaryWithUBSanPropertiesArchSpecific(t *testing.T) {
runCcBinaryTestCase(t, ccBinaryBp2buildTestCase{
description: "cc_binary has correct feature select when UBSan props are specified in arch specific blocks",
blueprint: `
{rule_name} {
name: "foo",
sanitize: {
misc_undefined: ["undefined", "nullability"],
},
target: {
android: {
sanitize: {
misc_undefined: ["alignment"],
},
},
linux_glibc: {
sanitize: {
integer_overflow: true,
},
},
},
}`,
targets: []testBazelTarget{
{"cc_binary", "foo", AttrNameToString{
"local_includes": `["."]`,
"features": `[
"ubsan_undefined",
"ubsan_nullability",
] + select({
"//build/bazel/platforms/os:android": ["ubsan_alignment"],
"//build/bazel/platforms/os:linux": ["ubsan_integer_overflow"],
"//conditions:default": [],
})`,
}},
},
})
}