From 8959e149b713f6c7332f9eda80fe5dc47c9d0718 Mon Sep 17 00:00:00 2001 From: Anton Hansson Date: Wed, 25 Apr 2018 11:56:13 +0100 Subject: [PATCH] Add some friendly error messages for java_sdk_library. The stubs will always fail to build without at least these three arguments. Give a clear error message when this happens instead of failing further into the build. Bug: 77575606 Test: make .stubs for sdk_library "x" without these args Change-Id: If3142ecc73d6428f7e3120788f8de64d56a777ad --- java/sdk_library.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/java/sdk_library.go b/java/sdk_library.go index 45a6a0939..52e713fa1 100644 --- a/java/sdk_library.go +++ b/java/sdk_library.go @@ -485,6 +485,13 @@ func javaSdkLibraries(config android.Config) *[]string { // once for public API level and once for system API level func sdkLibraryMutator(mctx android.TopDownMutatorContext) { if module, ok := mctx.Module().(*sdkLibrary); ok { + if module.properties.Srcs == nil { + mctx.PropertyErrorf("srcs", "java_sdk_library must specify srcs") + } + if module.properties.Api_packages == nil { + mctx.PropertyErrorf("api_packages", "java_sdk_library must specify api_packages") + } + // for public API stubs module.createStubsLibrary(mctx, apiScopePublic) module.createDocs(mctx, apiScopePublic)