bp2build code generator: pretty print zero values
e.g for zero slices, return the empty list, instead of an empty string. Test: TH Change-Id: I7c89d7b0f6ac28d1aa1a76d604173bc99c841a02
This commit is contained in:
@@ -370,9 +370,20 @@ func prettyPrint(propertyValue reflect.Value, indent int) (string, error) {
|
||||
// values for unset properties, like system_shared_libs = ["libc", "libm", "libdl"] at
|
||||
// https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=281-287;drc=f70926eef0b9b57faf04c17a1062ce50d209e480
|
||||
//
|
||||
// In Bazel-parlance, we would use "attr.<type>(default = <default value>)" to set the default
|
||||
// value of unset attributes.
|
||||
return "", nil
|
||||
// In Bazel-parlance, we would use "attr.<type>(default = <default
|
||||
// value>)" to set the default value of unset attributes. In the cases
|
||||
// where the bp2build converter didn't set the default value within the
|
||||
// mutator when creating the BazelTargetModule, this would be a zero
|
||||
// value. For those cases, we return a non-surprising default value so
|
||||
// generated BUILD files are syntactically correct.
|
||||
switch propertyValue.Kind() {
|
||||
case reflect.Slice:
|
||||
return "[]", nil
|
||||
case reflect.Map:
|
||||
return "{}", nil
|
||||
default:
|
||||
return "", nil
|
||||
}
|
||||
}
|
||||
|
||||
var ret string
|
||||
|
Reference in New Issue
Block a user