Commit Graph

66166 Commits

Author SHA1 Message Date
Florian Mayer
a998446d3e [hwasan] Also pass use-after-scope flag in LTO
Change-Id: I3df3d3047fd5aaa93e6c4b68885d39e20b12ccdb
2023-06-16 17:34:57 -07:00
Jared Duke
91f32e7ae5 Suppress resourceshrinker stdout in soong
The resourceshrinker command prints an info log for successful runs,
which we don't really need to surface in build output. Suppress stdout
for such invocations; errors will surface through stderr.

Bug: 202959019
Test: m + compare log output
Change-Id: I08ed465bb7e3a0fa8d5e967d858f6739b5ef7fad
2023-06-16 23:12:33 +00:00
Florian Mayer
2bddccd837 Reland "Re-enable stack frame size errors"
This reverts commit 25cd981362.

Reason for revert: b/274474681 is fixed.

Bug: 229654778
Change-Id: I4b975ced02ffe0d5a432a3033f05bb61868bec45
2023-06-16 22:34:41 +00:00
Chris Parsons
e1f25230df Add unit test for parsing build files in bp2build
This involves some minor changes to testing infrastructure.

Bug: 285631638
Fixes: 286545783
Test: unit test
Change-Id: If64ba29308d99e63a1cc5526feaf077f2cb14478
2023-06-16 21:09:19 +00:00
Trevor Radcliffe
523c5c6597 Explicitly disable CFI in bp2build when false
In Soong, CFI being explicitly set to false overrides presence in
CFI_INCLUDE_PATHS, so this change causes Bazel to mimic the same
precedence.

Bug: 278789968
Test: Unit tests
Change-Id: I827b3d4272eac2002031970f1e67c9321979b14b
2023-06-16 20:15:45 +00:00
Chris Parsons
b7950a93df Add -gen suffix to genrule targets with conflicts
Fixes: 224580460
Test: m nothing
Change-Id: I3af3eb0fb7f65216087482eb620484229ac7d674
2023-06-16 17:41:42 +00:00
Spandan Das
7bdea7e56d Always use the BUILD files from bazelbuild-rules_go
This repository contains the core go rules

Test: TH
Bug: 284483729
Change-Id: I4385c84140f2e41bfa5e5cd5434a212c138f456a
2023-06-16 17:16:43 +00:00
Christopher Parsons
975051cb58 Merge "Provide reason for unconverted bp2build modules" am: df9c3441aa
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2617572

Change-Id: I75e96c59f822c1445b6e50860916550f60726f66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 14:39:14 +00:00
Christopher Parsons
df9c3441aa Merge "Provide reason for unconverted bp2build modules" 2023-06-16 13:49:49 +00:00
Chris Parsons
39a169721c Provide reason for unconverted bp2build modules
This also changes the expectation of ConvertWithBp2build. Each
implementation must either create one or more Bazel target modules, or
mark the module as unconvertible (with a specific reason).

Manually verified no runtime hit in AOSP
In AOSP, the metrics file size increases from 252K to 1.6M

This changes some effective module counts in bp2build metrics:
 - Removes "package" modules from the module count list in
metrics, as these will not be converted like regular modules.
 - Counts Handcrafted modules as being "unconverted", as bp2build is not
   responsible for them.

Bug: 285631638
Test: Verified generated BUILD.bazel files are bit-for-bit identical
with this change
Test: Manually verified one case of each implemented reasonType

Change-Id: I308dd451d8f28379b15671dae9f931bd0446f5c1
2023-06-16 13:45:17 +00:00
Inseob Kim
e7ceeb5c35 Merge "Fix soong config hash missing for some modules" am: 55be40beb4
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2628789

Change-Id: I823dbf8a2ec246ffb7f24843925b764c307119e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 12:22:47 +00:00
Inseob Kim
55be40beb4 Merge "Fix soong config hash missing for some modules" 2023-06-16 11:28:19 +00:00
Kiyoung Kim
1407c03be2 Merge "Remove symlink to the build.ninja" am: aa003b3833
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2623890

Change-Id: If9eab5a487e39aeb3754a554b83df4df179bc22c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 08:37:58 +00:00
Kiyoung Kim
aa003b3833 Merge "Remove symlink to the build.ninja" 2023-06-16 08:06:06 +00:00
Jooyung Han
60ecb960ba Merge "Remove --blkid_path argument" am: ee31de71c7
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2624311

Change-Id: I6c436e49d70d9375a6f16ad7cba2c7ef03bf71a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 07:30:00 +00:00
Inseob Kim
8ff69de0f7 Fix soong config hash missing for some modules
Bug: 279362051
Test: see outputs of C++ modules using soong config
Change-Id: I95e41350ff17a989faf7c010a4c4ed4fcd79d66b
2023-06-16 15:52:15 +09:00
Jooyung Han
ee31de71c7 Merge "Remove --blkid_path argument" 2023-06-16 06:49:13 +00:00
Treehugger Robot
125325cc6d Merge "Add implementation whole archive deps to binaries" am: b2c6076e43
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2628589

Change-Id: Ie19c1fa83a83c50bd59886f05921e9ae00fcb8b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 02:47:45 +00:00
Treehugger Robot
b2c6076e43 Merge "Add implementation whole archive deps to binaries" 2023-06-16 02:15:06 +00:00
Jason Macnak
9fd8914c76 Merge changes from topic "roboleaf-busy-beavers-wmediumd" am: eefac275c1
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2627811

Change-Id: Ieefd1b5af97285d6ae9400c8d7f7b8640198d5f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 01:17:18 +00:00
Jason Macnak
eefac275c1 Merge changes from topic "roboleaf-busy-beavers-wmediumd"
* changes:
  Fix local var error, warn if no outputs, handle "}generate{"
  Remove WmediumdServerProto_[cc|h] from SandboxingDenyModuleList
2023-06-16 00:55:11 +00:00
Ivan Lozano
7a3d00042d Merge "rust: Make dylib-std the canonical rlib form" am: 85cc859d73
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2626538

Change-Id: I664e262f2453bd339f5c2ddd107312cb85f4f653
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 00:53:31 +00:00
Ivan Lozano
85cc859d73 Merge "rust: Make dylib-std the canonical rlib form" 2023-06-16 00:39:55 +00:00
Treehugger Robot
281477fda7 Merge "Dynamically link static libs for sdk_library created java_library" am: 0e7d0fa05c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2619526

Change-Id: Iddf805bdc8442343450cc56e6e9430dc94a4264a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 00:30:54 +00:00
Treehugger Robot
0e7d0fa05c Merge "Dynamically link static libs for sdk_library created java_library" 2023-06-15 23:39:39 +00:00
Dan Shi
9b4835c360 Remove unnecessary variable
Bug: 284179405
Test: m
Change-Id: I1b5b2559837d27e8e380bb700b2b7ad674d8b079
2023-06-15 23:22:39 +00:00
Treehugger Robot
47f56c33b9 Merge "turn off log spew" am: 886cd6d6e9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2621432

Change-Id: I3578f2d6415f593b5c53cdf1d526a34592fbf50b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 23:00:26 +00:00
Treehugger Robot
886cd6d6e9 Merge "turn off log spew" 2023-06-15 22:21:38 +00:00
Cole Faust
6cac8cbb26 Add implementation whole archive deps to binaries
...as regular whole archive deps because binaries don't have
implementation whole archive deps.

Also allowlist checkpolicy which requires this change.

Test: bp2build presubmits should now build checkpolicy
Change-Id: I1f98312da249ea1f37004ccba8799449bdbc4718
2023-06-15 15:01:30 -07:00
Jihoon Kang
6c0df88809 Cleanup remaining android.JavaApiLibraryName() references
Since the name of the java_library generated from sdk_library per api
scope does not depend on the build configuration anymore, all
dependency switching "magic" via android.JavaApiLibraryName() can be
removed.

This change also removes from-text-build-specific test cases, as those
test cases depend on build configurations.

Test: m nothing && m nothing --build-from-text-stub
Bug: 287340610
Change-Id: I3bac35259e0cbaa16432a46cb2b128951c9bc075
2023-06-15 19:42:34 +00:00
Treehugger Robot
a8015f50ad Merge "Increase config fetcher timeout to 20s" am: d34e4c72f3
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2618169

Change-Id: I3750e7035704e1bd5b30f6158837f7161f7eb3e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 19:37:56 +00:00
Treehugger Robot
7d698334d3 Merge "Remove bazel dev mode" am: 2428d41268
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2626534

Change-Id: Id0ef762400d158a97efc104493a45f6de7aa179e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 19:37:11 +00:00
Jihoon Kang
3d4d88d68e Allow java_library.exclude_static_libs property for libcore and f/b/api
exclude_static_lib property was introduced to enable static lib
switching based on build configuration. The usage of property was
limited to build/soong directory to prevent other modules from using the
proerty.

In order to allow "core-lambda-stubs" and
"android-non-updatable.stubs.*" to utilize similar static lib switching
based on build configuration, allow exclude_static_libs property to be
used in libcore and frameworks/base/api directory.

Test: m nothing
Bug: 287344503
Change-Id: I342b09c7ada03607b12dc8896ae39825d8545e92
2023-06-15 18:51:57 +00:00
Treehugger Robot
a6ba02f0ed Merge "Move bazel environment variable list to bzl files" am: b8f50fde26
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2627435

Change-Id: I8d35c9e743f13598dd29a55c537f023f9fadbdd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 18:51:38 +00:00
Treehugger Robot
d34e4c72f3 Merge "Increase config fetcher timeout to 20s" 2023-06-15 18:37:53 +00:00
Ivan Lozano
4df0257fe5 rust: Make dylib-std the canonical rlib form
This removes the dylib-std suffix from rlib variants which link against
libstd dynamically. This is by far the common case.

This fixes an issue where 'm <rust_library_rlib>' would fail since Make
would expect the suffix to be included (e.g. 'm libfoo.dylib-std').

Bug: 173312517
Bug: 268086496
Test: m <rust_library_rlib> # without a suffix
Change-Id: I1e5778c57468302a8d672d5eb540047d8bb79314
2023-06-15 18:29:22 +00:00
Treehugger Robot
2428d41268 Merge "Remove bazel dev mode" 2023-06-15 18:28:13 +00:00
Treehugger Robot
b8f50fde26 Merge "Move bazel environment variable list to bzl files" 2023-06-15 18:25:40 +00:00
Jihoon Kang
1147b31eb0 Dynamically link static libs for sdk_library created java_library
Rename java_library created inside sdk_library with the ".from-source"
suffix, and set it as static lib of the top level java_library, which
gets java_api_library instead as static lib during from-text stub build.

Test: m nothing && m nothing --build-from-text-stub
Bug: 286446015
Change-Id: I32e8ea264987e9f9df05e462292bd54e45074912
2023-06-15 18:18:09 +00:00
Jason Macnak
394f1b7b86 Fix local var error, warn if no outputs, handle "}generate{"
1. UnboundLocalError: cannot access local variable 'output' where
   it is not associated with a value

2. `build/soong/tests/genrule_sandbox_test.py WmediumdServerProto_cc`
   would try to build the entire world due to 3)

3. WmediumdServerProto_cc 's module action desc had '}generate{'
   without a space which would cause 2)

Bug: b/287470077
Test: build/soong/tests/genrule_sandbox_test.py WmediumdServerProto_cc
Change-Id: Ie9d5db44195a6f700cc876ec889bd01c11e66cff
2023-06-15 10:59:20 -07:00
Jason Macnak
be29dc3d4f Remove WmediumdServerProto_[cc|h] from SandboxingDenyModuleList
Bug: b/287470077
Test: GENRULE_SANDBOXING=true m WmediumdServerProto_cc
Test: GENRULE_SANDBOXING=true m WmediumdServerProto_h
Test: build/soong/tests/genrule_sandbox_test.py WmediumdServerProto_cc
Test: build/soong/tests/genrule_sandbox_test.py WmediumdServerProto_h
Change-Id: I38079eb7b4bfb60f1b4c3adf6c774f207d7ec55e
2023-06-15 10:58:55 -07:00
Treehugger Robot
940707d3fe Merge "Remove debug printf." am: abcfc77717
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2625880

Change-Id: I0c22fc0bbc2dcc4944419d43f7ecbf513e0b8db7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 17:43:57 +00:00
Treehugger Robot
abcfc77717 Merge "Remove debug printf." 2023-06-15 17:18:39 +00:00
Jason Wu
614d0f2db1 Merge "Fix bp2build breakage by denylisting //system/apex/libs/libapexsupport/..." am: f7a603199c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2628129

Change-Id: I02ce431bc7d6d192b600b1399a191130acfdc1ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 16:36:07 +00:00
Jason Wu
f7a603199c Merge "Fix bp2build breakage by denylisting //system/apex/libs/libapexsupport/..." 2023-06-15 15:50:16 +00:00
Elliott Hughes
b801d6de7c Merge "riscv64: enable Zbs." am: 7225dd87f3
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2626329

Change-Id: Id13e5283cf33e7830eb0010201f083481e17063a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 15:06:08 +00:00
Treehugger Robot
a81dd34c44 Merge "Remove print statement" am: 5e3594fcf4
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2626250

Change-Id: I8158f0b1d3c6f3f6d322839875638a946d91782f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 15:05:44 +00:00
Elliott Hughes
7225dd87f3 Merge "riscv64: enable Zbs." 2023-06-15 14:28:46 +00:00
Treehugger Robot
5e3594fcf4 Merge "Remove print statement" 2023-06-15 14:24:46 +00:00
Chris Parsons
21f80277c3 Remove bazel dev mode
This mode is no longer in use, and is dead code.

Fixes: 282809863
Test: Presubmits
Change-Id: I45ab7d7c9dee153f1cbc66262c2cf9f1e9487a28
2023-06-15 14:14:19 +00:00