Commit Graph

66239 Commits

Author SHA1 Message Date
Sam Delmerico
c2322b7c2f Merge "Revert "Respect Clang version override env vars."" am: 162fb00eb3
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2537762

Change-Id: Ie13b35cc9def8540490fe4f0851bb276a9a32e2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 20:51:37 +00:00
Sam Delmerico
316b0158fe Merge "add LLVM_*_VERSION envvars to allowlist" 2023-05-01 20:23:16 +00:00
Sam Delmerico
162fb00eb3 Merge "Revert "Respect Clang version override env vars."" 2023-05-01 20:23:16 +00:00
Spandan Das
03079bd97a Merge changes from topic "bp2build-ignore-test-apex-tags" am: 934d5047ef
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2569070

Change-Id: Ida265dad77c6b9690b7b985922ff89d783f3f9ba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 16:39:29 +00:00
Spandan Das
b2b9494db1 Ignore test apexes from bp2build generated tags am: f57a966b66
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2533722

Change-Id: Ib92fe92f3f088cff422c6dabd606cbedb1d97adc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 16:39:23 +00:00
Spandan Das
934d5047ef Merge changes from topic "bp2build-ignore-test-apex-tags"
* changes:
  Ignore test apexes from bp2build generated tags
  Ignore test apexes from bp2build generated tags
2023-05-01 16:05:38 +00:00
Treehugger Robot
a54fd4c02d Merge "Allowlist more modules" am: 098f49de26
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2522215

Change-Id: I1f4102e00ebdfa88b95799647b49bbcf55a03469
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 15:14:19 +00:00
Treehugger Robot
abfe8cfd51 Merge "Correct cc_test_library migration" am: 176271a426
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2552663

Change-Id: Iabcb9820e624c9865ef86fe022d72da2f546aee0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 15:14:02 +00:00
Treehugger Robot
098f49de26 Merge "Allowlist more modules" 2023-05-01 14:53:43 +00:00
Treehugger Robot
176271a426 Merge "Correct cc_test_library migration" 2023-05-01 14:38:41 +00:00
Liz Kammer
98df04f9a2 Merge "Remove alexmarquez from owners." am: d3b78b2381
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2572771

Change-Id: Ie75711b8d47d10e7c8b40dddce13463a6ecf7f01
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 13:29:48 +00:00
Liz Kammer
d3b78b2381 Merge "Remove alexmarquez from owners." 2023-05-01 12:30:48 +00:00
Spandan Das
a5e1e7134c Merge changes Ibbb14b0d,I9aa552e3 am: 5e1525d1de
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2549672

Change-Id: Ib658d7f4e7b7b31edae8aacbf5fb82c26bf1580a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-29 04:39:05 +00:00
Spandan Das
5e1525d1de Merge changes Ibbb14b0d,I9aa552e3
* changes:
  Create config_setting per apex_name
  Add a function to create config_setting(s)
2023-04-29 03:52:55 +00:00
Treehugger Robot
daf7cb47c3 Merge "Enable HWASan for multiple modules in one place(Soong)" am: 2f6179d4f5
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2495517

Change-Id: I4d27379ae7baf22d68a48e065ecce67c12ccb70a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-29 00:48:49 +00:00
Treehugger Robot
2f6179d4f5 Merge "Enable HWASan for multiple modules in one place(Soong)" 2023-04-29 00:10:16 +00:00
Treehugger Robot
3b1fbf0846 Merge "target_sdk_version replacement should respect REL branches" am: e605b39e61
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2568331

Change-Id: Ibc857539f5b78b07bfd1ed65f1e12d49e12a0921
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 23:45:20 +00:00
Treehugger Robot
e605b39e61 Merge "target_sdk_version replacement should respect REL branches" 2023-04-28 23:18:16 +00:00
Liz Kammer
9b2ca5c8c9 Prevent sh_test from migrating as sh_binary
Test: CI
Change-Id: I4cb789e3f1351fcb1635d58b72c265eac4bf62d8
2023-04-28 17:39:24 -04:00
Spandan Das
4242f10462 Create config_setting per apex_name
These are created by bp2build in /build/bazel/rules/apex. Eventually
these config_settings should likely be colocated with the source apex
definition.

Another alternative was to make Bazel's apex a macro that generates a
config_setting. I did not pursue this further for now since it requires the
apex_available of every allowlisted cc_library to also be allowlisted.
This might not always be true (e.g. com.android.runtime)

Test: go test ./bp2build
Change-Id: Ibbb14b0d9c1491b3c79b7634a18d9d35b03922c1
2023-04-28 20:37:35 +00:00
Mark Dacek
df668cecd6 Merge "Add bazel exit code to bazel metrics proto." am: 4188a899dc
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2566591

Change-Id: I2b87c4df55c342c94274e8b6c52768418c27614a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 20:13:26 +00:00
Spandan Das
6a448ec1a3 Add a function to create config_setting(s)
The use case for this is creating config_setting(s) specific to an apex
variant and selecting stub/impl in that config_setting. We likely need
only a handful of such config_setting(s), but determining that list
requires iterating the build graph.

Test: go test ./bp2build
Change-Id: I9aa552e3d0bcf67513023c3a7d4bbf8fae464ee4
2023-04-28 19:43:43 +00:00
Mark Dacek
4188a899dc Merge "Add bazel exit code to bazel metrics proto." 2023-04-28 19:40:52 +00:00
Liz Kammer
d2442920d7 Remove alexmarquez from owners.
Test: n/a
Change-Id: Ic303c60bd688023bac8225c4f8435fbbb2272252
2023-04-28 15:39:43 -04:00
Juan Yescas
62cfd6de60 16k: Align shared libraries and executables to 4k by default am: 05d4d90114
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2528644

Change-Id: I5dc49b746dc92b5697405acacf51a6d1fa56053c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 18:29:52 +00:00
Liz Kammer
f0ab546f38 Allowlist more modules
Test: CI
Test: mixed_droid
Change-Id: I9c2a816f96399401482c93cae2cb9328abbecd16
2023-04-28 13:20:36 -04:00
Spandan Das
fb6a1ee68b target_sdk_version replacement should respect REL branches
Currently, target_sdk_version of MTS tests were being set to 10000 even
in release branches. This should only happen in active branches.

Test: Unit test
Test: aapt2 on CtsContentTestCases in udc-dev and verified
targetSdkVersion is 34
Bug: 279507428

Change-Id: Ib79318febc0f6e771b3679c0281a97357930ec56
2023-04-28 16:23:53 +00:00
MarkDacek
18ed8a912b Add bazel exit code to bazel metrics proto.
Bug: 279754118
Test: N/A
Change-Id: I52558843f40bf54b75a4255b0a9d96e9dcaa81bc
2023-04-28 14:50:32 +00:00
Chris Wailes
b5ae9bcf90 rustc-1.69.0 Build 10027731
Bug: https://issuetracker.google.com/issues/274972941
Test: m rust
Change-Id: I03ba07802c2d77d5e3776cc49abac8b98d6ebbfe
2023-04-28 01:15:55 -07:00
Jeongik Cha
4753b39cca Get rid of DeviceName() from path related to dexpreopt
As-is, dexpreopt config and bootjar is in the dir including
DeviceName(). It causes unnecessary dexpreopt invocation when target is
changed repeatly. To avoid it, rename dir to common name.

Bug: 278833696
Test: m
Change-Id: I2818d9ae09e6c22ca6989cc8efdb70b470ec502c
2023-04-28 11:50:18 +09:00
Juan Yescas
05d4d90114 16k: Align shared libraries and executables to 4k by default
The default ELF segment alignment will be 4096. This alignment
can be overriden by setting the desired alignment in
PRODUCT_MAX_PAGE_SIZE_SUPPORTED flag. The alignment has to be
a multiple of the configured kernel page size.

Test: Built changes for Pixel 4a, 6 and checked alignment.
Bug: 276963698
Bug: 276801883
Change-Id: Icb380041a5b27da1fa0d86b302e1e7cde9a236d7
2023-04-28 02:42:20 +00:00
Spandan Das
8932cfa2b5 Merge changes I91063ebb,Id859723b am: 12d170dc2a
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2565920

Change-Id: I4fc0a12816a8728d1f23ea6cffd2068f026134e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 00:34:39 +00:00
Spandan Das
31db86106e Merge "Re-enable TestMixedBuildUsesStubs" am: c0f9a2178f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2562752

Change-Id: I966f84a32de57d252915ec220af98b07fdbbf331
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 00:33:24 +00:00
Spandan Das
12d170dc2a Merge changes I91063ebb,Id859723b
* changes:
  Differentiate between empty and nil input
  Do not modify input in-place
2023-04-28 00:07:57 +00:00
Spandan Das
20fce2d340 Enforce stub libraries should have a single apex_available
If a library contributes to an API surface, it will have only a single
copy on device. Therefore, we should disallow installation to muliple
apexes/platform.

There are some exceptions to this rule today, and they have been relaxed
using allowlists.

Bug: 277651159
Test: go test ./apex
Change-Id: Ice3023ecd28412a2610d8b98628cb727b58c5c3b
2023-04-27 23:24:55 +00:00
Spandan Das
39b6cc5336 Ignore test apexes from bp2build generated tags
Soong does not enforce apex_available on the contents of test apex. To
prevent special-casing test apexes in the apex validation aspect in
Bazel, drop the test apexes from the tags altogether.

( The core problem I am trying to solve is making sure that stub
libraries in Bazel have a single apex available. apex validation happens
to be a nice side benefit)

Bug: 277651159
Test: go test ./bp2build
Change-Id: Ibb3cfedb5c0f2cda0464bf3758c70b67cb5885d1
2023-04-27 23:24:49 +00:00
Spandan Das
c0f9a2178f Merge "Re-enable TestMixedBuildUsesStubs" 2023-04-27 23:11:14 +00:00
Spandan Das
cc4da76511 Differentiate between empty and nil input
Previously, CopyOf on an empty list was returning nil. With the updates
to SortedUniqueStrings and FirstUniqueStrings, we need to differentiate
between empty lists and nil.

Test: m nothing
Change-Id: I91063ebbe5013cbda5d8f70efde4683c66581599
2023-04-27 19:34:08 +00:00
Cole Faust
13a56750d1 Merge "Expand preprocessed flag to work on android_app_imports" am: 03cf3181d3
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2542010

Change-Id: I181377a7c6a2b3ae5e74ef4d143aefe9c8574262
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27 18:08:12 +00:00
Cole Faust
145dc54c11 Merge "Load starlark files from soong" am: 3e0836e865
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2424850

Change-Id: I8581d4388c85a01b9ad6708555e6bb1ab7533fe9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27 18:07:43 +00:00
David Fu
5139309415 Merge "Changed assignee to triage_assignee in fuzzconfig" am: eb52c2e769
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2566670

Change-Id: I59899f2162ddffd297c396b8710efc0147e7084a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27 18:03:41 +00:00
Cole Faust
03cf3181d3 Merge "Expand preprocessed flag to work on android_app_imports" 2023-04-27 17:18:59 +00:00
Cole Faust
3e0836e865 Merge "Load starlark files from soong" 2023-04-27 17:15:02 +00:00
David Fu
eb52c2e769 Merge "Changed assignee to triage_assignee in fuzzconfig" 2023-04-27 17:14:10 +00:00
Anton Hansson
d60cc478c5 Merge "Remove --skip-kati" am: c8cea365f3
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2566150

Change-Id: Icfa28a4f34c9f46b7d3c99b0034d33ec48d31dbf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27 12:08:56 +00:00
Anton Hansson
c8cea365f3 Merge "Remove --skip-kati" 2023-04-27 11:26:50 +00:00
Treehugger Robot
ca21761cc7 Merge "Add allowed-deps tests" am: da2f5ec78f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2561190

Change-Id: Ib1f6eb9111b3a4edb2303167d6c4ebe280e86cae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27 06:53:19 +00:00
Treehugger Robot
da2f5ec78f Merge "Add allowed-deps tests" 2023-04-27 06:09:35 +00:00
Mark Dacek
136d93ab09 Merge "Fix allowlist in order to mixed_build the entire prod allowlist." am: aa2e898e62
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2566111

Change-Id: I7e3ea458370c9f255e764e425a7c1fc974a78db2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27 05:07:50 +00:00
Treehugger Robot
6b5cbd2879 Merge "Remove makefile_goal" am: 3c31266816
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2564890

Change-Id: Ie32b1e522e12f4cfddfd0b19e857cf54a6b4037c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27 05:07:21 +00:00