Commit Graph

5631 Commits

Author SHA1 Message Date
Jeff Gaston
048bf57c33 Merge "Use flag.Parse in sbox" 2017-11-06 20:08:24 +00:00
Colin Cross
3d2da75029 Merge changes from topic "crt_cflags" am: 5c9cf6eb84 am: 3568303af8
am: b916e0f4f9

Change-Id: I4871e64c0b3e611c0c72321218f15a2080a3742e
2017-11-06 19:07:43 +00:00
Colin Cross
b916e0f4f9 Merge changes from topic "crt_cflags" am: 5c9cf6eb84
am: 3568303af8

Change-Id: I8f1cfd4e1420cb364523b4db203623ae05f034ea
2017-11-06 19:05:04 +00:00
Alan Leung
308ae8ff7a Merge "Always use installed version of d8-compat-dx" am: a39899edb9 am: e5e233c32c
am: 0acb7d5758

Change-Id: Ib113fab234aed517568cc28a142dd67daffbca0f
2017-11-06 19:04:38 +00:00
Colin Cross
3568303af8 Merge changes from topic "crt_cflags"
am: 5c9cf6eb84

Change-Id: I1369c0df3bf10cfe1681bffbab8f2003f1a53505
2017-11-06 19:02:47 +00:00
Alan Leung
0acb7d5758 Merge "Always use installed version of d8-compat-dx" am: a39899edb9
am: e5e233c32c

Change-Id: I1b0bd895eaf1c76a07a5784efe82bf68114bb737
2017-11-06 19:02:04 +00:00
Colin Cross
5c9cf6eb84 Merge changes from topic "crt_cflags"
* changes:
  Remove no_default_compiler_flags property
  Move -fomit-frame-pointer to armCflags
  Consolidate ldflags that are used on all devices
  Remove -Wl,--gc-sections from target flags
  Consolidate cflags that are set on all devices
  Consolidate global cflags
2017-11-06 18:59:00 +00:00
Alan Leung
e5e233c32c Merge "Always use installed version of d8-compat-dx"
am: a39899edb9

Change-Id: I78a9725262ae5c46dea73e30a3760b150bf22189
2017-11-06 18:58:14 +00:00
Alan Leung
a39899edb9 Merge "Always use installed version of d8-compat-dx" 2017-11-06 18:54:53 +00:00
Nan Zhang
ac301b582b Merge "Add default jar wrapper when wrapper property is not specified" am: 5d37417347 am: 009851da32
am: 2db3eb6010

Change-Id: Ifa404a38d40c3fea20f7a24f7550813eadd0f060
2017-11-06 18:15:01 +00:00
Nan Zhang
2db3eb6010 Merge "Add default jar wrapper when wrapper property is not specified" am: 5d37417347
am: 009851da32

Change-Id: I98373a4c43451b3d9f79c5ce9fc4275792973dcc
2017-11-06 18:12:06 +00:00
Nan Zhang
009851da32 Merge "Add default jar wrapper when wrapper property is not specified"
am: 5d37417347

Change-Id: I8449f7424286422b89e5ebf1cb7addbcfcc8d818
2017-11-06 18:07:30 +00:00
Treehugger Robot
5d37417347 Merge "Add default jar wrapper when wrapper property is not specified" 2017-11-06 18:04:27 +00:00
Colin Cross
87dd963ace Remove no_default_compiler_flags property
no_default_compiler_flags is only used by the crt* modules,
is unnecessary, and causes problems when necessary flags like
-no-canonical-prefixes are not passed.  Remove the property.

Use useVndk() instead of noDefaultCompilerFlags() to determine
if adding libc as a dependency is necessary and won't cause a
circular dependency.

Bug: 68719465
Test: m checkbuild
Change-Id: Iea1a082dc701dfeab211049a22f7066257347b80
2017-11-03 22:28:57 -07:00
Colin Cross
0f1f679f5e Move -fomit-frame-pointer to armCflags
-fomit-frame-pointer was specified twice, once for arm and once for
thumb.  Move it to the shared cflags.

Bug: 68855788
Test: m checkbuild
Change-Id: Iab1299c247808f1a2542b468084600b7c32996e8
2017-11-03 22:28:12 -07:00
Colin Cross
324a457440 Consolidate ldflags that are used on all devices
Move ldflags that are specified for all devices into
deviceGlobalLdflags, and add them to linker.go:
-Wl,-z,noexecstack
-Wl,-z,relro
-Wl,-z,now
-Wl,--build-id=md5
-Wl,--warn-shared-textrel
-Wl,--fatal-warnings
-Wl,--no-undefined-version

Bug: 68855788
Test: m checkbuild
Change-Id: I82561b4189287d7638006f9e298c5151f9930c5e
2017-11-03 22:28:03 -07:00
Steven Moreland
726652c007 Merge "Export test/benchmark factory symbols." am: 8eaca18c49 am: c09932274b
am: e7a2ee9c6e

Change-Id: I4a8e8cc49d379c5ed0a5fb29e44f9036073a21a6
2017-11-04 03:07:48 +00:00
Steven Moreland
e7a2ee9c6e Merge "Export test/benchmark factory symbols." am: 8eaca18c49
am: c09932274b

Change-Id: I7b4e6ed5f40a84f95e5b60800cd2e30971a53d12
2017-11-04 03:05:14 +00:00
Steven Moreland
c09932274b Merge "Export test/benchmark factory symbols."
am: 8eaca18c49

Change-Id: I2e09b8b7aaca318a99f6c183eb98584b68dbe35d
2017-11-04 03:02:44 +00:00
Treehugger Robot
8eaca18c49 Merge "Export test/benchmark factory symbols." 2017-11-04 02:59:00 +00:00
Jeff Gaston
93f0f37417 Use flag.Parse in sbox
Also removeTempDir -> !keepOutDir
Also shorten the help comment

Bug: 68336760
Test: rm out -rf && m -j
Test: sbox -c # and observe that the output does not have a stacktrace

Change-Id: I6fbb385132128ab1273c8398ff2425191049751e
2017-11-03 17:30:21 -07:00
Nan Zhang
3c807db06e Add default jar wrapper when wrapper property is not specified
Bug: b/68779881
Test: manually copied the jar-wrapper.sh to out/soong/host/linux-x86/framework
Change-Id: Idee1e7e64c6e3c89c89a8cd9c107a38533356b6c
2017-11-03 15:19:15 -07:00
Dan Albert
c9e5dadf39 Stop building MIPS ABIs for the NDK. am: f45c6934c8 am: f0500d0e61
am: 74df1578f5

Change-Id: I50c7a8993468d1bc242d9fac1e67e988fd2027da
2017-11-03 20:58:23 +00:00
Dan Albert
74df1578f5 Stop building MIPS ABIs for the NDK. am: f45c6934c8
am: f0500d0e61

Change-Id: Ib10d74e2b15637c37facafbdadf42f23778a0cff
2017-11-03 20:56:18 +00:00
Dan Albert
f0500d0e61 Stop building MIPS ABIs for the NDK.
am: f45c6934c8

Change-Id: Ib84c520c01cc962882fce2c69e14482534e4e690
2017-11-03 20:52:50 +00:00
Dan Willemsen
47e44a4c5c pom2mk: Add a flag to specify a specific version of artifacts
For repositories that contain multiple versions of the same artifact,
we'd only like to create makefiles for one of the versions of the
artifact.

Bug: 64723465
Test: cd prebuilts/maven_repo/android; pom2mk -use-version 25.3.1 com/android/support
Change-Id: I5bdbba8d2143a47610d56d679381eb01b3cf176d
2017-11-03 13:40:08 -07:00
Dan Albert
f45c6934c8 Stop building MIPS ABIs for the NDK.
Test: build/soong/scripts/build-ndk-prebuilts.sh
Bug: https://github.com/android-ndk/ndk/issues/272
Change-Id: Ia8d48b1ecef5e1a3b239e2817eeed5dbe43e52ef
2017-11-03 19:38:03 +00:00
Colin Cross
0e37bc78d4 Remove -Wl,--gc-sections from target flags
-Wl,--gc-sections is already added by library.go and binary.go for
anything that uses bionic.

Bug: 68855788
Test: m checkbuild
Change-Id: I229199045ef8595d69c07fcf1aa6bbdc0b753fe3
2017-11-03 11:34:45 -07:00
Colin Cross
133dbe7bb0 Consolidate cflags that are set on all devices
Move cflags that are set on all devices to deviceGlobalCflags:
-fno-canonical-system-headers
-ffunction-sections
-funwind-tables
-fstack-protector-strong
-Wa,--noexecstack
-D_FORTIFY_SOURCE=2
-Wstrict-aliasing=2
-Werror=format-security

Bug: 68855788
Test: m checkbuild
Change-Id: Iefec689fdd2749013d0cc003b3abec674a85fb74
2017-11-03 11:34:45 -07:00
Colin Cross
7278afc5a8 Consolidate global cflags
Move all the flags that are used everywhere (or should be used
everywhere) into cc/config/global.go:
-no-canonical-prefixes
-fno-exceptions
-Wno-multichar
-O2
-g
-fno-strict-aliasing

Also remove flags that are already in noOverrideGlobalCflags:
-Werror=pointer-to-int-cast
-Werror=int-to-pointer-cast

x86 and x86_64 were specifying -fstrict-aliasing, but that was
being overriden later by -fno-strict-aliasing, so remove it.
ARM devices still override -fno-strict-aliasing to -fstrict-aliasing
when using ARM (vs. Thumb) instruction set.

Bug: 68855788
Test: m checkbuild
Change-Id: Ia2b5891bdefb60f974ad92b4b84a8548c2dcc7dc
2017-11-03 11:34:45 -07:00
Pirama Arumuga Nainar
bdb17f068c Remove CFI-related WARs that seem no longer necessary
Bug: http://b/33678192

Clang has been updated past the revisions mentioned in the work arounds.
So these seem no longer necessary.

Test: Build

Change-Id: I08fee0db7c5785836a1ad0104688245435865cb7
2017-11-02 23:37:28 -07:00
Steven Moreland
87c9d7bb8f Export test/benchmark factory symbols.
Bug: 35570956
Test: manual
Change-Id: I3dc2d7fd8876a0a222d1fc3e0f6ba27ecc2f50e8
2017-11-02 21:38:58 -07:00
Steven Moreland
578fa4a9a3 Export cc library factories. am: f9e621603b am: 9fa7f9ecc1
am: d33cce05f0

Change-Id: I8265c86087d3f75036f34c503e561bd4d96cf154
2017-11-03 02:04:38 +00:00
Steven Moreland
d33cce05f0 Export cc library factories. am: f9e621603b
am: 9fa7f9ecc1

Change-Id: If86c497bf86b3872ab6a0cf29ecaca36e4fc1ab3
2017-11-03 01:52:36 +00:00
Steven Moreland
9fa7f9ecc1 Export cc library factories.
am: f9e621603b

Change-Id: I729f672a778ad8747c2a480618ccfd432faba203
2017-11-03 01:41:06 +00:00
Steven Moreland
f9e621603b Export cc library factories.
Previously not useful, they are required to use CreateModule
to create additional libraries.

Bug: 35570956
Test: manual :)

Change-Id: Ibb6b1c0d365512fce8969e1e6237ebbed0bc9cdc
2017-11-03 00:05:54 +00:00
Vishwath Mohan
777109063f Merge "Don't install both variants for host or non-make builds." am: 845da14a35 am: 511ff4330f
am: d9f2552053

Change-Id: I275ca2f82b09ae8f390c95d0b463b63a9d174c23
2017-11-02 17:50:09 +00:00
Vishwath Mohan
d9f2552053 Merge "Don't install both variants for host or non-make builds." am: 845da14a35
am: 511ff4330f

Change-Id: Ic29209ba194766307a994718d1cf7af03db98d4a
2017-11-02 17:47:06 +00:00
Vishwath Mohan
511ff4330f Merge "Don't install both variants for host or non-make builds."
am: 845da14a35

Change-Id: I63bf076b1e9cd2c071aac819bc2a6ed400db1365
2017-11-02 17:45:33 +00:00
Treehugger Robot
845da14a35 Merge "Don't install both variants for host or non-make builds." 2017-11-02 17:41:20 +00:00
Jayant Chowdhary
d55c644e96 Merge "Convert abi warnings to errors." am: 7a709dae7a am: 4845af3d41
am: e3811588b5

Change-Id: Ie07e7ac7582794c47f2ce665fe3dabecfe91578c
2017-11-02 16:58:02 +00:00
Jayant Chowdhary
e3811588b5 Merge "Convert abi warnings to errors." am: 7a709dae7a
am: 4845af3d41

Change-Id: Ifdda804c9eb8c4ab988b4e0c84b1d78a0faaf2b1
2017-11-02 16:55:33 +00:00
Jayant Chowdhary
4845af3d41 Merge "Convert abi warnings to errors."
am: 7a709dae7a

Change-Id: I9b65e025da4173619eaa97c0e6572288710227f0
2017-11-02 16:53:30 +00:00
Jayant Chowdhary
7a709dae7a Merge "Convert abi warnings to errors." 2017-11-02 16:44:56 +00:00
Vishwath Mohan
e21fe42662 Don't install both variants for host or non-make builds.
This CL ensures that only one of the two generated variants are
installed for non-make builds and for host binaries.

Bug: 30227045
Test: OUT_DIR=/tmp/ndk build/soong/scripts/build-ndk-prebuilts.sh
Change-Id: I7ca78af51ea6bd3ae1107a69331abd6ff68f2150
2017-11-02 03:03:50 -07:00
Jayant Chowdhary
a3bb1b3e3b Convert abi warnings to errors.
Convert abi warnings to errors by removing the -advice-only flag from
the invocation of header-abi-diff. This will only apply to branches with
reference abi dumps checked into prebuilts/abi-dumps/(v)ndk (since
abi-diffing will only be triggered on them.)

Also allow for:

1) Extensions.
2) Changes to types in exported headers, unreferenced by public symbols still
   trigger warnings.
3) Any removal of symbols appearing in a shared library's .dynsym table, but not
   in exported headers is still a warning.

Bug: 64267858

Test: make -j64 from ToT.

Change-Id: Iadeac8d060cb693d4310afb841dc48d91f38597d
2017-11-01 17:32:26 -07:00
Colin Cross
0996fe9b39 Merge "Revert "Revert "Make some common properties overridden when used in defaults modules""" am: d1dec3bd72 am: 985deafd4b
am: 5738640086

Change-Id: I8f23ebba852cfb7f8ebb1eea27d6040d31292873
2017-11-02 00:27:26 +00:00
Colin Cross
5738640086 Merge "Revert "Revert "Make some common properties overridden when used in defaults modules""" am: d1dec3bd72
am: 985deafd4b

Change-Id: I5f30fdf7b98bd807a289a549bf343d66d1a32d85
2017-11-02 00:22:32 +00:00
Colin Cross
517b85e9f2 Merge "Propagate PRODUCT_MINIMIZE_JAVA_DEBUG_INFO to soong and use it" am: 9117c879f3 am: a23e18fef5
am: fd079cb37c

Change-Id: I9b528a52ca56292c6b0740882a418742579dd274
2017-11-02 00:19:10 +00:00
Colin Cross
fd079cb37c Merge "Propagate PRODUCT_MINIMIZE_JAVA_DEBUG_INFO to soong and use it" am: 9117c879f3
am: a23e18fef5

Change-Id: I9453f2830c2b194fa2e6a7ee492b6062d359ec49
2017-11-02 00:15:19 +00:00