Chih-hung Hsieh
6f9312127c
Merge "Disable tidy checks in TidyGlobalNoChecks"
2022-06-10 18:01:08 +00:00
Yasin Kilicdere
aa02f8fc0b
Revert "Disallow -warnings-as-errors in tidy_flags" am: 5a8ce13c2a
am: a3cc2a6b11
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2122465
Change-Id: Iadf24ea22c108d6c4556ce6b9758c36d6f547ebb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-10 15:03:02 +00:00
Yasin Kilicdere
5a8ce13c2a
Revert "Disallow -warnings-as-errors in tidy_flags"
...
This reverts commit 2d481842b1
.
Reason for revert: b/235569235#comment4
Change-Id: I5c87b1d5a1bdf0bad7f436c397688fe3fc20d04e
2022-06-10 12:18:07 +00:00
Chih-Hung Hsieh
c650faa8e5
Disallow -warnings-as-errors in tidy_flags am: 2d481842b1
am: f3a8ef4231
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2080669
Change-Id: I918c00e10ed94af1fefdc292464534be7cfd5faf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-10 09:55:42 +00:00
Chih-Hung Hsieh
43b920e707
Disable tidy checks in TidyGlobalNoChecks
...
* Save repeated strings in TidyFlags of build.ninja rules.
* Some of these checks were disabled to upgrade clang-tidy.
They could later be moved to TidyDefaultGlobalChecks and
TidyExternalVendorChecks if not breaking the build.
Some projects can then enable those checks locally.
Test: WITH_TIDY=1 make; make tidy-soong_subset
Change-Id: I70e4218c929e3c88f766f2c68c56c51356110e72
2022-06-09 17:58:41 -07:00
Chih-Hung Hsieh
2d481842b1
Disallow -warnings-as-errors in tidy_flags
...
* Also remove the undocumented complicated
experiment to overwrite local warnings-as-errors.
Bug: 229801437
Test: WITH_TIDY=1 make; make tidy-soong_subset
Change-Id: I2fb32146b4685ab9f5198724c15c303f799b7a14
2022-06-09 11:12:10 -07:00
Colin Cross
cdcb680dbd
Use -fdebug-default-version=4 for assembly files
...
-fdebug-default-version=5 is causing $TMPDIR to end up in the dwarf
debug data, which causes the buildbot results to be nondeterministic.
Pass -fdebug-default-version=4 for assembly files as a workaround.
Bug: 235105792
Test: lunch aosp_arm-userdebug && m libbase && llvm-dwarfdump --debug-line out/target/product/generic/symbols/system/lib/libbase.so
Change-Id: Ife04e3c898bbb1291f71b8365fbca854cd2d2b66
2022-06-09 11:08:50 -07:00
Trevor Radcliffe
d456182dd1
Merge "Enable Mixed Builds for Prebuilt Library" am: 74e8df0741
am: d6b70adce7
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2101150
Change-Id: Ia64712d0ca085e856c569ac6d06e58299d54e34b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-08 14:53:08 +00:00
Trevor Radcliffe
74e8df0741
Merge "Enable Mixed Builds for Prebuilt Library"
2022-06-08 13:51:13 +00:00
Hsin-Yi Chen
4108552615
Merge "Remove unneeded logic from sourceAbiDiff" am: 6e9225d53c
am: 76e7546a6b
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2114875
Change-Id: I5768c30f4e80a65e0bb998c0700a7210c915e19d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-08 03:46:25 +00:00
Hsin-Yi Chen
6e9225d53c
Merge "Remove unneeded logic from sourceAbiDiff"
2022-06-08 02:12:58 +00:00
Yi Kong
455b84363a
Merge "Remove sampling profile support from pgo rule" am: 0e12680a2e
am: 8067d9c871
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2117277
Change-Id: If3ef3a3ae492057d6509e431e32cd9765d1663de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-07 21:56:21 +00:00
Chih-hung Hsieh
cdcb038d47
Merge "Shorten the -checks flag in clang-tidy rules" am: 7fd85c45f8
am: 6f807b422e
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2116278
Change-Id: I8e87c5fa1dee29dba6e999cd55ac40e79c7ea959
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-07 21:56:10 +00:00
Yi Kong
0e12680a2e
Merge "Remove sampling profile support from pgo rule"
2022-06-07 21:20:45 +00:00
Chih-hung Hsieh
7fd85c45f8
Merge "Shorten the -checks flag in clang-tidy rules"
2022-06-07 21:14:14 +00:00
Trevor Radcliffe
5d6fa4d857
Enable Mixed Builds for Prebuilt Library
...
This change provides support for mixed builds for
cc_prebuilt_library modules and allowlists some such modules.
Fixes: 225938765
Test: Unit tests, run mixed builds and verify correctness
Change-Id: I04396c79661df6b9a43907859e4f96d0191e8e1b
2022-06-07 20:36:53 +00:00
Yi Kong
fe841868c2
Remove sampling profile support from pgo rule
...
Sampling profiles should use afdo rule instead.
Test: presubmit
Bug: 218791486
Change-Id: I6073da27d184a779be0f6796f336e6ec051beceb
2022-06-07 15:23:08 +08:00
Treehugger Robot
59d37c8bb6
Merge "Remove AIDL modules from VndkMustUseVendorVariantList"
2022-06-07 01:00:06 +00:00
Elliott Hughes
b85366e699
Merge "Revert "Disable BTI for now."" am: ba4a566e2d
am: 0770744797
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2020301
Change-Id: I9483bcf63e54ae8df300a3bef750575ac90d5aa4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-06 21:14:43 +00:00
Elliott Hughes
ba4a566e2d
Merge "Revert "Disable BTI for now.""
2022-06-06 20:10:56 +00:00
Yu Liu
8d82ac58b4
Support cc code coverage for mixed build
...
Bug: 231322627
Test: Manual tests and unit tests
Change-Id: I786042af0d612192c54c3572f63a86a47174a242
2022-06-06 12:29:25 -07:00
Liz Kammer
d9b3cf60c2
Merge "Do not hardcode default/experimental c{pp}std" am: ace70d857e
am: 72627266b9
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2106991
Change-Id: Idc6f6c058d2d1b1e5cd930adb9be52a8a33397b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-06 14:21:07 +00:00
Liz Kammer
ace70d857e
Merge "Do not hardcode default/experimental c{pp}std"
2022-06-06 13:40:17 +00:00
Treehugger Robot
98306aa91c
Merge "Keep minimal abort when enabling integer overflow check" am: dcec8e067b
am: 48d7862515
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2114953
Change-Id: Idbbb36f82d3198126a939e015506d5aa4fbd95da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-06 10:18:47 +00:00
Treehugger Robot
dcec8e067b
Merge "Keep minimal abort when enabling integer overflow check"
2022-06-06 09:45:12 +00:00
Treehugger Robot
01346ff1a6
Merge "Use single clang-tidy build rule and clang-tidy.sh" am: b12ae4f2bd
am: 011e470e5e
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2110906
Change-Id: I52e5741db934b6166c3f6a9bb75bb0c6726b4bc5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-04 00:45:00 +00:00
Chih-Hung Hsieh
80e3e03aa9
Shorten the -checks flag in clang-tidy rules
...
* If a module defines tidy_checks with "-*",
pass only "-*" and checks after it to clang-tidy.
Test: make tidy-soong_subset
Change-Id: I2a4a6111f67b934bc29e4e4fe8596a8dce4e7031
2022-06-03 17:17:17 -07:00
Treehugger Robot
b12ae4f2bd
Merge "Use single clang-tidy build rule and clang-tidy.sh"
2022-06-04 00:06:26 +00:00
TreeHugger Robot
6f2ef6127c
Merge "Remove AIDL modules from VndkMustUseVendorVariantList" into tm-dev-plus-aosp
2022-06-03 22:10:15 +00:00
Colin Cross
4ec2bf1467
Merge "Revert "Use --dependency-file when linking elf files."" am: b914e7f8c6
am: c43e5ff7cc
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2115768
Change-Id: Ieed01217bf395e4951ff571a69b346327d584168
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-03 17:40:20 +00:00
Colin Cross
b914e7f8c6
Merge "Revert "Use --dependency-file when linking elf files.""
2022-06-03 16:53:54 +00:00
Jooyung Han
87f73e527c
Remove AIDL modules from VndkMustUseVendorVariantList
...
Vendor variants of AIDL-gen CC modules are by default different from
core variants. So instead of adding them manually to the list, AIDL
builder can mark them as MustUseVendorVariant.
Bug: 233616647
Test: m
Merged-In: Ifca0eb64d60ecb49d72cd0347336b69fb332c58c
Change-Id: Ifca0eb64d60ecb49d72cd0347336b69fb332c58c
(cherry picked from commit b8d3df82ac
)
2022-06-03 04:54:52 +00:00
Jooyung Han
43b2c668da
Remove AIDL modules from VndkMustUseVendorVariantList
...
Vendor variants of AIDL-gen CC modules are by default different from
core variants. So instead of adding them manually to the list, AIDL
builder can mark them as MustUseVendorVariant.
Bug: 233616647
Test: m
Merged-In: Ifca0eb64d60ecb49d72cd0347336b69fb332c58c
Change-Id: Ifca0eb64d60ecb49d72cd0347336b69fb332c58c
2022-06-03 04:46:59 +00:00
Colin Cross
32320e89fd
Revert "Use --dependency-file when linking elf files."
...
This reverts commit 97d87760b4
.
Reason for revert: b/234772469
Bug: 137961579
Bug: 234772469
Change-Id: I478f5a2696e87144d0123e8872c9f8ac1d5f24b0
2022-06-02 23:02:01 +00:00
Hang Lu
34448f2430
Keep minimal abort when enabling integer overflow check
...
Cflag "-fsanitize-trap=all" will override "-fno-sanitize-trap=integer" if "-fsanitize-trap=all" is placed behind. Change the order to make minimal abort work, which will output the abort message to give user a better prompt.
Bug: 233840743
Test: "objdump -dS {CFI enabled so}" to check the instrumented abort instruction
Change-Id: Id85fa8ece3e13d1b21b4fdbf5f4b5124011890ca
2022-06-02 20:47:30 +08:00
Hsin-Yi Chen
dccddb6036
Remove unneeded logic from sourceAbiDiff
...
- The script creating reference dumps does not need --llndk. It can
determine the library types automatically.
- NDK passes the ABI checks with -consider-opaque-types-different.
- All libraries checked by the ABI tools have exported headers and don't
need -advice-only.
Bug: 232891473
Test: development/vndk/tools/header-checker/utils/create_reference_dumps.py \
&& make
Change-Id: Ia418022d6d0b46bfabefaa296fa81e80291fde32
2022-06-02 18:49:26 +08:00
Treehugger Robot
5d069fb876
Merge "Add diff_flags as a header_abi_checker property"
2022-06-02 04:14:57 +00:00
Chih-Hung Hsieh
30ab2f059f
Use single clang-tidy build rule and clang-tidy.sh
...
* The old jobs of two build rules are now combined into
a new clang-tidy.sh wrapper.
The clang-tidy build rule now calls clang-tidy.sh.
Bug: 234406661
Test: WITH_TIDY=1 make; make tidy-soong_subset
Change-Id: I91961edf96e9a546f0c3088715a6f2ca8796a21b
2022-05-31 18:46:39 -07:00
Treehugger Robot
5a3b1c792c
Merge "Remove -sha256 flag when calling bssl_inject_hash." am: ced67ded0b
am: 7e786306df
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2101112
Change-Id: Ied93aad59538ecae30b560265dbf63006f0e5e76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-31 17:23:26 +00:00
Treehugger Robot
ced67ded0b
Merge "Remove -sha256 flag when calling bssl_inject_hash."
2022-05-31 16:53:06 +00:00
Liz Kammer
a5a29de677
Do not hardcode default/experimental c{pp}std
...
Prevent bugs like b/232866078 by using the same values across Bazel and
Soong
Test: bp2build.sh
Change-Id: If257f9f5f8e8a70bbf3a8cf5479758c703c25c3f
2022-05-27 09:38:03 -04:00
Hsin-Yi Chen
6ad1e4b5ea
Add diff_flags as a header_abi_checker property
...
The property allows developers to add extra flags to header-abi-diff for
specific libraries.
Bug: 232891473
Test: m libbinder.vendor
Change-Id: I203af73c784dfc7738bb64f57b224c08d5c595ce
Merged-In: I203af73c784dfc7738bb64f57b224c08d5c595ce
(cherry picked from commit 4f992b663f
)
2022-05-26 15:12:37 +08:00
Hsin-Yi Chen
ab255ae347
Merge "Add diff_flags as a header_abi_checker property" into tm-dev am: 39a9db3bae
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/soong/+/18482834
Change-Id: I6f53043eead9258ecc9903a3d779ed04df60aef2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-26 05:24:08 +00:00
Hsin-Yi Chen
39a9db3bae
Merge "Add diff_flags as a header_abi_checker property" into tm-dev
2022-05-26 04:21:54 +00:00
Trevor Radcliffe
2bb24935e4
Merge "Generate genlex rules from bp2build for cc targets" am: 5731d0fffd
am: c68fbc38e7
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2092784
Change-Id: I91cba2b4927db6e1284efcf82161f81f4216bebb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 20:32:59 +00:00
Trevor Radcliffe
5731d0fffd
Merge "Generate genlex rules from bp2build for cc targets"
2022-05-25 19:38:15 +00:00
Yi Kong
6faa9b759a
Merge "Enable string-compare warning" am: f13a66adfd
am: e99fbffa25
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2098017
Change-Id: I615039bbe1d8ba084bda367b836184b4c6606475
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 08:02:30 +00:00
Yi Kong
f13a66adfd
Merge "Enable string-compare warning"
2022-05-25 07:02:34 +00:00
Muhammad Haseeb Ahmad
35ca6bc67f
Merge "Make IsSanitizerEnabledForJni return false" am: 53a129db89
am: e353655540
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2105764
Change-Id: Icb9a49ce6817fe2f7fa6a6d35b6b2345cd07035c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 06:59:42 +00:00
Muhammad Haseeb Ahmad
e6567fe56b
Make IsSanitizerEnabledForJni return false
...
Change-Id: I5e1722bc32b63649fc9973d11e9fd5bdea72ddbe
Test: m
2022-05-25 00:13:08 +00:00