Commit Graph

8199 Commits

Author SHA1 Message Date
Treehugger Robot
de232dbed2 Merge "Generate tidy-* rules unless tidy is disabled" 2022-01-13 03:46:37 +00:00
Treehugger Robot
ecb720b946 Merge "[coverage] Override -Wframe-larger-than" am: 757feca3ed am: 1d8479e882 am: 988f0a87a6 am: d96af8213a
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1947487

Change-Id: I762b7956c60841aabe926118e176c9d628acd8cb
2022-01-13 01:45:51 +00:00
Chih-Hung Hsieh
7540a78a35 Generate tidy-* rules unless tidy is disabled
* make tidy-soong_subset, or make tidy-<any_directory>,
  should trigger the same clang-tidy compilations
  with or without global WITH_TIDY=1.
* Normal make should not trigger clang-tidy compilations
  unless global WITH_TIDY=1 or a module has set tidy:true.

Bug: 213918926
Test: NINJA_ARGS="-n" make tidy-soong_subset
Test: NINJA_ARGS="-n" make <some-library>
Change-Id: Iafffd3894abe137c9584c2c01830898422f9a677
2022-01-12 16:48:40 -08:00
Pirama Arumuga Nainar
e6840726bd [coverage] Override -Wframe-larger-than
Bug: http://b/214221000
Bug: http://b/194128476

Adding `-mllvm -runtime-counter-relocation` for continuous coverage has
caused -Wframe-larger-than warnings when linking libart.  These warnings
need not be enforced on coverage builds, so override the flag.

Test: NATIVE_COVERAGE_PATHS=art CLANG_COVERAGE=true m libart;
      also go/abtd on failing target.
Change-Id: I8f5ac725ff5c674e6dd0831136d3d8b2e42b0428
2022-01-12 11:52:26 -08:00
Liz Kammer
28cdcd69c2 Merge "Revert "Revert "bp2build: convert host & prebuilt header libraries""" am: e844132b85 am: 86151370ef am: d490d54259 am: 4e491af625
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1944329

Change-Id: Ib4eef6beb896c9586a0fdf9a3d45179447fbb553
2022-01-12 14:18:03 +00:00
Liz Kammer
e844132b85 Merge "Revert "Revert "bp2build: convert host & prebuilt header libraries""" 2022-01-12 13:23:16 +00:00
Jingwen Chen
01acb879eb Merge "Revert "bp2build: convert host & prebuilt header libraries"" am: ed4900f9d9 am: 4c909dcd5e am: 446f85be40 am: a7cf23531e
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1944703

Change-Id: I99d3a8f4dfeb21d115f64c75fca9359ffa1d28fa
2022-01-11 16:06:00 +00:00
Liz Kammer
3d3b35c94e Revert "Revert "bp2build: convert host & prebuilt header libraries""
This reverts commit 105deedfc7.

Reason for revert: Revert with forward fix

Change-Id: Ib0b6f6b1cbb011b4c5f2133e1cc15ec76ff29253
2022-01-11 16:02:50 +00:00
Jingwen Chen
ed4900f9d9 Merge "Revert "bp2build: convert host & prebuilt header libraries"" 2022-01-11 14:58:56 +00:00
Jingwen Chen
105deedfc7 Revert "bp2build: convert host & prebuilt header libraries"
This reverts commit d8a72d7dc9.

Reason for revert: root cause for b/214013899

Change-Id: If769708408c419c2fd3d9484fbf40202b7276299
2022-01-11 12:51:27 +00:00
Pirama Arumuga Nainar
2549ed613c Merge "Enable memory-mapped coverage instrumentation" am: 6609484961 am: 74eb07ae42 am: b80d71f553 am: 351126907c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1729633

Change-Id: I988a26c1b70ec893a3a0a8ed1bb6bcbe7ed23b75
2022-01-10 23:51:57 +00:00
Pirama Arumuga Nainar
6609484961 Merge "Enable memory-mapped coverage instrumentation" 2022-01-10 22:36:57 +00:00
Treehugger Robot
8846763efa Merge "bp2build: convert host & prebuilt header libraries" am: 77d93ba871 am: 012bdc1ff6 am: c3ec8319e4 am: 663d3cb446
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1927620

Change-Id: I6b0d87debcbfeddf8cff393b75d61823023f9e27
2022-01-08 02:20:10 +00:00
Treehugger Robot
77d93ba871 Merge "bp2build: convert host & prebuilt header libraries" 2022-01-08 00:55:32 +00:00
Chih-hung Hsieh
e58e8665b5 Merge "Switch to clang-r437112b" am: 5bb16c37d6 am: b74e1052c1 am: 3fd35bad56 am: 75b318d2fa
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1927344

Change-Id: I0cefb9ea44483e3cbd6acde27a5088d2a55dc5ab
2022-01-05 22:56:06 +00:00
Chih-hung Hsieh
5bb16c37d6 Merge "Switch to clang-r437112b" 2022-01-05 21:52:27 +00:00
TreeHugger Robot
688bac35f0 Merge "Add sensors AIDL interface" 2022-01-05 17:51:49 +00:00
Liz Kammer
ddf7306678 Merge "bp2build: Remove duplicate system shared libs" am: f673a60013 am: a824dca823 am: 54c67140bc am: dfc65369ce
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1922863

Change-Id: Ic739a7247bc5a1f0efc5b2b31821222c1039db29
2022-01-05 14:52:35 +00:00
Liz Kammer
f673a60013 Merge "bp2build: Remove duplicate system shared libs" 2022-01-05 13:42:54 +00:00
Chih-Hung Hsieh
66e8f72579 Switch to clang-r437112b
Bug: 201432564
Test: make
Change-Id: Iae5eb34b924c9e3707158d17761cf732518462d4
2021-12-28 11:16:30 -08:00
Yi Kong
2cb865b8f5 Merge "Introduce afdo" am: 37d0a5790a am: bd0d787fec am: d788f19592 am: a093bdbd5b
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1917257

Change-Id: I0acecac9a948d4acf92da111cff8cde8977dd66f
2021-12-23 06:10:50 +00:00
Yi Kong
37d0a5790a Merge "Introduce afdo" 2021-12-23 04:53:29 +00:00
Evgenii Stepanov
171454d569 Merge "Revert "Disable ubsan diagnostics under HWASan."" am: d30fcb15a9 am: 3eab590303 am: aca699e608 am: 44f92fdda8
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1931386

Change-Id: Ib2de9428b0dd177e0b306f3016b0673d07e48062
2021-12-22 23:38:09 +00:00
Evgenii Stepanov
d30fcb15a9 Merge "Revert "Disable ubsan diagnostics under HWASan."" 2021-12-22 22:29:43 +00:00
Liz Kammer
d8a72d7dc9 bp2build: convert host & prebuilt header libraries
Test: bp2build.sh
Change-Id: If8165eac7c17c4eef3686067257aa792121db59d
2021-12-22 16:34:27 -05:00
Liz Kammer
5430953c82 bp2build: Remove duplicate system shared libs
If a system shared lib is specified in shared_libs, this results in
duplicate values appearing, causing a failure in Bazel. This change
removes any system shared libraries that appear in shared libraries from
bionic OS axes where system_shared_libraries takes the default value.

Test: go soong tests
Test: temporarily allowlist directory with this issue, no longer hits
      duplicate library failure.
Change-Id: I9dce570b73c24973f695b815bce8d50f7259798d
2021-12-22 15:53:13 -05:00
Christopher Parsons
f797682282 Merge "Handle the 'enabled' property in bp2build" am: 948e851b83 am: fdb30910fc am: e40c2f5076 am: 5f81eb4dd6
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1917398

Change-Id: Id21d61970bc1a6bf78d19dd7ddee4634b255589d
2021-12-22 16:59:24 +00:00
Christopher Parsons
948e851b83 Merge "Handle the 'enabled' property in bp2build" 2021-12-22 15:50:10 +00:00
Evgenii Stepanov
4f41536076 Revert "Disable ubsan diagnostics under HWASan."
The original problem has been fixed in LLVM:
https://reviews.llvm.org/rG78f7e6d8d7956cb96d0fa0fd606192ca0218eee1

Bug: 191808836
Bug: 209991446
Test: m net_test_btm_iso with SANITIZE_TARGET=hwaddress

This reverts commit b15a564869.

Change-Id: Ie99a9a204e0a3f7c3ddf3efd74ac7f19db90215a
2021-12-21 16:31:31 -08:00
Treehugger Robot
531e610d18 Merge "Add -std user flags to cc test to ensure order" am: fac51eb8fd am: 215682ac05 am: 376070fbc3 am: 9bbd5746b2
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1925818

Change-Id: I792f7af6a876938f8fe998186908c2012d93a144
2021-12-21 23:14:11 +00:00
Treehugger Robot
fac51eb8fd Merge "Add -std user flags to cc test to ensure order" 2021-12-21 21:57:42 +00:00
Chris Parsons
58852a05f3 Handle the 'enabled' property in bp2build
Also fix some bugs pertaining to configurable attribute handling of bool
attributes and label sttributes, so that they may support values across
multiple different axes at the same time.

Test: unit tests for bp2build
Test: mixed_droid

Change-Id: I411efcfddf02d55dbc0775962068a11348a8bb2c
2021-12-21 16:37:32 -05:00
Liz Kammer
0436c6a2e9 bp2build remove "-std" from cflags am: cac7f690eb am: 547bdc5207 am: 7b901cb0fb am: 091e30666e
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1927501

Change-Id: I169b195e9b38333a9184d9df0510510830032277
2021-12-21 19:40:29 +00:00
Liz Kammer
cac7f690eb bp2build remove "-std" from cflags
Soong overrides "-std" flags when provided via cppflags or conlyflags;
however, any user-provided "-std=" cflag will be overridden by Soong's
std flag handling.

For Bazel, we _always_ allow user to override via user provided flags.
To prevent conflicts, we remove the silently ignored values from
Android.bp files in the bp2build conversion.

Test: build/bazel/ci/bp2build.sh
Test: build/bazel/ci/mixed_droid.sh
Change-Id: I4c33b2ae593a7ff3ff8e3ad15ef3461354fc0c83
2021-12-21 11:49:01 -05:00
Yi Kong
eb8efc902d Introduce afdo
A new configuration rule for sampling PGO. This differs from the
original pgo.go rule in the following ways:
 * Automatic propagation to static dependencies
 * Simpler configuration (just put `afdo: true` to optimsation targets)

http://go/android-afdo

Test: build
Bug: 79161490
Change-Id: Ie194824cd523bca19e10ced41d2078fc598f13b3
2021-12-21 16:09:23 +08:00
Treehugger Robot
dbd3553d83 Merge "Remove InstallBypassMake and ToMakePath" am: f1228f570a am: a9f335cf5a am: fd865c6688 am: 8ef2179a6e
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1889722

Change-Id: If49c894804c5ca0dfd197ca848ff1c9ac79556f4
2021-12-17 07:36:53 +00:00
Treehugger Robot
f1228f570a Merge "Remove InstallBypassMake and ToMakePath" 2021-12-17 06:15:16 +00:00
Yi Kong
126fc68a92 Merge "Turn on -Wstring-concatenation" am: 53fc7705ec am: 28a933cf8c am: 0b7fccbb5f am: 64c00f2209
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1922284

Change-Id: I5e7038f84ac6da2144ce097095066557514b5145
2021-12-17 05:36:55 +00:00
Yi Kong
53fc7705ec Merge "Turn on -Wstring-concatenation" 2021-12-17 04:05:37 +00:00
Treehugger Robot
b511584da9 Merge "Make all defaults modules bazelable" am: 3eed7f9a8b am: 3434f3734f am: 1cff15e0b1 am: cec672ffa9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1924162

Change-Id: I679379193a8e969fe90045de82aa8fd2593f0b83
2021-12-16 21:02:35 +00:00
Treehugger Robot
572334fe5b Merge "Add noOverrideExternalGlobalCflags support to Soong" am: cde46d7d98 am: 1f337626d2 am: 4e4352352c am: 3e28e343cd
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1924200

Change-Id: I2dde5ba90dcf67897b87f5d68c7bd4780570fd8a
2021-12-16 21:01:56 +00:00
Liz Kammer
9dc6577d55 Add -std user flags to cc test to ensure order
Test: go test soong tests
Change-Id: Iff2b82f59e138089d1c1726d9b51e040b00340ba
2021-12-16 11:38:50 -05:00
Treehugger Robot
3eed7f9a8b Merge "Make all defaults modules bazelable" 2021-12-16 01:36:47 +00:00
Treehugger Robot
cde46d7d98 Merge "Add noOverrideExternalGlobalCflags support to Soong" 2021-12-16 00:26:57 +00:00
Colin Cross
c68db4b305 Remove InstallBypassMake and ToMakePath
InstallBypassMake and ToMakePath are obsolete, remove them.

Bug: 204136549
Test: m checkbuild
Change-Id: Ie5a6f7254b3d317ed6039e114ed6aec35e1ce273
2021-12-15 15:22:53 -08:00
Liz Kammer
450acfdd42 Merge "bp2build: Expand check if filegroup contains proto" am: b849d4a6d5 am: ccdd5a8de4 am: 774e8930d5 am: 6fb30b62e0
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1916846

Change-Id: I4e063cbb5e993d661bdcf40e464aa36a9d47fc44
2021-12-15 21:42:43 +00:00
Liz Kammer
416201d081 Make all defaults modules bazelable
Since these are not being converted directly, this has two primary
impacts:
* defaults modules will no longer appear as unconverted deps.
* defaults modules do not have to be marked individually, which should
  allow all defaults-based soong-config-modules to just convert as
  necessary.

Test: bp2build.sh
Change-Id: I44c99d5a51d1887a95c17dfdf956f91af671b2ea
2021-12-15 13:18:42 -05:00
Liz Kammer
aabfb5dc47 bp2build: Expand check if filegroup contains proto
Previously we looked for proto as suffix, however, some filegroups use
"<foo>-proto-srcs" or "<bar>-proto-sources", instead we look for proto
as a distinct word in a filegroup name.

Test: go test soong tests
Change-Id: Icf916a84304a02617efff9768e5b82d5ffe658bd
2021-12-15 13:07:58 -05:00
Liz Kammer
487610a623 Merge "bp2build: do not convert prebuilt cc binaries" am: b29852a3da am: cf754196a8 am: fe0a45aa7b am: 59a2ef5a68
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1922861

Change-Id: I8da0d3964cd80e301529fc5e0631b65e9b2e20f0
2021-12-15 16:11:51 +00:00
Liz Kammer
b29852a3da Merge "bp2build: do not convert prebuilt cc binaries" 2021-12-15 15:07:58 +00:00