StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
66,115 Commits 1 Branch 0 Tags
8fe37e44b51bf69674b11bff147f135665338f03
Commit Graph

8199 Commits

Author SHA1 Message Date
Liz Kammer
35687bc77a Split local/absolute include into attributes 
Previously these were expanded into copts, requiring making all includes
absolute and duplicating includes to account for potentially generated
files. We now can handle both of these properly on the Bazel side, so
let's clean up build files a bit.

Test: bp2build.sh
Change-Id: I6c6160738cd6c269408c6c7a37010654d84f3c9d
 2021-09-13 12:49:42 +00:00
Liz Kammer
dd34331163 Merge "bp2build: Split export_{includes,system_includes}" am: 15c90f5fe1 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1822559

Change-Id: I35e5ac06bfaefeaf437af196249906dd517d7a5a
 2021-09-13 12:43:23 +00:00
Liz Kammer
15c90f5fe1 Merge "bp2build: Split export_{includes,system_includes}" 2021-09-13 12:22:19 +00:00
Yi Kong
a1ebc2d072 Remove unused-but-set-{variable,parameter} from ClangUnknownCflags 
These warnings are now implemented by Clang.

Change-Id: I78d04216da0ca3d1db616c7b658ca6075b20e7f6
Test: presubmit
Bug: 197230471
 2021-09-13 06:25:41 +00:00
Treehugger Robot
8cdafe5044 Merge "Don't use bugprone-easily-swappable-parameters for global tidy builds either" am: 07e7294a75 am: 0e7f8e9919 am: f4e2c69c69 am: 817164c6bf am: 1ee8022268 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1824475

Change-Id: I5051788c3e2352b42b89cf20b2bd9a81527d4713
 2021-09-11 11:29:51 +00:00
Treehugger Robot
0e7f8e9919 Merge "Don't use bugprone-easily-swappable-parameters for global tidy builds either" am: 07e7294a75 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1824475

Change-Id: I6f7e0578f6e934dbc89a5d06f532b7111d1c8d55
 2021-09-11 10:36:47 +00:00
Treehugger Robot
07e7294a75 Merge "Don't use bugprone-easily-swappable-parameters for global tidy builds either" 2021-09-11 10:20:40 +00:00
Stephen Hines
4b721450c8 Don't use bugprone-easily-swappable-parameters for global tidy builds either 
We turned this off in local tidy flags, but didn't disable it on global
tidy builds. Let's remove this for now, since the upkeep cost is large
on it, and it also is currently crashing in some cases.

Bug: http://b/199534745
Bug: http://b/194865868
Test: WITH_TIDY=1 m
Change-Id: Ife39ab4949c5baf825efff66326b276c6a2a59f4
 2021-09-11 01:14:36 -07:00
Chih-hung Hsieh
c5a3641c5b Merge "Pass TIDY_TIMEOUT to clang-tidy" am: aaa4c07f21 am: cd6242cc74 am: fe2db3089a am: 386e9edb60 am: 7146166ba7 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1823596

Change-Id: Ia8d3beac514a82b9dce1883ebbc5d128b1fe8806
 2021-09-10 20:50:26 +00:00
Chih-hung Hsieh
cd6242cc74 Merge "Pass TIDY_TIMEOUT to clang-tidy" am: aaa4c07f21 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1823596

Change-Id: I324448b5c311783119c263bc2c3ecc19c553974a
 2021-09-10 19:48:23 +00:00
Chih-hung Hsieh
aaa4c07f21 Merge "Pass TIDY_TIMEOUT to clang-tidy" 2021-09-10 19:36:29 +00:00
Yi Kong
8c5c1f5361 Merge "Switch to clang r433403" am: 6afa749d1d am: 7d927b62bf am: 562a90804a am: dd6c4afde0 am: aa10aac191 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1814448

Change-Id: I2ac75222eb3a1b75154e973cd724b9ce0bad427b
 2021-09-10 05:56:13 +00:00
Yi Kong
7d927b62bf Merge "Switch to clang r433403" am: 6afa749d1d 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1814448

Change-Id: I19285347bc70349ce02de3d8b2b6793a4d56fa75
 2021-09-10 04:39:04 +00:00
Yi Kong
6afa749d1d Merge "Switch to clang r433403" 2021-09-10 04:21:54 +00:00
Yi Kong
e82732916a Switch to clang r433403 
Bug: 197230471
Test: presubmit
Change-Id: I374a66deb785bae99953ea23c67f873f33c2081b
 2021-09-10 04:20:49 +00:00
Chih-Hung Hsieh
95dfbce28b Pass TIDY_TIMEOUT to clang-tidy 
* Tested with a clang-tidy wrapper that dumps TIDY_TIMEOUT.

Test: make WITH_TIDY=1 TIDY_TIMEOUT=42
Bug: 199451930
Change-Id: I86580225bad7487da786db2ba62c09bd99d70c67
 2021-09-09 19:58:41 -07:00
Liz Kammer
5fad501aeb bp2build: Split export_{includes,system_includes} 
The specification of exporting includes vs system includes has an impact
on inclusion sort order. Conflating the two caused some symbols to not
be resolved correctly.

Bug: 198403271
Test: build/bazel/ci/bp2build.sh
Test: USE_BAZEL_ANALYSIS=1 m libbacktrace_no_dex succeeds with libc++_*
      modules removed from mixed build denylist (would fail otherwise)
Change-Id: I08aff253d8962dc678ed10214b1c171330e0fe19
 2021-09-09 15:59:05 -04:00
Treehugger Robot
1e9853f396 Merge "Cleanup unused code for bp2build conversion." am: 4011ebb12d am: 16010fe5cd am: 3417e33dd2 am: 28c22ff43f am: 418ea381c4 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1819237

Change-Id: I62a4707b849b8ae190f91884cab3261a350c2634
 2021-09-09 14:20:51 +00:00
Treehugger Robot
16010fe5cd Merge "Cleanup unused code for bp2build conversion." am: 4011ebb12d 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1819237

Change-Id: I41d4bdf23a5d17c74e1897a6d42a0b3a22fd865e
 2021-09-09 13:17:31 +00:00
Treehugger Robot
4011ebb12d Merge "Cleanup unused code for bp2build conversion." 2021-09-09 13:12:04 +00:00
Sarah Chin
d2432e668d Merge "Add Radio AIDL to VNDK variant list" 2021-09-09 05:21:43 +00:00
Treehugger Robot
244784ccb1 Merge "Add tidy-soong, tidy-dir-path, module-tidy targets" am: f49df213f8 am: 550ec33096 am: 40260efb9f am: 8c3e43ce7c am: 4cceb34917 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1820636

Change-Id: I61feaac42cb64e3a86be34dc25c35ac96fc47027
 2021-09-09 04:38:11 +00:00
Sarah Chin
40eb29e39b Merge "Add Radio AIDL to VNDK variant list" into stage-aosp-master 2021-09-09 04:25:24 +00:00
Treehugger Robot
550ec33096 Merge "Add tidy-soong, tidy-dir-path, module-tidy targets" am: f49df213f8 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1820636

Change-Id: I03c50ff5676e52fd296c58aeebc9866601040e08
 2021-09-09 03:38:56 +00:00
Treehugger Robot
f49df213f8 Merge "Add tidy-soong, tidy-dir-path, module-tidy targets" 2021-09-09 03:22:59 +00:00
Chih-hung Hsieh
fa857ac706 Merge "Use tidyExternalVendor for external/googletest" am: 095aac0614 am: 5ee3f91dcd am: 9f0ac02b0d am: 4916f910b3 am: cd0fcf594e 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1819240

Change-Id: Ifc6708c2df2e2b48d1b0af12b9c497e30181d562
 2021-09-08 19:55:26 +00:00
Sarah Chin
2b9ad1c484 Add Radio AIDL to VNDK variant list 
Test: build
Bug: 198331182
Change-Id: I922961b8311d024ebbf3f3339dfdb41c72ee9dd9
Merged-In: I922961b8311d024ebbf3f3339dfdb41c72ee9dd9
 2021-09-08 19:08:44 +00:00
Chih-hung Hsieh
5ee3f91dcd Merge "Use tidyExternalVendor for external/googletest" am: 095aac0614 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1819240

Change-Id: I8b6abe23e57168ff4e01c6f78009edafd8e075ad
 2021-09-08 18:50:44 +00:00
Chih-hung Hsieh
095aac0614 Merge "Use tidyExternalVendor for external/googletest" 2021-09-08 18:29:05 +00:00
Sarah Chin
b03e96874e Add Radio AIDL to VNDK variant list 
Test: build
Bug: 198331182
Change-Id: I922961b8311d024ebbf3f3339dfdb41c72ee9dd9
Merged-In: I922961b8311d024ebbf3f3339dfdb41c72ee9dd9
 2021-09-08 17:31:38 +00:00
Chih-Hung Hsieh
d0f82fee44 Add tidy-soong, tidy-dir-path, module-tidy targets 
* When WITH_TIDY=1, these targets allow quick check of C/C++
  source code with clang-tidy, without building C/C++ binaries.
* For each module with tidy rules, add a module-tidy target, e.g.,
  libart-tidy, libartd-tidy, bionic-benchmarks-tidy, libnativehelper-tidy, etc.
* Add a tidy-soong phony target that depends on all module-tidy targets.
* For each directory X/Y add a tidy-X-Y phony target that depends
  on all *-tidy targets in X/Y and tidy-X-Y-Z for all X/Y/Z directories,
  e.g., tidy-bionic, tidy-bionic-benchmarks, tidy-libnativehelper, etc.
* Only soong modules are collected for now.
  Tidy rules in .mk files will be collected later.
* Some comment lines reformatted by gofmt.

Test: WITH_TIDY=1 make <some_module>-tidy tidy-<some_directory>
Test: WITH_TIDY=1 make tidy-soong
Bug: 199169329
Change-Id: I45aef3875f70288a8e070761e5f083dbbdfa6e94
 2021-09-07 14:56:44 -07:00
Chih-hung Hsieh
8cfc751fe0 Merge "Add config/tidy.go to per-file owners." am: 63d1a0ab94 am: 1b0a86b751 am: aa1b4f7746 am: a1d53c0d76 am: ca99a72de9 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1819238

Change-Id: I364fcdfeafd08bfac029386b2b211bac02cb51c3
 2021-09-07 21:34:03 +00:00
Chih-hung Hsieh
1b0a86b751 Merge "Add config/tidy.go to per-file owners." am: 63d1a0ab94 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1819238

Change-Id: I1d05b0704a79e02df04a7706d77ccfde19609942
 2021-09-07 20:38:42 +00:00
Chih-hung Hsieh
63d1a0ab94 Merge "Add config/tidy.go to per-file owners." 2021-09-07 20:18:05 +00:00
Linzhao Ye
e2f668abde Merge "Add android.hardware.wifi.hostapd-V1-ndk_platform to VNDK list." am: a0dc31d4a2 am: d11722bb82 am: e9aa51a012 am: 883b5fab18 am: 47d82ec5b0 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1796168

Change-Id: I84fea5b1113f475081806f4587e63bd47129ed78
 2021-09-07 18:50:54 +00:00
Linzhao Ye
d11722bb82 Merge "Add android.hardware.wifi.hostapd-V1-ndk_platform to VNDK list." am: a0dc31d4a2 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1796168

Change-Id: I3676b21992a9c54e8286c970d639c1e31ce748eb
 2021-09-07 17:35:53 +00:00
Chih-Hung Hsieh
f92c7154cd Use tidyExternalVendor for external/googletest 
* Do not run expensive clang-analyzer-* checks with googletest/*,
  which should be checked upstream.

Test: make WITH_TIDY=1 CLANG_ANALYZER_CHECKS=1
Bug: 198098397
Change-Id: Ic801ffa802b42d4d55ae89553073c926f9eaa351
 2021-09-07 10:22:56 -07:00
Chih-Hung Hsieh
04a5dabf9a Add config/tidy.go to per-file owners. 
Test: make
Change-Id: I01b7bcd2cb5a766baf7ea8015996b4a782395875
 2021-09-07 10:20:49 -07:00
Liz Kammer
7cbf7738f2 Cleanup unused code for bp2build conversion. 
This code to support bp2build-specific modules is no longer necessary as
we do not create bp2build modules after https://r.android.com/1792714

Test: build/bazel/ci/bp2build.sh
Change-Id: I20d3c42f7e3516554cfb537fef05ba40d222dbeb
 2021-09-07 13:19:21 -04:00
Linzhao Ye
a0dc31d4a2 Merge "Add android.hardware.wifi.hostapd-V1-ndk_platform to VNDK list." 2021-09-07 17:15:33 +00:00
Sarah Chin
e0c318383d Merge "Add Radio AIDL to VNDK variant list" 2021-09-03 23:47:39 +00:00
Lukács T. Berki
3354538ee2 Merge "Do not modules in files called "Blueprints"." am: 399dbe0699 am: 69b9caf11a am: 2db83e8af5 am: b53f7dc9e5 am: 5be8231296 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1817961

Change-Id: I49b362f0385c646197fd0c99315fc1c69856d2e3
 2021-09-03 19:52:57 +00:00
Lukács T. Berki
69b9caf11a Merge "Do not modules in files called "Blueprints"." am: 399dbe0699 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1817961

Change-Id: I754c8b72284ac8a22851f58ad1d03c8e2a90ec3d
 2021-09-03 18:38:54 +00:00
Lukács T. Berki
399dbe0699 Merge "Do not modules in files called "Blueprints"." 2021-09-03 18:20:39 +00:00
Matthias Maennich
fd0a183660 ndk_library: separate abidw and abitidy into separate rules am: c2346f1c21 am: 276f996713 am: 0a8865b02a am: 9fc209706b am: 57b0ab0c16 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1818334

Change-Id: I6948e9cbd6d1e77e38ec5b4fbd9948d32cc8d77a
 2021-09-03 13:58:14 +00:00
Matthias Maennich
276f996713 ndk_library: separate abidw and abitidy into separate rules am: c2346f1c21 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1818334

Change-Id: Iee14342d6f062b7ed84305e038505c025fbbc849
 2021-09-03 13:03:42 +00:00
Sarah Chin
c10d5da3d4 Add Radio AIDL to VNDK variant list 
Test: build
Bug: 198331182
Change-Id: I922961b8311d024ebbf3f3339dfdb41c72ee9dd9
 2021-09-02 22:33:36 -07:00
Matthias Maennich
c2346f1c21 ndk_library: separate abidw and abitidy into separate rules 
Both processes might consume a large amount of memory when analyzing
library ABIs. By chaining them via a pipe we keep the same
representation twice in memory. That can introduce a problematic peak
memory consumption. Hence, split them apart into separate rules that
depend on each other.

Bug: 191235788
Test: m out/soong/abi-dumps/ndk/28/x86_64/libc/abi.xml
Signed-off-by: Matthias Maennich <maennich@google.com>
Change-Id: Ia0264a5ede5b2c2a3c2e3fbe968c11d36acf33c2
 2021-09-02 21:04:15 +01:00
Lukacs T. Berki
b838b0a147 Do not modules in files called "Blueprints". 
The only case for this was Blueprint itself at build/blueprint, but with
that being a part of Soong, this special case is not necessary anymore.

Test: Presubmits.
Change-Id: Icc51cd80bd43f936a97018061cfbf76fc385e4c3
 2021-09-02 11:46:24 +02:00
Chris Ye
50ef6e204a Add android.hardware.wifi.hostapd-V1-ndk_platform to VNDK list. 
Bug: 194806512
Test: Boot up.
Change-Id: I50518b0291dd40dc051c340faa2641c4cf5952d4
 2021-09-01 15:34:12 -07:00