Commit Graph

66115 Commits

Author SHA1 Message Date
Spandan Das
7ea003c9d4 Merge "Update directorySize check in TestZip64P7ZipRecords" 2023-06-22 20:51:37 +00:00
Andus Yu
f3da8ee95b Merge "Do not check ssh credentials when running gcertstatus" 2023-06-22 19:38:33 +00:00
Ivan Lozano
464f3b381e rust: Enable stack-protector for Rust modules
Bug: 288407220
Test: m
Change-Id: Ifea0d4e3be715d9cef74ddfc6e64447a006fe0ed
2023-06-22 18:03:16 +00:00
Yabin Cui
294f839606 Update clang version to clang-r498229
Bug: 280683256
Test: presubmit
Change-Id: Idd0e171f11e0a7f44c64744744505ddeaca6f2fd
2023-06-22 17:29:55 +00:00
Mitch Phillips
92d19fa306 [MTE] Add memtag_globals as a sanitizer target.
MTE globals needs four pieces:
 1. (done) clang/llvm to produce objfiles with MTE globals metadata
 2. (in flight, https://reviews.llvm.org/D152921) lld to process the metadata in the objfiles, and produce information in each DSO describing the global variables that need to be tagged (alongside some other stuff).
 3. (this patch) android to handle the new sanitizer
 4. (not yet sent) bionic's libc/linker to interpret the information in each DSO, and tag the global variables.

Because #2 will take some time to come through the toolchain rolls, and #3 and #4 can be landed asynchronously, we can land this ahead of time. Should make my life easier by preventing constant rebases.

Bug: N/A
Test: Build {libc, libm, libc++, libm, and libnetd} in internal master
with these patches and an experimental compiler with the lld support.
Also, `SANITIZE_TARGET=memtag_globals m` here with in-tree compiler
without lld support.

Change-Id: Ie7882d474d4d776232de3a3d571a82274df14bf0
2023-06-22 17:04:40 +00:00
Dan Albert
2c59e46034 Merge "Include tags in trace data." 2023-06-22 16:37:36 +00:00
Spandan Das
ce7cbbe788 Update directorySize check in TestZip64P7ZipRecords
With ag/20611145, the dir size is not uint32max by default. Update the
value in the test accordingly.

(The test was not discovered in CI because gotestrunner
runs the tests using `-test.short` flag, and skips this test)

Test: go test ./third_party/zip -run  TestZip64P7ZipRecords
Change-Id: I47885f23fe32ff5ed30c44d52561cd11d59020ec
2023-06-22 16:29:25 +00:00
Colin Cross
c85750bfe3 Use generics for DepSets
Use Go's generics for DepSets so they don't require a type-specific
wrapper and reflection.

Test: depsets_test.go
Change-Id: I22ba0b7d680d37d2cd05230b0f560d166c4dd20b
2023-06-22 08:18:33 -07:00
LaMont Jones
1b5162196c Merge "Improve memory usage in multiproduct_kati" 2023-06-22 15:03:11 +00:00
Joe Onorato
9cb6a722eb Merge changes from topic "aconfig_renames"
* changes:
  Rename device_config --> aconfig and definitions --> declarations
  Rename aconfig namespace to package.
2023-06-22 13:30:53 +00:00
Nikita Ioffe
4a241d0852 Merge "Update neverallow rules for init_first_stage" 2023-06-22 10:11:31 +00:00
Treehugger Robot
542f84f4ef Merge "Remove reference to the deprecated and disabled Typo issue" 2023-06-22 01:25:55 +00:00
LaMont Jones
610ebf0312 Improve memory usage in multiproduct_kati
Start the subtasks at 15 second intervals, rather than all at once.

Bug: b/286423944
Test: manual
Change-Id: I21981460dcdd618f42abefcc221a05ce6aca84c1
2023-06-22 00:45:03 +00:00
Joe Onorato
981c926269 Rename device_config --> aconfig and definitions --> declarations
Bug: 285303012
Test: for x in next trunk trunk_food trunk_staging ; do lunch aosp_panther-$x-eng ; m nothing ; done
Change-Id: I3375f46b3ecbbc516d1bee6ab3f80725fcccde8f
2023-06-21 15:16:23 -07:00
andusyu
0b3dc03f9d Do not check ssh credentials when running gcertstatus
reproxy only requires LOAS credentials for authentication. Append the
-nocheck_ssh option to gcertstatus so we don't check ssh credentials.

Test: RBE successfully started after running gcertdestroy --nodestroy_loas2
Bug: b/287297140
Change-Id: I413931b10d8e8d9ae2f8acd7ebfe37d8b3bba455
2023-06-21 17:30:21 -04:00
Treehugger Robot
f44ac9efc1 Merge changes I6ddb47d7,I3df3d304
* changes:
  [hwasan] Increase BB to explore for reachability
  [hwasan] Also pass use-after-scope flag in LTO
2023-06-21 21:14:52 +00:00
Mark Dacek
bf4d727ca9 Merge "Add bes-id to soong. Also renames the proto field." 2023-06-21 21:04:07 +00:00
Joe Onorato
81b25ed02b Rename aconfig namespace to package.
Bug: 285303012
Test: for x in next trunk trunk_food trunk_staging ; do lunch aosp_panther-$x-eng ; m nothing ; done
Change-Id: I9ee3b1f0207b828557d339d7f50cad77ff16310f
2023-06-21 13:49:37 -07:00
Dan Albert
e82234ed50 Include tags in trace data.
The tags item in the trace data is arbitrary metadata added to `build`
steps by Soong (and my Kati via `.KATI_TAGS` target-specific
variables). Include this in the perfetto trace so we can analyze it.

Bug: http://b/259130368
Test: End to end test tracing cp time in dist targets
Change-Id: I85d33f579dc40dbae616b24cd4cb150d86262470
2023-06-21 20:17:57 +00:00
Treehugger Robot
0acd271057 Merge "Remove unnecessary variable" am: 98bb2768b9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2628590

Change-Id: Ia9da45204dddb35ccb0cc60b69cfc40d339e928d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 19:02:17 +00:00
Treehugger Robot
98bb2768b9 Merge "Remove unnecessary variable" 2023-06-21 18:13:38 +00:00
Nikita Ioffe
11a9c2c763 Update neverallow rules for init_first_stage
We are introducing Microdroid-specific variant of the init_first_stage,
and need to add init_first_stage_defaults and
init_first_stage.microdroid to the neverallow rule.

Bug: 287206497
Test: build com.android.virt APEX
Change-Id: I88543256ab0479d4676865ebb1d16d9d39f1f455
2023-06-21 16:51:09 +01:00
Alix
e266787aed bp2build conversion for rscript srcs in cc modules
Bazel does not support using .rscrip/.fs files as cc srcs.
For a module foo with foo srcs, Bp2build will create a bazel
target of rule class rscript_to_cpp with name foo_renderscript
which will have only the renderscript files as srcs.
Bp2build will also create a target foo with the expected cc rule class.
The foo target will have all other src files as srcs and will also
have the target foo_renderscript as another src.

Bug: 210509914
Test: bp2build testing & b build target rstest-latency
Change-Id: Ifdc55051a3595f5fcf54eab8b59e11e9351e141c
2023-06-21 14:58:10 +00:00
MarkDacek
396491eee4 Add bes-id to soong. Also renames the proto field.
This is for integration with BES for bazel test metrics.
Bug: 287102416
Test: b build libcore:all --invocation_id=`uuidgen`
Test: build/bazel/scripts/analyze_build (to verify it's set)

Change-Id: I541b2d65bfa85718fc916582e0540384ae3810d9
2023-06-21 14:48:17 +00:00
Paul Duffin
c0036491cd Remove reference to the deprecated and disabled Typo issue
Metalava no longer looks for common typos. It relies on the code
analyzers that run on Gerrit to detect them.

Bug: 288072162
Test: m checkapi
Change-Id: I08eca8008af39ebe69442db419ebd3d3378aa0de
2023-06-21 15:42:49 +01:00
Mårten Kongstad
e1a30716f8 Merge "Rename aconfig intermediate file (json -> pb)" am: 8f55732317
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2631114

Change-Id: I33c2a5652d3224acc6150a3e0c4d5d43c9982adf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 14:15:38 +00:00
Mårten Kongstad
8f55732317 Merge "Rename aconfig intermediate file (json -> pb)" 2023-06-21 13:30:20 +00:00
Lukacs T. Berki
200e0a8672 Handle errors from RunBlueprint(). am: c357c81f48
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2627181

Change-Id: Icaec3e02a1bda4985bce2e03fa2d1a6295e82104
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 11:48:17 +00:00
Lukacs T. Berki
c357c81f48 Handle errors from RunBlueprint().
Bug: 244730498
Test: Presubmits.
Change-Id: I264f1e4bd989b1c219800eec3be007c3f114c6d1
2023-06-21 07:59:52 +00:00
Mårten Kongstad
c89e924ec2 Rename aconfig intermediate file (json -> pb)
aconfig's intermediate file ("the cache") has changed format from json
to protobuf. Rename the generated file accordingly.

Bug: 283910447
Test: m nothing # run soong tests
Change-Id: Iaff408774cfba4231dfb951b112b554466b8e884
2023-06-21 08:32:53 +02:00
Treehugger Robot
f0b01a78cd Merge "Remove PRODUCT_INSTALL_EXTRA_FLATTENED_APEXES" am: be24d2733c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2626018

Change-Id: I5692696e468a73a89fbf20bc03ed93b0f86f3ef8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 06:08:08 +00:00
Jooyung Han
eec1b3fe26 Remove "flattened" apexes
Now soong doesn't build "flattened" apexes.

Bug: 279835185
Test: m nothing (soong tests)
Test: m && launch_cvd (cuttlefish)
Change-Id: Id3c540ece1a15cecacc185da9aa17285edd2f493
2023-06-21 14:29:26 +09:00
Treehugger Robot
be24d2733c Merge "Remove PRODUCT_INSTALL_EXTRA_FLATTENED_APEXES" 2023-06-21 05:18:58 +00:00
Usta (Tsering) Shrestha
ed1c6a1214 Merge "Disallow java_test_host dependant" am: f615e900e9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2631270

Change-Id: I005ba31f45faede39463e58d5d127fbeb63a5dc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 00:58:27 +00:00
Spandan Das
60133b3070 Symlink external/bazelbuild-rules_go in mock tests
Test: TH
Change-Id: I067bda143252c66bfac63699d51ca3b80f5a5f63
2023-06-21 00:48:05 +00:00
Usta (Tsering) Shrestha
f615e900e9 Merge "Disallow java_test_host dependant" 2023-06-21 00:28:33 +00:00
Jason Macnak
5146d553ea Remove FrontendStub_[cc|h] from SandboxingDenyModuleList
Bug: b/288170603
Test: GENRULE_SANDBOXING=true m FrontendStub_cc
Test: GENRULE_SANDBOXING=true m FrontendStub_h
Test: build/soong/tests/genrule_sandbox_test.py FrontendStub_cc
Test: build/soong/tests/genrule_sandbox_test.py FrontendStub_h
Change-Id: I863d65ce921a98b91e1aa4c5eebfcf94178f633d
2023-06-20 23:52:47 +00:00
Trevor Radcliffe
07aff97357 Merge "Explicitly disable CFI in bp2build when false" am: 8bd06008dc
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2628495

Change-Id: I518e1d2aef6ce22f421a4fae2332cc655c4ba003
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-20 20:05:39 +00:00
David Duarte
97f4d8224b Merge "genrule_sandbox_test: Remove space in }generate filter" am: 6a2c54a478
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2623216

Change-Id: I5cf3bd85ae88d1f8474863a2acfa9a2b046ef299
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-20 20:05:14 +00:00
Trevor Radcliffe
8bd06008dc Merge "Explicitly disable CFI in bp2build when false" 2023-06-20 19:52:17 +00:00
Usta (Tsering) Shrestha
1205d717cb Disallow java_test_host dependant
Bug: 287462798
Change-Id: I98cc7c9bb1d9fbaf3211284c02c85e0037e2059c
Test: ABTD run
2023-06-20 19:08:45 +00:00
David Duarte
6a2c54a478 Merge "genrule_sandbox_test: Remove space in }generate filter" 2023-06-20 18:36:13 +00:00
usta
49012eeacb cosmetic
ninja() is only called for soong bootstrap now

Test: NA
Bug: NA
Change-Id: Iededf601dc3bb92d8681b1e008bf20b4da406f4c
2023-06-20 14:00:44 -04:00
Elliott Hughes
02fec85409 Merge "Bump the platform default up to C17." am: 1b2a65783d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2626336

Change-Id: Iab415f33b90235c625dac3f2fd97bd94ea91b65b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-20 17:09:42 +00:00
Christopher Parsons
1f876020cf Merge "Add -gen suffix to genrule targets with conflicts" am: bf1b88dd35
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2626356

Change-Id: I696eaeeba8ea5c2c1be0b25ff76a6934d4add83c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-20 17:09:03 +00:00
Elliott Hughes
1b2a65783d Merge "Bump the platform default up to C17." 2023-06-20 16:56:51 +00:00
Christopher Parsons
bf1b88dd35 Merge "Add -gen suffix to genrule targets with conflicts" 2023-06-20 16:32:18 +00:00
Jooyung Han
eeeda8a94c Remove PRODUCT_INSTALL_EXTRA_FLATTENED_APEXES
We will deprecate flattened apexes. In this change, GSI-specific make
variable (PRODUCT_INSTALL_EXTRA_FLATTENED_APEXES) is removed. The
variable was used to install both image/flattened apexes in the GSI, so
that it works on ro.apex.updatable devices and not-updatable devices.

Now, GSI will have only image APEXes in it.

Bug: 278826656
Test: lunch gsi_arm64-userdebug && m # no flattened apexes
Change-Id: Ie5fe505b9f2a6a1687252513788fd3e16bc147c5
2023-06-20 14:31:39 +09:00
Florian Mayer
c746619feb [hwasan] Increase BB to explore for reachability
We pass mcpu=cortex-a55 for our build, which increases BB to the point
where the LLVM default of 32 is not enough. This caused worse coverage
for use-after-scope detection, and increased stack usage.

Test: build oriole_hwasan
Bug: 229654778
Change-Id: I6ddb47d7224a9c6ddbf2641c043e3430d330c5a9
2023-06-16 17:34:59 -07:00
Florian Mayer
a998446d3e [hwasan] Also pass use-after-scope flag in LTO
Change-Id: I3df3d3047fd5aaa93e6c4b68885d39e20b12ccdb
2023-06-16 17:34:57 -07:00