Commit Graph

36225 Commits

Author SHA1 Message Date
Rupert Shuttleworth
fb955387db Update info on some deny-list entries.
(Some info has been relocated to blockers in Buganizer)

Also remove libjemalloc5 and fmtlib_ndk from the deny list as they don't seem to need to be there at the moment.

Test: bazel build //bionic/...
Test: build/bazel/scripts/run_presubmits.sh

Change-Id: I87e9dd3d4a83291efbcc15d6b99187b57d45ad18
2021-05-03 04:47:03 -04:00
Jingwen Chen
2b54eb8375 bp2build: remove manifest file for bp2build-sync.
The latter doesn't exist anymore, so there's no more need for the
bp2build file manifest.

Bug: 185817076
Test: TH
Change-Id: I6638b84eb371ced98474e3ca5026e3b33b824767
2021-05-03 06:49:54 +00:00
Treehugger Robot
33edfca5da Merge "Add debug ramdisk variant." am: cbaef6ff0f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690925

Change-Id: Ifc90b7a054768748d13bba54e63170a4c2cf8bba
2021-05-03 00:13:50 +00:00
Treehugger Robot
cbaef6ff0f Merge "Add debug ramdisk variant." 2021-05-02 23:54:40 +00:00
hamzeh
c651b5295b Add support for packaging rust fuzzers
Test: make haiku-rust
Change-Id: Idd4d836d11e0ae615b59c6648d49348449589787
2021-05-01 00:55:42 -07:00
David Srbecky
69315e4ea7 Use create_minidebuginfo tool instead of bash script.
The behaviour is semantically identical, however,
the tool additionally sorts the symbols by address,
compresses frame unwind information more efficiently,
and improves random-accessibility for lazy decompression.

Overall, the changes balance and the output size is same,
however, libunwindstack can access the data much faster
while using less memory (due to the lazy decompression).
It will also enable further improvements in the future.

Bug: 110133331
Test: ART unwinding tests, run prefetto on the device.
Change-Id: Id48f9fe67fb67fcf2b90cc3b217b71bb8f5147ca
2021-05-01 00:06:07 +01:00
Colin Cross
29c294b2cf Time out and dump stacks from R8 processes after 30 minutes
R8 processes are sometimes hanging on the build servers.  Wrap R8 with
run_with_timeout to dump the stacks with jstack and kill the process
after 30 minutes.  Switch from running with the r8-compat-proguard
shell script to running the jar directly so that jstack gets the pid
of the java process.

Bug: 181095653
Test: m checkbuild
Test: m NetworkStackNextIntegrationTests
Test: m USE_RBE=true RBE_R8=true RBE_R8_EXEC_STRATEGY=remote NetworkStackNextIntegrationTests
Change-Id: If6996bd8eb39c7a8453d79e825004339c009ade2
2021-04-30 14:14:46 -07:00
Colin Cross
9b6bcc6bff Add a wrapper command to detect timeouts
Add a command that can be used to wrap actions with a timeout, and
optionally run an extra debugging command on timeout.

Bug: 181095653
Test: run_with_timeout_test.go
Change-Id: I91df5c3fb5277968717815a4ad4612113766dab1
2021-04-30 14:14:45 -07:00
Chris Parsons
5b710bf057 Support multilib properties in bp2build am: c424b76f76
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1691268

Change-Id: I193eb41fe687131a562ea9f928b767cfa8a86c26
2021-04-30 17:44:51 +00:00
Chris Parsons
c424b76f76 Support multilib properties in bp2build
This combines properties among "multilib" and "arch" stanzas in selects
generated by bp2build.

With this fix, libc_gdtoa may be removed from the denylist.

This change also refactors a portion of arch.go, specifically bp2build's
arch mutator, adding a number of comments along the way, to hopefully
make this code clearer for future readers.

Test: mixed_libc.sh
Change-Id: If2beea672957cfb1af6760406ba507181ec38f77
2021-04-30 13:21:36 -04:00
Colin Cross
adf79a5e3e Merge "Add prebuilt_rfsa module type" am: 8d0ed7ebd5
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1671668

Change-Id: I603dee969c5dea822b89e5501c95aa338d83abc0
2021-04-30 16:52:23 +00:00
Colin Cross
8d0ed7ebd5 Merge "Add prebuilt_rfsa module type" 2021-04-30 16:35:20 +00:00
Paul Duffin
ca945032c8 Merge "Split findAndCopyBootJars into separate find and copy functions" am: 21695e2ce9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1688393

Change-Id: I91ec7304577005fed8ce50690fcedfd08e6f6b21
2021-04-30 16:29:27 +00:00
Paul Duffin
21695e2ce9 Merge "Split findAndCopyBootJars into separate find and copy functions" 2021-04-30 16:09:56 +00:00
Lukács T. Berki
8e9c7d9212 Merge "Handle the version_script property." am: dac1db044b
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690878

Change-Id: I9a76a28df76088171def80b57c1e067f17382dc0
2021-04-30 14:59:31 +00:00
Colin Cross
46c461b968 Merge "Ignore cc.Module.HideFromMake when producing flattened apex Android.mk entries" am: a5b1ea248f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1691266

Change-Id: I719b1c8cbdf79d279c3e8d0d8c3d5e262388495b
2021-04-30 14:58:21 +00:00
Colin Cross
8226a33d4d Merge "Clean symbols directory during installclean" am: 13b03bf5bb
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1688963

Change-Id: I32d7f8827fda969ab9be74875fb6362a206d8d55
2021-04-30 14:57:27 +00:00
Lukács T. Berki
dac1db044b Merge "Handle the version_script property." 2021-04-30 14:50:19 +00:00
Lukacs T. Berki
1353e59690 Handle the version_script property.
Doesn't work when depends on arch/target/etc., but good enough for
libdl_android.

Bug: 186650430
Test: Presubmits.
Change-Id: Ib0facb41a89454717c74663e5e078aedd33d1b9c
2021-04-30 16:46:41 +02:00
Colin Cross
a5b1ea248f Merge "Ignore cc.Module.HideFromMake when producing flattened apex Android.mk entries" 2021-04-30 14:43:03 +00:00
Colin Cross
13b03bf5bb Merge "Clean symbols directory during installclean" 2021-04-30 14:42:46 +00:00
Paul Duffin
3e7cb6c6e2 Merge "Fix build failure when building unbundled apps (second try)" am: fdf4050440
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690873

Change-Id: If6e07f9574085d7b0a26b1f2b07a7d9973ef49e0
2021-04-30 14:36:13 +00:00
Paul Duffin
fdf4050440 Merge "Fix build failure when building unbundled apps (second try)" 2021-04-30 14:16:32 +00:00
Jingwen Chen
2a205101c3 Merge "bp2build: add bugs and update bp2build denylist." am: bb546aaea0
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690928

Change-Id: I00db822c5ec46f38277fee19b0bf113fb2eb7a7c
2021-04-30 13:13:38 +00:00
Treehugger Robot
e4a004eaa3 Merge "Move configuration checks from getBootImageJar" am: 3f9af76391
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1688391

Change-Id: Ide21375eb1303c2ea57bd687de71c99d1f78da04
2021-04-30 13:13:07 +00:00
Jingwen Chen
bb546aaea0 Merge "bp2build: add bugs and update bp2build denylist." 2021-04-30 13:08:32 +00:00
Treehugger Robot
3f9af76391 Merge "Move configuration checks from getBootImageJar" 2021-04-30 12:56:56 +00:00
Andrei-Valentin Onea
ea34723186 Merge "Exclude RequiresApi from generated stubs" am: f794e8269d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690867

Change-Id: I497cd4d988d32d2302e566739bd9cbfce486af28
2021-04-30 12:49:54 +00:00
Paul Duffin
d504c3ac83 Fix build failure when building unbundled apps (second try)
The previous attempt, which simply skipped the hidden API processing
altogether when unbundled builds were enabled failed when attempting to
build module snapshots as while they enabled an unbundled build they
actually need the hidden API processing to be performed.

This change just checks whether missing dependencies are allowed and if
so it fakes up any missing files so that the build will only fail if
they are not present AND they are used.

Bug: 186695448
Bug: 185828824
Test: tapas Calendar
      m -j60

Change-Id: Ie13fed05af0aba51f45f6791fce944d0e4285037
2021-04-30 13:42:44 +01:00
Andrei-Valentin Onea
f794e8269d Merge "Exclude RequiresApi from generated stubs" 2021-04-30 12:31:07 +00:00
Paul Duffin
d6894ca4b9 Split findAndCopyBootJars into separate find and copy functions
The main difference between the dexpreopt_bootjars singleton and the
platform_bootclasspath singleton module is the way they find the
modules to use. The former searches all modules, the latter adds
dependencies on the modules that they need. This change separates the
finding of the modules from the copying of the boot jars for those
modules to make it easier to move the remaining functionality to
platform_bootclasspath.

This temporarily creates a singleton specific copy of the hidden API
function isModuleInConfiguredList() to select the modules in place of
the logic in the getBootJar() method. There is a slight loss of context
information from the error messages but as these methods will be
removed once the boot image creation has moved this is not an issue.

While switching the isModuleInConfiguredListForSingleton() to use the
SingletonContext the error message was fixed to include the name of
the module with the issue.

Bug: 177892522
Test: m nothing
Change-Id: Iaea906da95d9da5301fb964fc593890f2216d336
2021-04-30 12:10:54 +01:00
Paul Duffin
f23bc472b0 Move configuration checks from getBootImageJar
The getBootImageJar function will be removed once the boot image
creation has been moved to the platform_bootclasspath and
bootclasspath_fragment module types. However, the consistency checks
that it performs are still useful so this change moves them out
first.

The ART boot image related checks are now performed in the
bootclasspath_fragment module type. A previous change accidentally
disabled the checks when the contents property was not empty which has
been fixed. Also, the error messages have been tweaked to make it clear
that the art-bootclasspath-fragment is now the source of truth as to
its contents not the configuration.

The framework boot image related checks are now performed in the
platform_bootclasspath module type.

Initially, this change included an extra check to make sure that
UpdatableBootJars comes from updatable APEXes but that broke because
framework-wifi and framework-tethering are not currently marked as
updatable in AOSP.

Bug: 177892522
Test: m nothing
Change-Id: I80fb600fa2c7cec4566b3461c6a33c4c6f0743f4
2021-04-30 12:06:28 +01:00
Jingwen Chen
790324e69c bp2build: add bugs and update bp2build denylist.
This CL updates the error messages and reorganizes the bottom half of
the bp2build denylist.

Test: TH
Change-Id: Ib15d019ba9cd006a78474477af34c66b5e418348
2021-04-30 09:43:20 +00:00
Rupert Shuttleworth
2168230e8c Update reasons for modules being on the deny list (and add bug links). am: 47aa58420b
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1692285

Change-Id: Ibce30d1eab7a504cb1cda17ddd61f4e690a43850
2021-04-30 08:58:27 +00:00
Rupert Shuttleworth
47aa58420b Update reasons for modules being on the deny list (and add bug links).
Test: bp2build; bazel build //bionic/...
Test: build/bazel/scripts/run_presubmits.sh

Change-Id: I852146b9df57689c022cb4e6c5b9e4a764866822
2021-04-30 04:28:49 -04:00
Jingwen Chen
baf10be386 Group some modules together under a single bug for tracking purposes. am: d01da05860
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690927

Change-Id: I82be1a199afd621a268077de6e4b5f6155b71e8e
2021-04-30 05:47:45 +00:00
Jingwen Chen
d01da05860 Group some modules together under a single bug for tracking purposes.
Test: TH
Change-Id: I3f75bbd5c1455ab42d589d884a705bf09ef0b825
2021-04-30 03:33:15 +00:00
Treehugger Robot
00803e6ee9 Merge "Revert "Fix build failure when building unbundled apps"" am: 1468cc4a10
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1691213

Change-Id: I0c3523d447222dd95ee1efa2acec7121dbb19dce
2021-04-30 02:56:18 +00:00
Treehugger Robot
1468cc4a10 Merge "Revert "Fix build failure when building unbundled apps"" 2021-04-30 01:52:57 +00:00
Vishnu Nair
0dbd02a3ac Revert "Fix build failure when building unbundled apps"
This reverts commit c027119e73.

Reason for revert: b/186797512
Test: vendor/google/build/build_mainline_modules.sh -j80

Change-Id: I2bb062cce09ac6717702c4f6b110acbb2887adec
2021-04-30 00:24:07 +00:00
Paul Duffin
7e953b936d Merge "Fix build failure when building unbundled apps" am: 5983d856c1
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690870

Change-Id: I23780570f7ea33639d479dcbbd0b5e5870d523f4
2021-04-29 20:59:52 +00:00
Colin Cross
76f0ba81d3 Ignore cc.Module.HideFromMake when producing flattened apex Android.mk entries
The modules in a flattened apex have suffixes that ensure they don't
conflict with the platform versions, so they can ignore HideFromMake.
This ensures that Make can install symbols for all libraries in
apexes.

Fixes: 180622230
Test: banchan com.android.adbd && m && ls $OUT/symbols/apex/com.android.adbd/lib
Change-Id: I76d1aba2eed6ae27d9a954bf88f40f0d00fc6a98
2021-04-29 13:54:49 -07:00
Paul Duffin
8eee268aa7 Merge "Move generation of hidden API make vars to platform_bootclasspath" am: ad7fa97f8d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690548

Change-Id: Ie6250e02f8ca02cdaf2d43db3c7f9925f5690c14
2021-04-29 20:51:04 +00:00
Paul Duffin
5983d856c1 Merge "Fix build failure when building unbundled apps" 2021-04-29 20:19:54 +00:00
Paul Duffin
ad7fa97f8d Merge "Move generation of hidden API make vars to platform_bootclasspath" 2021-04-29 20:14:16 +00:00
Paul Duffin
c027119e73 Fix build failure when building unbundled apps
Bug: 186695448
Bug: 185828824
Test: tapas Calendar
      m -j60
Change-Id: I1c5365f6d2afb2f2d159e6f6ed004647ec6d2427
2021-04-29 19:50:40 +01:00
Paul Duffin
4b00abc5f7 Merge "Make platform_bootclasspath a singleton module" am: 86477cfeb2
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1690547

Change-Id: I5fe5f37dfc470674f7a7fe7907584ccaf0ea1d7a
2021-04-29 18:11:24 +00:00
Paul Duffin
86477cfeb2 Merge "Make platform_bootclasspath a singleton module" 2021-04-29 17:56:21 +00:00
Andrei Onea
4985e518f8 Exclude RequiresApi from generated stubs
This annotation is required for linting, but is not useful in stubs.

Bug: 185579441
Test: cherry-pick http://ag/14098354 and regenerate stubs
Change-Id: I7e4da99a8843b9c709f3b59f125f43cbd66bda4e
2021-04-29 17:00:46 +00:00
Colin Cross
ce7b244e33 Merge "Remove global state from vendor public libraries" am: e07056af41
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1689271

Change-Id: Id1e7b1e3d379698281ede2606c5e19e7922198aa
2021-04-29 16:31:40 +00:00