Commit Graph

3295 Commits

Author SHA1 Message Date
Pirama Arumuga Nainar
5f4da30d62 Refactor coverage support am: ee30d5e132 am: 312b5f4407
am: 2bccc05cbf

Change-Id: Ie2a491d4865015f7d3c062e0390a03de0ca14bc8
2019-03-29 09:31:24 -07:00
Pirama Arumuga Nainar
ef7a035152 Include libprofile-extras to all coverage variants am: 65c95ff1fb
am: 865ad54f90

Change-Id: I4afb3bf93ebda7d25957b988bf627481ad7889ca
2019-03-29 09:22:33 -07:00
Pirama Arumuga Nainar
2bccc05cbf Refactor coverage support am: ee30d5e132
am: 312b5f4407

Change-Id: I0aaf75cf2d0701a8f490a2b2bd2bdb388add63c3
2019-03-29 09:22:21 -07:00
Pirama Arumuga Nainar
865ad54f90 Include libprofile-extras to all coverage variants
am: 65c95ff1fb

Change-Id: I74057c0921eaa76c8016d0bb8f81abaf0eb50ed8
2019-03-29 09:17:15 -07:00
Pirama Arumuga Nainar
312b5f4407 Refactor coverage support
am: ee30d5e132

Change-Id: I859c7e6c535f1d99d26fa8148bc24a930933cd39
2019-03-29 09:17:04 -07:00
Pirama Arumuga Nainar
65c95ff1fb Include libprofile-extras to all coverage variants
Bug: http://b/128524141

Include libprofile-extras (defined in system/extras/toolchain-extras) to
all modules that need a coverage variant.  Also add
'-uinit_profile_extras' when linking with coverage.  This causes the
setup code in libprofile-extras to be linked into binaries/libraries
with coverage enabled.

We add the static library to the non-coverage variants as well but is a
no-op for them (since the '-u...' flag is not added for them).

Adding this dependency creates several circular dependencies since
coverage variants were being created for other module types that never
had any compilation or linking done during the build.  This change stops
creating coverage variants for toolchain_library, cc_prebuilt_library_*,
cc_library_headers module types (by adding a function to the linker
interface to specify whether native coverage is enabled).

Test: m NATIVE_COVERAGE=true COVERAGE_PATHS=*
Test: blueline_coverage target in internal branch (using forrest)
Change-Id: I5db876eb953639a55ba007248dd24e497f987730
2019-03-29 08:56:42 -07:00
Pirama Arumuga Nainar
ee30d5e132 Refactor coverage support
Bug: http://b/128524141

The goal is to add a static library (libprofile-extras) to modules that
require coverage.  Since the coverageMutator is a post-deps mutator, the
results of the coverageMutator are not available when the dependencies
get constructed in deps().  This change moves the detection from the
coverageMutator to begin().

Test: m NATIVE_COVERAGE=true COVERAGE_PATHS=*
Test: blueline_coverage target in internal branch (using forrest)

Change-Id: I4e7c8b31ed5060642c6218ea33c532a0f6619967
2019-03-29 08:56:42 -07:00
Patrice Arruda
a5d59cce58 Merge "Soong: Add synopsis to cc_library_* modules" am: bcf9408e44 am: 3a537940a7
am: 64c7368b39

Change-Id: I6f1db1d06a91ed7ec181ef9aa44f031affe8cc46
2019-03-29 08:50:13 -07:00
Patrice Arruda
64c7368b39 Merge "Soong: Add synopsis to cc_library_* modules" am: bcf9408e44
am: 3a537940a7

Change-Id: I4827491b28f6501a1c72eb578f4b15a29761dee0
2019-03-29 08:36:02 -07:00
Patrice Arruda
3a537940a7 Merge "Soong: Add synopsis to cc_library_* modules"
am: bcf9408e44

Change-Id: Ifb84210b4c15c1b3aef011677e4938cbbd200f9b
2019-03-29 08:32:03 -07:00
Patrice Arruda
bcf9408e44 Merge "Soong: Add synopsis to cc_library_* modules" 2019-03-29 15:21:21 +00:00
Yi Kong
ee2a987501 Merge "Move -Wno-inconsistent-missing-override to ClangExtraCflags" am: 2e03bb7296 am: 16bb6c063d
am: b82e51d36e

Change-Id: I5d528f6121701394ff26a7cd040a6ea40bc94106
2019-03-28 16:05:29 -07:00
Yi Kong
b82e51d36e Merge "Move -Wno-inconsistent-missing-override to ClangExtraCflags" am: 2e03bb7296
am: 16bb6c063d

Change-Id: I857212fc41601d918f57809eb2855316c8a8d640
2019-03-28 15:53:18 -07:00
Yi Kong
16bb6c063d Merge "Move -Wno-inconsistent-missing-override to ClangExtraCflags"
am: 2e03bb7296

Change-Id: I293a0167fcbdb240b31a9a53d9cc29c8acc20cf5
2019-03-28 15:49:14 -07:00
Yi Kong
2e03bb7296 Merge "Move -Wno-inconsistent-missing-override to ClangExtraCflags" 2019-03-28 22:37:47 +00:00
Patrice Arruda
83c89e0f4e Soong: Add synopsis to cc_library_* modules
Added synopsis to the following modules under cc package:
   * cc_library_static
   * cc_library_shared
   * cc_library
   * cc_library_host_static
   * cc_library_host_shared
   * cc_library_headers

Bug: b/128337482
Test: Generated the documentation and verified that the synopsis was
added to each of the module.

Change-Id: I4d9bb622dc75aad9ea1b9f331c80ed56ddbc9a15
2019-03-28 10:36:26 -07:00
Inseob Kim
64d8e8bbce Merge "Remove libbase dependency of sysprop_library" am: 9e50e6955f am: 93079643a1
am: 918b8ed0b2

Change-Id: If5d70d42b9fe1c320e22950ff98892b6a233b653
2019-03-27 20:19:38 -07:00
Inseob Kim
918b8ed0b2 Merge "Remove libbase dependency of sysprop_library" am: 9e50e6955f
am: 93079643a1

Change-Id: I07b2ba9f2e7f1ba12ffefe3637fa5d59b06e7ef6
2019-03-27 20:15:34 -07:00
Inseob Kim
93079643a1 Merge "Remove libbase dependency of sysprop_library"
am: 9e50e6955f

Change-Id: I32144aef537c89ff0a623cb4e3ceaf8acff12b4d
2019-03-27 20:11:29 -07:00
Treehugger Robot
9e50e6955f Merge "Remove libbase dependency of sysprop_library" 2019-03-28 03:01:27 +00:00
Yi Kong
4d048d5972 Move -Wno-inconsistent-missing-override to ClangExtraCflags
So that projects can override the flag through cflag (CPPFlags are
appended after CFlags).

Test: m checkbuild
Change-Id: Ib72f4ed4731f41982a0eb8a90c782c09810aa8c9
2019-03-27 18:26:22 -07:00
Yi Kong
1093f63255 Merge "Turn on new pass manager for PGO projects" am: edd7fdd891 am: 2692cfac0d
am: b979eb5bb2

Change-Id: Iff3236a595f2542b7e4c341304ff632befa78d44
2019-03-27 16:05:47 -07:00
Patrice Arruda
2903c0d370 Merge "Soong: Add synopsis to cc_object module." am: 5c45f684dd am: 3f056b869d
am: aeca13f9ab

Change-Id: Iddcf698d10683e41dc9336f91d6e5bc3d531d743
2019-03-27 16:05:18 -07:00
Yi Kong
b979eb5bb2 Merge "Turn on new pass manager for PGO projects" am: edd7fdd891
am: 2692cfac0d

Change-Id: I2df4dd1c805392e37e2b18eb10a2956d8a39c061
2019-03-27 16:01:38 -07:00
Patrice Arruda
aeca13f9ab Merge "Soong: Add synopsis to cc_object module." am: 5c45f684dd
am: 3f056b869d

Change-Id: Ibdd4f7dc72658b05d9f8e4a0012390931f4dab32
2019-03-27 16:01:15 -07:00
Yi Kong
2692cfac0d Merge "Turn on new pass manager for PGO projects"
am: edd7fdd891

Change-Id: Ic7eec8832d1397f741a579121ad8ad73bbf75189
2019-03-27 15:55:47 -07:00
Patrice Arruda
3f056b869d Merge "Soong: Add synopsis to cc_object module."
am: 5c45f684dd

Change-Id: Ic48e0d6800d3e0a00f45d72a6c5994fa3414281c
2019-03-27 15:55:17 -07:00
Yi Kong
edd7fdd891 Merge "Turn on new pass manager for PGO projects" 2019-03-27 22:44:31 +00:00
Patrice Arruda
5c45f684dd Merge "Soong: Add synopsis to cc_object module." 2019-03-27 22:38:28 +00:00
Yi Kong
e966338b71 Merge "Switch to clang-r353983b" am: ac7f27eab0 am: 09836cfa49
am: 12ec28e712

Change-Id: I0a9f518627d0758dfdb87fdc93a04bbe00bcfea0
2019-03-27 09:10:20 -07:00
Yi Kong
12ec28e712 Merge "Switch to clang-r353983b" am: ac7f27eab0
am: 09836cfa49

Change-Id: I13a3b37aac18d88dca5d04b42989162d28f4d30b
2019-03-27 08:59:26 -07:00
Yi Kong
09836cfa49 Merge "Switch to clang-r353983b"
am: ac7f27eab0

Change-Id: I1925ea786ce8d122cb3bffebae9824f5f4e7efaf
2019-03-27 08:55:16 -07:00
Yi Kong
ac7f27eab0 Merge "Switch to clang-r353983b" 2019-03-27 15:52:05 +00:00
Nikita Ioffe
8fdf81578e Merge "Add support for clang-tidy -warnings-as-errors in Android.bp files" am: ca57e57837 am: cc92d0203f
am: cf2c651116

Change-Id: Ia68ea717db13cf10d6a5c4e0da7dea23235761fc
2019-03-27 03:34:13 -07:00
Nikita Ioffe
cf2c651116 Merge "Add support for clang-tidy -warnings-as-errors in Android.bp files" am: ca57e57837
am: cc92d0203f

Change-Id: I4bd3a9aa5f231d00f850f7b71f028f454cf63629
2019-03-27 03:30:06 -07:00
Nikita Ioffe
cc92d0203f Merge "Add support for clang-tidy -warnings-as-errors in Android.bp files"
am: ca57e57837

Change-Id: I8545d90aeb6eeea40a455b413796f428be9724c9
2019-03-27 03:26:03 -07:00
Nikita Ioffe
ca57e57837 Merge "Add support for clang-tidy -warnings-as-errors in Android.bp files" 2019-03-27 10:18:15 +00:00
Inseob Kim
1f959769f3 Remove libbase dependency of sysprop_library
libbase dependency is not really needed, but it has been causing build
failure while linking with static variant of sysprop_library. This cuts
the dependency and only depend on libbase_headers and liblog.

Bug: 129301987
Test: 1) flash and boot walleye
Test: 2) try to build various properties with sysprop_library.
Test: 3) sysprop_test
Change-Id: I027e01c754b782818f52103184301267d4cdd576
2019-03-27 17:27:05 +09:00
Yi Kong
5d7aeeac24 Switch to clang-r353983b
Test: TreeHugger
Bug: 122993569
Bug: 128427449
Bug: 128937182
Bug: 128973188
Change-Id: I300efbbad47973d265f636645b83dad0c4d6630a
2019-03-27 02:09:40 +00:00
Nikita Ioffe
32c4986268 Add support for clang-tidy -warnings-as-errors in Android.bp files
Test: manually change Android.bp and checked clang-tidy invocation cmd
Change-Id: I51a64b3f7da82428b896f46f739c93d76a050aaf
2019-03-26 20:47:08 +00:00
Patrice Arruda
baff0ce5e4 Soong: Add synopsis to cc_object module.
Added synopsis to the cc_object module.

Bug: b/128337482
Test: Generated the documentation and verified that the synopsis was
properly added.

Change-Id: Icba4522a3aafa1b8b8a0b780d111f8b48cbdd270
2019-03-26 13:41:28 -07:00
Patrice Arruda
3e607a64f5 Merge "Soong: Add synopsis to several modules under cc package." am: 0aad00631a am: 97d123fc9f
am: 7db64bd147

Change-Id: I105d7e09c57e475ccab3beaee66619a699ce291c
2019-03-25 21:06:11 -07:00
Patrice Arruda
7db64bd147 Merge "Soong: Add synopsis to several modules under cc package." am: 0aad00631a
am: 97d123fc9f

Change-Id: I142dfa4e395c2e4b9837dfcf15c492ccdf6bdc79
2019-03-25 20:57:35 -07:00
Patrice Arruda
97d123fc9f Merge "Soong: Add synopsis to several modules under cc package."
am: 0aad00631a

Change-Id: I23d31ee45bdf4067bc1a2d111d69f44e7a15e65a
2019-03-25 20:53:23 -07:00
Treehugger Robot
0aad00631a Merge "Soong: Add synopsis to several modules under cc package." 2019-03-26 03:39:13 +00:00
Yi Kong
120e1f03d9 Merge "Support LLD ThinLTO cache/threshold option" am: ff58c0e248 am: 7fc090bd63
am: 51584413cb

Change-Id: I86a6f15d8f513d009e61661e85115b2789746588
2019-03-25 17:27:06 -07:00
Yi Kong
51584413cb Merge "Support LLD ThinLTO cache/threshold option" am: ff58c0e248
am: 7fc090bd63

Change-Id: Icca4ebbfd9650a02123fde99476f1e528ca36f35
2019-03-25 17:23:20 -07:00
Yi Kong
7fc090bd63 Merge "Support LLD ThinLTO cache/threshold option"
am: ff58c0e248

Change-Id: I8f874371ed10da26a3ae7ad739fb4e26b9c96719
2019-03-25 17:15:41 -07:00
Yi Kong
ff58c0e248 Merge "Support LLD ThinLTO cache/threshold option" 2019-03-26 00:02:36 +00:00
Sasha Smundak
7155cfea35 Treat stl: "system" the same way as default. am: fc22e4eeba am: 1939abdb9f
am: 9163cae4fa

Change-Id: I248acda27385190d776c9364ce4fbf6c288230c8
2019-03-25 11:37:42 -07:00