Commit Graph

3295 Commits

Author SHA1 Message Date
Sundong Ahn
5b73f31c80 Add dependency for sysprop
The dependency is added because the module that uses the sysprop library
needs generated code before it is built.

Test: m -j
Change-Id: I2858fc6fa6f2fe16afa2f4a7ae62746ba0f67e5c
2018-12-19 07:23:08 +00:00
Treehugger Robot
8cc51b5620 Merge changes Idb2b552b,I190bca35
* changes:
  When a stub is built for APEX, it is generated with --apex
  APEX-specific symbols can be tagged as # apex
2018-12-19 06:28:23 +00:00
Evgenii Stepanov
3c5a52a477 [hwasan] Reduce history size to save memory.
Bug: 112437883
Test: adb shell echo $HWASAN_OPTIONS
Change-Id: Ifc4ab10e37efb1a0ce7ea77ad691947d24c2da2b
2018-12-18 17:02:44 -08:00
Jaewoong Jung
232c07c217 Ignore shared libs for static executables.
Ie42edc5184f315f998db953594e425214b810e0e added system_shared_libs to
static libraries so that their exported headers can be referenced.
However, it also added unrequired dependencies, which is an
error-triggering issue for static executables.

This change addresses it by adding a condition to shared libs handling code
in binary.go.

Bug: 121152570
Test: cc_test.go, library_test.go
Change-Id: I1828442c4e496f8d815fccaeca970cd5766bdf5d
2018-12-18 15:56:59 -08:00
Jiyong Park
75bfb61c97 Remove -include <file> when compiling stubs. am: 6437995170 am: b24226fdcc
am: 098ab903b1

Change-Id: I12db2fa0644daf777fd7e1ab7a3d4d952ac2cefa
2018-12-15 09:23:13 -08:00
Jiyong Park
098ab903b1 Remove -include <file> when compiling stubs. am: 6437995170
am: b24226fdcc

Change-Id: Ie286839df36ba9bd7bf439e233c888d3c1a715cf
2018-12-15 09:18:06 -08:00
Jiyong Park
b24226fdcc Remove -include <file> when compiling stubs.
am: 6437995170

Change-Id: I9a6d6b7b2d6498c404104d6b731b9a20b2913464
2018-12-15 09:14:05 -08:00
Jiyong Park
3fd0baf651 When a stub is built for APEX, it is generated with --apex
Now, symbols that are only to be visible to across APEXes can be tagged
as # vndk. Then when generating the stubs library, the tagged symbol
is included. The symbol is NOT included in other cases; build NDK stubs,
etc.

Bug: 120638081
Test: m (apex_test updated.)
Change-Id: Idb2b552badddfc26af113cc8d4b984788f478813
2018-12-16 02:13:14 +09:00
Jiyong Park
bb4e13536e APEX-specific symbols can be tagged as # apex
If a symbol is tagged as # apex, then it is exported when gen_stub_libs
is invoked with --apex.

Bug: 120638081
Test: python3 cc/test_gen_stub_libs.py

Change-Id: I190bca35d1a4fb422b37d1be41a34de1ad64de6b
2018-12-16 02:12:13 +09:00
Jiyong Park
22643607da Merge changes I350fe490,I31e61862,I09b78e38 am: 1ee00b54d9 am: 04f6a9db21
am: d0c11753f6

Change-Id: If48f070b6a0a329f4ab069b7360d40b3bddb5fd8
2018-12-15 06:09:21 -08:00
Jiyong Park
d0c11753f6 Merge changes I350fe490,I31e61862,I09b78e38 am: 1ee00b54d9
am: 04f6a9db21

Change-Id: I6ba60b168f05f53d1e368229ab2ce2b1d2b9bf87
2018-12-15 06:04:15 -08:00
Jiyong Park
6437995170 Remove -include <file> when compiling stubs.
Otherwise, the force included headers might cause conflicting types
error with the symbols in the generated stubs source code. e.g.

double acos(double); // in header
void acos() {} // in the generated source code

Bug: 120266448
Test: m (apex_test also updated, and passing)
Change-Id: I717df990959d1b24ec515f0f52a4e28b94e92f32
2018-12-15 23:03:47 +09:00
Jiyong Park
04f6a9db21 Merge changes I350fe490,I31e61862,I09b78e38
am: 1ee00b54d9

Change-Id: I2ea8c8333ecd2d48111131b6236d3005cb6f9075
2018-12-15 05:59:22 -08:00
Treehugger Robot
1ee00b54d9 Merge changes I350fe490,I31e61862,I09b78e38
* changes:
  Stubs libs are available for host
  Don't create unnecessary APEX variations
  Stubs dependency is not installed
2018-12-15 13:47:59 +00:00
Yi Kong
393bbbfe66 Merge "Move -Wno-null-pointer-arithmetic to external only" am: df76efe524
am: 3b47a3bd02

Change-Id: Id9623315759a50ee0480c10aebfa560cee47a7a1
2018-12-14 16:57:06 -08:00
Yi Kong
3b47a3bd02 Merge "Move -Wno-null-pointer-arithmetic to external only"
am: df76efe524

Change-Id: I71ba1b6dbd242eaf7614750076b565419ca8dae6
2018-12-14 16:44:58 -08:00
Yi Kong
c9f6db50d3 Move -Wno-null-pointer-arithmetic to external only
Test: m checkbuild
Bug: 72331524
Change-Id: I9c49a8cef547f6c840001fd203a0abecaeef44d5
Merged-In: I9c49a8cef547f6c840001fd203a0abecaeef44d5
(cherry picked from commit 3e88cb0399)
2018-12-13 18:36:19 -08:00
TreeHugger Robot
ca0ab68254 Merge "Move -Wno-null-pointer-arithmetic to external only" 2018-12-14 01:18:26 +00:00
Ivan Lozano
acde365286 Merge "Add option to avoid recovering with diagnostics." am: e98d11f733 am: e9c8b727e3
am: c5c4a3adec

Change-Id: I7032f704f26801baeb6ed046dd2bf992c16edf2c
2018-12-13 16:13:51 -08:00
Ivan Lozano
c5c4a3adec Merge "Add option to avoid recovering with diagnostics." am: e98d11f733
am: e9c8b727e3

Change-Id: I981ed804967b1378821431d93efdd3f917cf32c7
2018-12-13 15:33:22 -08:00
Ivan Lozano
e9c8b727e3 Merge "Add option to avoid recovering with diagnostics."
am: e98d11f733

Change-Id: I25dc9e445265751e20e9da805fbb2905090e3efd
2018-12-13 14:53:26 -08:00
Ivan Lozano
e98d11f733 Merge "Add option to avoid recovering with diagnostics." 2018-12-13 20:56:18 +00:00
Yi Kong
3e88cb0399 Move -Wno-null-pointer-arithmetic to external only
Test: m checkbuild
Bug: 72331524
Change-Id: I9c49a8cef547f6c840001fd203a0abecaeef44d5
2018-12-13 03:55:29 -08:00
Jiyong Park
0fefdeac91 Stubs libs are available for host
The runtime APEX is built for host as well as for target. Therefore
stubs libs should be available also for host.

Bug: 120670568
Test: follow the repro step shown in b/120670568#comment4
Change-Id: I350fe490848ae9ceb55aade0521bdfaf48ed083f
2018-12-13 12:01:31 +09:00
Jiyong Park
0ddfcd1188 Don't create unnecessary APEX variations
This change fixes a problem that APEX variations are created for the
modules that actually shouldn't built for any APEX. For example,
consider this case.

apex { name: "myapex", native_shared_libs: ["mylib"],}

cc_library { name: "mylib", shared_libs: ["libfoo#10"],}
cc_library { name: "libfoo",
             shared_libs: ["libbar"],
             stubs: { versions: ["10"], }, }
cc_library { name: "libbar", ...}

Before this change, both the stubs and non-stubs variations of libfoo
were mutated with apexMuator, which is incorrect for the non-stubs
varia; there is no dependency chain from the apex "myapex" to the
non-stubs variation, but to the stubs variation due to the #10 syntax.

This was happening becauses we used the name of the module to determine
whether it should be built for APEX or not. Both stubs and non-stubs
variations have the same module name "libfoo".

Fixing this issue by recording the list of APEX variations required
directly on the module. So, the stubs variation of libfoo has myapex in
its apex variations list, but the non-stubs variation doesn't, and thus
apexMutator does not pick up the non-stubs variation.

Test: m (apex_test updated and passing)
Test: cherry-pick ag/5747464 and m
Change-Id: I31e618626809a828a55fff513ef5f81f79637afa
2018-12-13 10:48:15 +09:00
Jiyong Park
de866cbe50 Stubs dependency is not installed
When the stubs variant of a library is dependend by a platform component
and the library is included in one or more APEX, the library is not
installed to the platform, because it is provided by APEX.

Bug: 120266448
Test: m
Test: add stubs: { versions: ["1"], }, to libnetd_resolv
then build netd. libnetd_resolv.so does not exist under /system.

Change-Id: I09b78e38df285033ef6e9c85f7ea4b0274e85070
2018-12-13 10:48:15 +09:00
Dongwon Kang
61e186504e Merge "Don't install stubs" am: f576fcd413 am: 32386a41e1
am: ca2ee9f499

Change-Id: Icf56bb6167c88d3ad24cc57e186c40af6b7c07ce
2018-12-12 10:55:05 -08:00
Dongwon Kang
ca2ee9f499 Merge "Don't install stubs" am: f576fcd413
am: 32386a41e1

Change-Id: I068e1e6907070769dacd5a04f4d86a7a66fa01ce
2018-12-12 10:50:02 -08:00
Dongwon Kang
32386a41e1 Merge "Don't install stubs"
am: f576fcd413

Change-Id: I85557c7896c53cdaeee3df300e88cc02f84e6c2a
2018-12-12 10:40:53 -08:00
Dongwon Kang
f576fcd413 Merge "Don't install stubs" 2018-12-12 18:15:35 +00:00
Ivan Lozano
7929bba218 Add option to avoid recovering with diagnostics.
Add a no_recover option that allows specifying which sanitizers in
diagnostics modes shouldn't recover. This can help debugging as we test
enabling sanitizers in new libraries since it'll cause tombstones to be
generated along with the diagnostics information.

Bug: 80195448
Bug: 110791537
Test: Compiled test module with this flag, checked compiler command.
Test: Test module crashed, tombstone contained diagnostics information.
Change-Id: Ie938923ef95716c2d49d6cd719ee223ad62755c6
2018-12-12 10:01:16 -08:00
Jerome Gaillard
d2cf2bf5af Merge "Upgrade Windows default build version from Vista to 7" am: ff42f04af8 am: 475b7d7fb7
am: b49619f48c

Change-Id: I9ab059679cad1e9986441be1c7c65bb3a218800d
2018-12-12 06:22:47 -08:00
Jerome Gaillard
b49619f48c Merge "Upgrade Windows default build version from Vista to 7" am: ff42f04af8
am: 475b7d7fb7

Change-Id: Ibde618c5677e708944eae7b72f76c2db647582c7
2018-12-12 06:16:42 -08:00
Jerome Gaillard
475b7d7fb7 Merge "Upgrade Windows default build version from Vista to 7"
am: ff42f04af8

Change-Id: I5bbcb61e74a847918867a7b26f9fc295c387b99d
2018-12-12 06:11:39 -08:00
Jerome Gaillard
ff42f04af8 Merge "Upgrade Windows default build version from Vista to 7" 2018-12-12 13:59:56 +00:00
Yi Kong
f22c336bcf Merge "Remove unneeded -Wno-expansion-to-defined flag" am: e2025abe96 am: 353bdb292f
am: 127d96dd4f

Change-Id: I6412a9832fced1bd8517b26ebc83f3fbcf1e0788
2018-12-11 19:03:09 -08:00
Yi Kong
127d96dd4f Merge "Remove unneeded -Wno-expansion-to-defined flag" am: e2025abe96
am: 353bdb292f

Change-Id: I80c01c4875530e7b93bc51b4af5b527f040f9ed0
2018-12-11 18:57:01 -08:00
Yi Kong
353bdb292f Merge "Remove unneeded -Wno-expansion-to-defined flag"
am: e2025abe96

Change-Id: If7726e9e4b70134c9551dd36d54bdd14baefcc2d
2018-12-11 18:51:52 -08:00
Yi Kong
e2025abe96 Merge "Remove unneeded -Wno-expansion-to-defined flag" 2018-12-12 02:27:48 +00:00
Jiyong Park
127d56580d Don't install stubs
Stubs libs are build-time only artifact. Can't be installed.

Test: OUT_DIR=out build/soong/scripts/build-ndk-prebuilts.sh
with https://android-review.googlesource.com/c/platform/frameworks/av/+/846770/7
and two more CLs in the same chain
Examine out/soong/build.ninja
Build rule for out/soong/target/product/generic_arm64/system/lib64/arm64/libmediandk.so
exist only once.

Change-Id: I58ff09ef3fbbdbd2d968aa21b87a493192d4216d
2018-12-12 10:41:55 +09:00
Chih-hung Hsieh
6fc7d08913 Merge "Disable cert-dcl16-c clang-tidy check for mingw32." am: d340852732 am: baeab573a1
am: 418ff7b331

Change-Id: I0291538a48f2dcd38ec3440173fbc7b6b2c00434
2018-12-11 09:58:52 -08:00
Chih-hung Hsieh
418ff7b331 Merge "Disable cert-dcl16-c clang-tidy check for mingw32." am: d340852732
am: baeab573a1

Change-Id: I8e17caa06e137f3d0179ea0ec0ab4bc84a7edfc5
2018-12-11 09:54:50 -08:00
Chih-hung Hsieh
baeab573a1 Merge "Disable cert-dcl16-c clang-tidy check for mingw32."
am: d340852732

Change-Id: I4ebd440971b10de101cbe8a1db8b088ff6e1ef82
2018-12-11 09:50:46 -08:00
Chih-hung Hsieh
d340852732 Merge "Disable cert-dcl16-c clang-tidy check for mingw32." 2018-12-11 17:41:38 +00:00
Jiyong Park
01f2e9607f Disable cfi and stl for stubs libraries am: 090d9df206 am: 84d1d27efe
am: 280d73aec0

Change-Id: Ia071dd808e3fa936184d362cd3f3f74228e34ffa
2018-12-11 09:30:38 -08:00
Jiyong Park
280d73aec0 Disable cfi and stl for stubs libraries am: 090d9df206
am: 84d1d27efe

Change-Id: I1d1da2c99dfe4b2fca9d2df23072c596113ee7cb
2018-12-11 09:26:35 -08:00
Jiyong Park
84d1d27efe Disable cfi and stl for stubs libraries
am: 090d9df206

Change-Id: Ifdf9fb0a066a8a9b320aaa6054e25b5d2327f997
2018-12-11 09:22:33 -08:00
Jiyong Park
090d9df206 Disable cfi and stl for stubs libraries
Stubs libs are not built with dependencies required for cfi and stl.
Also it does not make much sense to build stubs with cfi and stl because
the libs are not for runtime and there is no C++ symbols.

Test: cherry-pick ag/5747464 and m
Change-Id: I83d6d82513a77a6a8a345e7d12707940c2c906c7
2018-12-11 19:43:56 +09:00
Chih-Hung Hsieh
327b6f0c69 Disable cert-dcl16-c clang-tidy check for mingw32.
Bug: 120614316
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,cert-*
Change-Id: Ibe46409543eaa4a7f3b710d9742b3252dc9ac7e8
2018-12-10 16:28:56 -08:00
Yi Kong
4603b9f411 Remove unneeded -Wno-expansion-to-defined flag
Test: m checkbuild
Bug: 29823425
Change-Id: I8c9c7cc92757af20d3a3bbcebeb6360d1df91530
2018-12-10 04:55:51 -08:00