Commit Graph

7613 Commits

Author SHA1 Message Date
Vinh Tran
1c11c61897 Temporarily disable swcodec in mixed bulid
When aconfig (rust_binary) becomes a transitive dependency of swcodec, mixed build swcodec breaks because the cargo_build_script rust rule declares a directory which is not handled by mixed build yet. See b/307389608 for more context.

A follow-up CL will fix the issue and allow enabling swcodec in mixed build again.

Bug: 307389608
Test: Presubmit
Change-Id: I7ba7b5cd06b231f4867870fe8d0bd53299528fe3
2023-10-25 10:52:41 -04:00
Harish Mahendrakar
5c98a68ed6 Allowlist libcodec2_soft_av1dec_dav1d
Bug: 289716589
Test: builds

Change-Id: Iee45b8fff6aea3fcf31fc1ea718911f54d42362c
2023-10-24 18:31:09 +00:00
Sebastian Pickl
2e196473d0 Revert "Default from-text stub generation in build"
This reverts commit 182b56b870.

Reason for revert: breaking boot tests b/307495247, b/307411752

Bug:307495247
(cherry picked from https://android-review.googlesource.com/q/commit:1c4188c9da7b55cdae967e2d2a0a3c9a51c0ad9f)
Merged-In: Iea05703b767d2699ca3cf69377eb44b1d21697ad
Change-Id: Iea05703b767d2699ca3cf69377eb44b1d21697ad
2023-10-24 12:46:36 +00:00
Anton Hansson
05eabd9c4d Merge "Created empty framework-location non-updatable module" into main 2023-10-24 12:43:36 +00:00
Sebastian Pickl
479ab86e6b Merge "Revert "Default from-text stub generation in build"" into main 2023-10-24 12:43:24 +00:00
Sebastian Pickl
1c4188c9da Revert "Default from-text stub generation in build"
This reverts commit 182b56b870.

Reason for revert: prime suspect for breaking boot tests b/307495247, b/307411752

Bug:307495247
Change-Id: Iea05703b767d2699ca3cf69377eb44b1d21697ad
2023-10-24 11:20:06 +00:00
Anton Hansson
af1c929943 Merge "SdkTestCore for non-updatable modules" into main 2023-10-24 10:06:54 +00:00
Jihoon Kang
58c55df235 Merge "Default from-text stub generation in build" into main am: 82f0f7eca1 am: 7e27c69da1 am: 3efc4ce811
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2617457

Change-Id: I3c1245e95bb785dcd118023632d48eeb202600a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 22:42:51 +00:00
Jihoon Kang
82f0f7eca1 Merge "Default from-text stub generation in build" into main 2023-10-23 21:42:50 +00:00
Mark White
9421c4ceb9 SdkTestCore for non-updatable modules
Provides SdkTestCore/test_core_current sdk_version for non-updatable
modules that have their test scope dependent on test apis from
framework-minus-apex.

Ignore-AOSP-First: Change in topic with internal-first projects
Bug: 289776578
Test: m checkapi | go test ./java

Merged-In: Iba3213e8c34ea75ac9dd8532a95ef62fb5455e6c
Change-Id: Iba3213e8c34ea75ac9dd8532a95ef62fb5455e6c
2023-10-23 15:25:55 +00:00
Jihoon Kang
4275458352 Merge "Modify the product variable Build_from_text_stub value" into main am: e8f21ac529 am: 6f2a1fe31e am: 1ee4f84795
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2797656

Change-Id: Ieb94c90c7fe3944a9bc7c24a1f20f7cb9c5f7059
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-21 02:40:28 +00:00
Jihoon Kang
e8f21ac529 Merge "Modify the product variable Build_from_text_stub value" into main 2023-10-21 01:45:07 +00:00
Jihoon Kang
182b56b870 Default from-text stub generation in build
This change defaults Java stubs to be generated from API text files
during build. Using the `--build-from-source-stubs` flag, users can
toggle between the feature.

Test: m nothing && verify ninja path exists between android_stubs_current and android_stubs_current.from-text, and does not exist between android_stubs_current.from-source, m nothing --build-from-source-stub && verify the opposite
Bug: 274805756
Change-Id: I28834f92c1b1311e3fe0a71a6ea9e8ec2e278d7e
2023-10-20 23:11:19 +00:00
Cole Faust
6b8c283c7b Merge "Load a list of plugins from vendor/google_clockwork" into main am: c9ef6f71cf am: 3c5a1e9bab am: fc4e739708
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2798384

Change-Id: I978d32319cd4c1c9d01b1bff7880e48a7a866080
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 23:11:09 +00:00
Jihoon Kang
531a416d6a Modify the product variable Build_from_text_stub value
productVariables.Build_from_test_stub is currently being set by the
config.buildFromTextStub value. However, this leads to divergence in the
behaviors between the exported BuildFromTextStub() value and the config
value, as the former depends on other factor (whether is it a coverage
build). This change fixes the divergence by making the product variable
value to be set by the former.

Test: m nothing
Bug: 301522358
Change-Id: Ic4de5a179dd1094eb8788663e4d6afa4bea724ea
2023-10-20 22:58:25 +00:00
Cole Faust
c9ef6f71cf Merge "Load a list of plugins from vendor/google_clockwork" into main 2023-10-20 22:00:16 +00:00
Vinh Tran
f132f795a1 Merge "Allowlist librustc_demangle_static" into main am: 4193286396 am: 5a0225f756 am: ddab96a339
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2794696

Change-Id: Ic03fbfe8bb65e4267fa564d7af7eea5e8be82286
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 19:14:54 +00:00
Cole Faust
97e19031c2 Load a list of plugins from vendor/google_clockwork
Some wear partners have vendor/google_clockwork but not vendor/google.

Bug: 290816499
Test: Presubmits
Change-Id: Id45f68bf6f734acc1ee6abbfd2314d9ff6be75fb
2023-10-20 11:54:16 -07:00
Vinh Tran
4193286396 Merge "Allowlist librustc_demangle_static" into main 2023-10-20 18:17:53 +00:00
Jihoon Kang
cdc24a672d Merge "Disable from-text stub build for coverage build" into main am: 04803d4767 am: 89c8d9012c am: eda9671faf
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2789434

Change-Id: I15508f6af1f094d1be5073c62ed7a97b93e826a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 00:09:54 +00:00
Cole Faust
529e0924b2 Merge "Add bazel-built modules as deps on the system image" into main am: b2435a464d am: d3b6d25112 am: e26341d929
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2791479

Change-Id: I241199eb77b004a136b0a08bdef7dbd643e38fa2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 00:09:29 +00:00
Jihoon Kang
04803d4767 Merge "Disable from-text stub build for coverage build" into main 2023-10-19 19:22:33 +00:00
Cole Faust
b2435a464d Merge "Add bazel-built modules as deps on the system image" into main 2023-10-19 18:04:08 +00:00
Vinh Tran
877df697cc Allowlist librustc_demangle_static
Test: b build
//external/rust/crates/rustc-demangle-capi:librustc_demangle_static
--config=android
Test: b build //external/rust/crates/rustc-demangle-capi:librustc_demangle_static
Bug:  297395183

Change-Id: I1ce220af8ef89001d4ffd608ee1bad27b8011538
2023-10-19 11:27:04 -04:00
Treehugger Robot
cf62fb008e Merge "Allowlist transitive deps of libnetworkstats" into main am: 786c44f9f3 am: 84b5c8b496 am: 38480df627
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2775984

Change-Id: Ib6d83aeca77ded4d4809a7959ae4a8853a64e2ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-19 09:19:59 +00:00
Treehugger Robot
786c44f9f3 Merge "Allowlist transitive deps of libnetworkstats" into main 2023-10-19 07:20:12 +00:00
Cole Faust
b251515ac8 Merge "gofmt soong" into main am: 14c1ed8d7d am: 2cc9eea91d am: f2d3e5b72b
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2797038

Change-Id: Ibfff520b15692a58c911d6290f5674d74571d716
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-19 05:27:04 +00:00
Cole Faust
14c1ed8d7d Merge "gofmt soong" into main 2023-10-19 03:48:45 +00:00
Cole Faust
06ea531ab3 gofmt soong
Test: Presubmits
Change-Id: Ia76c35ba51685eca29df51738000eacd3f43ce20
2023-10-18 17:42:59 -07:00
Chris Parsons
8a226e6cd4 Allowlist fs_msg by package am: c52eb1ce37 am: 53146465e9 am: 2d98658369
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2796832

Change-Id: If22a6a9de1b35bd201eb3fef0ade47000d5f8333
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-18 23:23:33 +00:00
Cole Faust
11edf557b6 Add bazel-built modules as deps on the system image
These bazel-built modules will be installed into the system image
as part of the bazel rule, rather than going through the make staging
directory.

Bug: 297269187
Test: m bazel_sandwich
Change-Id: I96c6e58f8e0898b2ad92cb7069745ca2059a39f8
2023-10-18 15:21:14 -07:00
Chris Parsons
c52eb1ce37 Allowlist fs_msg by package
Fixes a build breakage that had a new fs_msg-pkg dependency added. This
would either have to be allowlisted by name, or we'd have to allowlist
the whole package.

Allowlisting the whole package is safer with allowlist v2.

Test: Presubmits
Change-Id: Id3b5c39c60519e966b53ec4fa228c3a79e68fa7a
2023-10-18 19:25:51 +00:00
Treehugger Robot
0e2e5d1123 Merge "Remove a number of entries from module denylist" into main am: 6b4fb160ea am: aca5269148 am: 48b4386bab
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2788172

Change-Id: I9ee36d1d65a7bff844b8cf2f53d11aef84ce3d99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-18 19:15:56 +00:00
Spandan Das
6d463cf3e0 Allowlist transitive deps of libnetworkstats
This is a jni lib of FrameworksNetTests

Bug: 297405814
Test: b build $(bmod libnetworkstats) --config=android
Change-Id: Ic5b39615c7c9f193c034d1bc5d92ed9153bb7360
2023-10-18 18:04:08 +00:00
Usta (Tsering) Shrestha
3800475a9e Merge "Remove unsued mutator registration" into main am: d7471ec5cc am: a8097a501a am: d90f0377d1
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2794672

Change-Id: Ie755cae378b236629e1243145e801b2a3419a844
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-18 17:46:01 +00:00
Treehugger Robot
6b4fb160ea Merge "Remove a number of entries from module denylist" into main 2023-10-18 17:16:02 +00:00
Liz Kammer
d3549fcb10 Merge changes Iceb0b68f,I04865414 into main am: a855f73f4a am: 9c845e2cf0 am: 5eb30c456f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2789776

Change-Id: I6c0d0c38379d48cd166ef34857098bee7bd47d8f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-18 16:00:52 +00:00
Usta (Tsering) Shrestha
d7471ec5cc Merge "Remove unsued mutator registration" into main 2023-10-18 15:33:30 +00:00
Liz Kammer
a855f73f4a Merge changes Iceb0b68f,I04865414 into main
* changes:
  Improve error message readability
  Share constants for droidstubs btw Soong & Bazel
2023-10-18 14:19:30 +00:00
Vinh Tran
cee8b329e1 Merge "Allowlist rustc-demangle crate" into main am: c6d992e483 am: bbde9b6c6b am: abc9b26c3c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2768331

Change-Id: I15b06d91a44215c6e1b84eafcd67c918b33a1b52
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-18 02:02:15 +00:00
Jihoon Kang
1975d3e326 Disable from-text stub build for coverage build
Coverage builds depend on `native` properties for API elements, which
are not included in the API signature files and consequently in
from-text stubs. As no robust solution for handling this has been
planned out at the moment, from-text stub build is disabled for
coverage builds.

Per go/android-code-coverage-quickstart , Java code coverage is
enabled by the three environment variables: `EMMA_INSTRUMENT`,
`EMMA_INSTRUMENT_STAIC` and `EMMA_INSTRUMENT_FRAMEWORK`. This change
disables from-text stub build if any of the three variables are set
to true.

Test: go test ./java && m EMMA_INSTRUMENT=true EMMA_INSTRUMENT_FRAMEWORK=true nothing --build-from-text-stub and inspect ninja query to verify that the stub java library module depends on the from-source stub module
Bug: 304271961
Change-Id: Ie485c784145de6c253611e698354c4f9e4a30685
2023-10-17 20:00:12 +00:00
Cole Faust
d607f94a49 Merge "Remove baseModuleContext.debug" into main am: 03787bea6d am: 6714a42739 am: b231ce9af7
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2791447

Change-Id: I58f10f22a9411a3593aa9d0d2b734c285c143297
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-17 19:25:09 +00:00
Usta (Tsering) Shrestha
543f8407ef Remove unsued mutator registration
Bug: 179313531
Change-Id: Ide9fc0a9e1275bb6303c8a3114ce1c4e98915f75
Test: m nothing
2023-10-17 19:20:55 +00:00
Vinh Tran
89d2bbf188 Allowlist rustc-demangle crate
Test: b build //external/rust/crates/rustc-demangle
Test: b build //external/rust/crates/rustc-demangle --config=android
Bug: 297395183
Change-Id: I715377b4bdc296d9676beb0405cc0d544c7d96e9
2023-10-17 13:59:05 -04:00
Liz Kammer
ba5f32a2f9 Improve error message readability
Test: n/a
Change-Id: Iceb0b68f4b83e2b43c0947885c514252a6de30c1
2023-10-17 09:10:13 -04:00
Treehugger Robot
665ee94403 Merge "Remove makePathForInstall" into main am: 60f72ffaa7 am: ca064c934b am: ba75c65018
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2789952

Change-Id: I7f53dc9271dc207c876370c568dbddf794a02b78
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-17 01:18:18 +00:00
Cole Faust
3b703f3c02 Remove baseModuleContext.debug
It was never set to true.

Test: Presubmits
Change-Id: I9944d90b7e75beb4a7fe259c72bc7a82e42f593d
2023-10-16 14:20:00 -07:00
Cole Faust
7b4de4b859 Remove makePathForInstall
Test: Presubmits
Change-Id: I6e66af05ac578b98e212bcddcecaff6ce93e5cd5
2023-10-16 13:02:47 -07:00
Chris Parsons
efaa09b62e Remove a number of entries from module denylist
The entries removed from this list are mostly still unconverted because
of missing deps (they are automatically marked unconvertible because of
missing deps). The remainder are actually generated by bp2build as a
result of this change. These cases are for tests that build but don't
pass successfully. We thus simultaneously make a change refining
bp2build.sh. (See topic)

Test: bp2build.sh
Test: m nothing
Test: manual vetting of a number of modules via before/after
analyze_build

Change-Id: Ie9f2c11939258eb3e70ca1e385fe99a3cc4ce93a
2023-10-16 15:44:18 +00:00
Jingwen Chen
1286b8e4cf Allowlist //system/linkerconfig am: aea8ba3534 am: 9bffe77269 am: f881704307 am: 007400e98e am: 3606a22e7d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2786164

Change-Id: Ib028f7276848951436bd2bb8f7a6da4e94151599
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-16 09:26:27 +00:00