// Copyright 2021 Google Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package bp2build import ( "android/soong/android" "android/soong/cc" "android/soong/genrule" "testing" ) const ( // See cc/testing.go for more context soongCcLibraryStaticPreamble = ` cc_defaults { name: "linux_bionic_supported", } toolchain_library { name: "libclang_rt.builtins-x86_64-android", defaults: ["linux_bionic_supported"], vendor_available: true, vendor_ramdisk_available: true, product_available: true, recovery_available: true, native_bridge_supported: true, src: "", }` ) func TestCcLibraryStaticLoadStatement(t *testing.T) { testCases := []struct { bazelTargets BazelTargets expectedLoadStatements string }{ { bazelTargets: BazelTargets{ BazelTarget{ name: "cc_library_static_target", ruleClass: "cc_library_static", // NOTE: No bzlLoadLocation for native rules }, }, expectedLoadStatements: ``, }, } for _, testCase := range testCases { actual := testCase.bazelTargets.LoadStatements() expected := testCase.expectedLoadStatements if actual != expected { t.Fatalf("Expected load statements to be %s, got %s", expected, actual) } } } func registerCcLibraryStaticModuleTypes(ctx android.RegistrationContext) { cc.RegisterCCBuildComponents(ctx) ctx.RegisterModuleType("toolchain_library", cc.ToolchainLibraryFactory) ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory) ctx.RegisterModuleType("genrule", genrule.GenRuleFactory) // Required for system_shared_libs dependencies. ctx.RegisterModuleType("cc_library", cc.LibraryFactory) } func runCcLibraryStaticTestCase(t *testing.T, tc bp2buildTestCase) { t.Helper() runBp2BuildTestCase(t, registerCcLibraryStaticModuleTypes, tc) } func TestCcLibraryStaticSimple(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static test", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ // NOTE: include_dir headers *should not* appear in Bazel hdrs later (?) "include_dir_1/include_dir_1_a.h": "", "include_dir_1/include_dir_1_b.h": "", "include_dir_2/include_dir_2_a.h": "", "include_dir_2/include_dir_2_b.h": "", // NOTE: local_include_dir headers *should not* appear in Bazel hdrs later (?) "local_include_dir_1/local_include_dir_1_a.h": "", "local_include_dir_1/local_include_dir_1_b.h": "", "local_include_dir_2/local_include_dir_2_a.h": "", "local_include_dir_2/local_include_dir_2_b.h": "", // NOTE: export_include_dir headers *should* appear in Bazel hdrs later "export_include_dir_1/export_include_dir_1_a.h": "", "export_include_dir_1/export_include_dir_1_b.h": "", "export_include_dir_2/export_include_dir_2_a.h": "", "export_include_dir_2/export_include_dir_2_b.h": "", // NOTE: Soong implicitly includes headers in the current directory "implicit_include_1.h": "", "implicit_include_2.h": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_headers { name: "header_lib_1", export_include_dirs: ["header_lib_1"], bazel_module: { bp2build_available: false }, } cc_library_headers { name: "header_lib_2", export_include_dirs: ["header_lib_2"], bazel_module: { bp2build_available: false }, } cc_library_static { name: "static_lib_1", srcs: ["static_lib_1.cc"], bazel_module: { bp2build_available: false }, } cc_library_static { name: "static_lib_2", srcs: ["static_lib_2.cc"], bazel_module: { bp2build_available: false }, } cc_library_static { name: "whole_static_lib_1", srcs: ["whole_static_lib_1.cc"], bazel_module: { bp2build_available: false }, } cc_library_static { name: "whole_static_lib_2", srcs: ["whole_static_lib_2.cc"], bazel_module: { bp2build_available: false }, } cc_library_static { name: "foo_static", srcs: [ "foo_static1.cc", "foo_static2.cc", ], cflags: [ "-Dflag1", "-Dflag2" ], static_libs: [ "static_lib_1", "static_lib_2" ], whole_static_libs: [ "whole_static_lib_1", "whole_static_lib_2" ], include_dirs: [ "include_dir_1", "include_dir_2", ], local_include_dirs: [ "local_include_dir_1", "local_include_dir_2", ], export_include_dirs: [ "export_include_dir_1", "export_include_dir_2" ], header_libs: [ "header_lib_1", "header_lib_2" ], // TODO: Also support export_header_lib_headers }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", absolute_includes = [ "include_dir_1", "include_dir_2", ], copts = [ "-Dflag1", "-Dflag2", ], export_includes = [ "export_include_dir_1", "export_include_dir_2", ], implementation_deps = [ ":header_lib_1", ":header_lib_2", ":static_lib_1", ":static_lib_2", ], local_includes = [ "local_include_dir_1", "local_include_dir_2", ".", ], srcs = [ "foo_static1.cc", "foo_static2.cc", ], whole_archive_deps = [ ":whole_static_lib_1", ":whole_static_lib_2", ], )`}, }) } func TestCcLibraryStaticSubpackage(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static subpackage test", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ // subpackage with subdirectory "subpackage/Android.bp": "", "subpackage/subpackage_header.h": "", "subpackage/subdirectory/subdirectory_header.h": "", // subsubpackage with subdirectory "subpackage/subsubpackage/Android.bp": "", "subpackage/subsubpackage/subsubpackage_header.h": "", "subpackage/subsubpackage/subdirectory/subdirectory_header.h": "", // subsubsubpackage with subdirectory "subpackage/subsubpackage/subsubsubpackage/Android.bp": "", "subpackage/subsubpackage/subsubsubpackage/subsubsubpackage_header.h": "", "subpackage/subsubpackage/subsubsubpackage/subdirectory/subdirectory_header.h": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: [], include_dirs: [ "subpackage", ], }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", absolute_includes = ["subpackage"], local_includes = ["."], )`}, }) } func TestCcLibraryStaticExportIncludeDir(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static export include dir", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ // subpackage with subdirectory "subpackage/Android.bp": "", "subpackage/subpackage_header.h": "", "subpackage/subdirectory/subdirectory_header.h": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", export_include_dirs: ["subpackage"], include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", export_includes = ["subpackage"], )`}, }) } func TestCcLibraryStaticExportSystemIncludeDir(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static export system include dir", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ // subpackage with subdirectory "subpackage/Android.bp": "", "subpackage/subpackage_header.h": "", "subpackage/subdirectory/subdirectory_header.h": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", export_system_include_dirs: ["subpackage"], include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", export_system_includes = ["subpackage"], )`}, }) } func TestCcLibraryStaticManyIncludeDirs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static include_dirs, local_include_dirs, export_include_dirs (b/183742505)", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, dir: "subpackage", filesystem: map[string]string{ // subpackage with subdirectory "subpackage/Android.bp": ` cc_library_static { name: "foo_static", // include_dirs are workspace/root relative include_dirs: [ "subpackage/subsubpackage", "subpackage2", "subpackage3/subsubpackage" ], local_include_dirs: ["subsubpackage2"], // module dir relative export_include_dirs: ["./exported_subsubpackage"], // module dir relative include_build_directory: true, bazel_module: { bp2build_available: true }, }`, "subpackage/subsubpackage/header.h": "", "subpackage/subsubpackage2/header.h": "", "subpackage/exported_subsubpackage/header.h": "", "subpackage2/header.h": "", "subpackage3/subsubpackage/header.h": "", }, blueprint: soongCcLibraryStaticPreamble, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", absolute_includes = [ "subpackage/subsubpackage", "subpackage2", "subpackage3/subsubpackage", ], export_includes = ["./exported_subsubpackage"], local_includes = [ "subsubpackage2", ".", ], )`}, }) } func TestCcLibraryStaticIncludeBuildDirectoryDisabled(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static include_build_directory disabled", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ // subpackage with subdirectory "subpackage/Android.bp": "", "subpackage/subpackage_header.h": "", "subpackage/subdirectory/subdirectory_header.h": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", include_dirs: ["subpackage"], // still used, but local_include_dirs is recommended local_include_dirs: ["subpackage2"], include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", absolute_includes = ["subpackage"], local_includes = ["subpackage2"], )`}, }) } func TestCcLibraryStaticIncludeBuildDirectoryEnabled(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static include_build_directory enabled", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ // subpackage with subdirectory "subpackage/Android.bp": "", "subpackage/subpackage_header.h": "", "subpackage2/Android.bp": "", "subpackage2/subpackage2_header.h": "", "subpackage/subdirectory/subdirectory_header.h": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", include_dirs: ["subpackage"], // still used, but local_include_dirs is recommended local_include_dirs: ["subpackage2"], include_build_directory: true, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", absolute_includes = ["subpackage"], local_includes = [ "subpackage2", ".", ], )`}, }) } func TestCcLibraryStaticArchSpecificStaticLib(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static arch-specific static_libs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{}, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "static_dep", bazel_module: { bp2build_available: false }, } cc_library_static { name: "static_dep2", bazel_module: { bp2build_available: false }, } cc_library_static { name: "foo_static", arch: { arm64: { static_libs: ["static_dep"], whole_static_libs: ["static_dep2"] } }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", implementation_deps = select({ "//build/bazel/platforms/arch:arm64": [":static_dep"], "//conditions:default": [], }), whole_archive_deps = select({ "//build/bazel/platforms/arch:arm64": [":static_dep2"], "//conditions:default": [], }), )`}, }) } func TestCcLibraryStaticOsSpecificStaticLib(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static os-specific static_libs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{}, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "static_dep", bazel_module: { bp2build_available: false }, } cc_library_static { name: "static_dep2", bazel_module: { bp2build_available: false }, } cc_library_static { name: "foo_static", target: { android: { static_libs: ["static_dep"], whole_static_libs: ["static_dep2"] } }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", implementation_deps = select({ "//build/bazel/platforms/os:android": [":static_dep"], "//conditions:default": [], }), whole_archive_deps = select({ "//build/bazel/platforms/os:android": [":static_dep2"], "//conditions:default": [], }), )`}, }) } func TestCcLibraryStaticBaseArchOsSpecificStaticLib(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static base, arch and os-specific static_libs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{}, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "static_dep", bazel_module: { bp2build_available: false }, } cc_library_static { name: "static_dep2", bazel_module: { bp2build_available: false }, } cc_library_static { name: "static_dep3", bazel_module: { bp2build_available: false }, } cc_library_static { name: "static_dep4", bazel_module: { bp2build_available: false }, } cc_library_static { name: "foo_static", static_libs: ["static_dep"], whole_static_libs: ["static_dep2"], target: { android: { static_libs: ["static_dep3"] } }, arch: { arm64: { static_libs: ["static_dep4"] } }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", implementation_deps = [":static_dep"] + select({ "//build/bazel/platforms/arch:arm64": [":static_dep4"], "//conditions:default": [], }) + select({ "//build/bazel/platforms/os:android": [":static_dep3"], "//conditions:default": [], }), whole_archive_deps = [":static_dep2"], )`}, }) } func TestCcLibraryStaticSimpleExcludeSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static simple exclude_srcs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "foo-a.c": "", "foo-excluded.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c", "foo-*.c"], exclude_srcs: ["foo-excluded.c"], include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs_c = [ "common.c", "foo-a.c", ], )`}, }) } func TestCcLibraryStaticOneArchSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static one arch specific srcs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "foo-arm.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c"], arch: { arm: { srcs: ["foo-arm.c"] } }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs_c = ["common.c"] + select({ "//build/bazel/platforms/arch:arm": ["foo-arm.c"], "//conditions:default": [], }), )`}, }) } func TestCcLibraryStaticOneArchSrcsExcludeSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static one arch specific srcs and exclude_srcs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "for-arm.c": "", "not-for-arm.c": "", "not-for-anything.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c", "not-for-*.c"], exclude_srcs: ["not-for-anything.c"], arch: { arm: { srcs: ["for-arm.c"], exclude_srcs: ["not-for-arm.c"] }, }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs_c = ["common.c"] + select({ "//build/bazel/platforms/arch:arm": ["for-arm.c"], "//conditions:default": ["not-for-arm.c"], }), )`}, }) } func TestCcLibraryStaticTwoArchExcludeSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static arch specific exclude_srcs for 2 architectures", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "for-arm.c": "", "for-x86.c": "", "not-for-arm.c": "", "not-for-x86.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c", "not-for-*.c"], exclude_srcs: ["not-for-everything.c"], arch: { arm: { srcs: ["for-arm.c"], exclude_srcs: ["not-for-arm.c"] }, x86: { srcs: ["for-x86.c"], exclude_srcs: ["not-for-x86.c"] }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs_c = ["common.c"] + select({ "//build/bazel/platforms/arch:arm": [ "for-arm.c", "not-for-x86.c", ], "//build/bazel/platforms/arch:x86": [ "for-x86.c", "not-for-arm.c", ], "//conditions:default": [ "not-for-arm.c", "not-for-x86.c", ], }), )`}, }) } func TestCcLibraryStaticFourArchExcludeSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static arch specific exclude_srcs for 4 architectures", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "for-arm.c": "", "for-arm64.c": "", "for-x86.c": "", "for-x86_64.c": "", "not-for-arm.c": "", "not-for-arm64.c": "", "not-for-x86.c": "", "not-for-x86_64.c": "", "not-for-everything.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c", "not-for-*.c"], exclude_srcs: ["not-for-everything.c"], arch: { arm: { srcs: ["for-arm.c"], exclude_srcs: ["not-for-arm.c"] }, arm64: { srcs: ["for-arm64.c"], exclude_srcs: ["not-for-arm64.c"] }, x86: { srcs: ["for-x86.c"], exclude_srcs: ["not-for-x86.c"] }, x86_64: { srcs: ["for-x86_64.c"], exclude_srcs: ["not-for-x86_64.c"] }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs_c = ["common.c"] + select({ "//build/bazel/platforms/arch:arm": [ "for-arm.c", "not-for-arm64.c", "not-for-x86.c", "not-for-x86_64.c", ], "//build/bazel/platforms/arch:arm64": [ "for-arm64.c", "not-for-arm.c", "not-for-x86.c", "not-for-x86_64.c", ], "//build/bazel/platforms/arch:x86": [ "for-x86.c", "not-for-arm.c", "not-for-arm64.c", "not-for-x86_64.c", ], "//build/bazel/platforms/arch:x86_64": [ "for-x86_64.c", "not-for-arm.c", "not-for-arm64.c", "not-for-x86.c", ], "//conditions:default": [ "not-for-arm.c", "not-for-arm64.c", "not-for-x86.c", "not-for-x86_64.c", ], }), )`}, }) } func TestCcLibraryStaticOneArchEmpty(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static one arch empty", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.cc": "", "foo-no-arm.cc": "", "foo-excluded.cc": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.cc", "foo-*.cc"], exclude_srcs: ["foo-excluded.cc"], arch: { arm: { exclude_srcs: ["foo-no-arm.cc"] }, }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs = ["common.cc"] + select({ "//build/bazel/platforms/arch:arm": [], "//conditions:default": ["foo-no-arm.cc"], }), )`}, }) } func TestCcLibraryStaticOneArchEmptyOtherSet(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static one arch empty other set", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.cc": "", "foo-no-arm.cc": "", "x86-only.cc": "", "foo-excluded.cc": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.cc", "foo-*.cc"], exclude_srcs: ["foo-excluded.cc"], arch: { arm: { exclude_srcs: ["foo-no-arm.cc"] }, x86: { srcs: ["x86-only.cc"] }, }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs = ["common.cc"] + select({ "//build/bazel/platforms/arch:arm": [], "//build/bazel/platforms/arch:x86": [ "foo-no-arm.cc", "x86-only.cc", ], "//conditions:default": ["foo-no-arm.cc"], }), )`}, }) } func TestCcLibraryStaticMultipleDepSameName(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static multiple dep same name panic", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{}, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "static_dep", bazel_module: { bp2build_available: false }, } cc_library_static { name: "foo_static", static_libs: ["static_dep", "static_dep"], include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", implementation_deps = [":static_dep"], )`}, }) } func TestCcLibraryStaticOneMultilibSrcsExcludeSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static 1 multilib srcs and exclude_srcs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "for-lib32.c": "", "not-for-lib32.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c", "not-for-*.c"], multilib: { lib32: { srcs: ["for-lib32.c"], exclude_srcs: ["not-for-lib32.c"] }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs_c = ["common.c"] + select({ "//build/bazel/platforms/arch:arm": ["for-lib32.c"], "//build/bazel/platforms/arch:x86": ["for-lib32.c"], "//conditions:default": ["not-for-lib32.c"], }), )`}, }) } func TestCcLibraryStaticTwoMultilibSrcsExcludeSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static 2 multilib srcs and exclude_srcs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "for-lib32.c": "", "for-lib64.c": "", "not-for-lib32.c": "", "not-for-lib64.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static2", srcs: ["common.c", "not-for-*.c"], multilib: { lib32: { srcs: ["for-lib32.c"], exclude_srcs: ["not-for-lib32.c"] }, lib64: { srcs: ["for-lib64.c"], exclude_srcs: ["not-for-lib64.c"] }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static2", srcs_c = ["common.c"] + select({ "//build/bazel/platforms/arch:arm": [ "for-lib32.c", "not-for-lib64.c", ], "//build/bazel/platforms/arch:arm64": [ "for-lib64.c", "not-for-lib32.c", ], "//build/bazel/platforms/arch:x86": [ "for-lib32.c", "not-for-lib64.c", ], "//build/bazel/platforms/arch:x86_64": [ "for-lib64.c", "not-for-lib32.c", ], "//conditions:default": [ "not-for-lib32.c", "not-for-lib64.c", ], }), )`}, }) } func TestCcLibrarySTaticArchMultilibSrcsExcludeSrcs(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static arch and multilib srcs and exclude_srcs", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.c": "", "for-arm.c": "", "for-arm64.c": "", "for-x86.c": "", "for-x86_64.c": "", "for-lib32.c": "", "for-lib64.c": "", "not-for-arm.c": "", "not-for-arm64.c": "", "not-for-x86.c": "", "not-for-x86_64.c": "", "not-for-lib32.c": "", "not-for-lib64.c": "", "not-for-everything.c": "", }, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static3", srcs: ["common.c", "not-for-*.c"], exclude_srcs: ["not-for-everything.c"], arch: { arm: { srcs: ["for-arm.c"], exclude_srcs: ["not-for-arm.c"] }, arm64: { srcs: ["for-arm64.c"], exclude_srcs: ["not-for-arm64.c"] }, x86: { srcs: ["for-x86.c"], exclude_srcs: ["not-for-x86.c"] }, x86_64: { srcs: ["for-x86_64.c"], exclude_srcs: ["not-for-x86_64.c"] }, }, multilib: { lib32: { srcs: ["for-lib32.c"], exclude_srcs: ["not-for-lib32.c"] }, lib64: { srcs: ["for-lib64.c"], exclude_srcs: ["not-for-lib64.c"] }, }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static3", srcs_c = ["common.c"] + select({ "//build/bazel/platforms/arch:arm": [ "for-arm.c", "for-lib32.c", "not-for-arm64.c", "not-for-lib64.c", "not-for-x86.c", "not-for-x86_64.c", ], "//build/bazel/platforms/arch:arm64": [ "for-arm64.c", "for-lib64.c", "not-for-arm.c", "not-for-lib32.c", "not-for-x86.c", "not-for-x86_64.c", ], "//build/bazel/platforms/arch:x86": [ "for-lib32.c", "for-x86.c", "not-for-arm.c", "not-for-arm64.c", "not-for-lib64.c", "not-for-x86_64.c", ], "//build/bazel/platforms/arch:x86_64": [ "for-lib64.c", "for-x86_64.c", "not-for-arm.c", "not-for-arm64.c", "not-for-lib32.c", "not-for-x86.c", ], "//conditions:default": [ "not-for-arm.c", "not-for-arm64.c", "not-for-lib32.c", "not-for-lib64.c", "not-for-x86.c", "not-for-x86_64.c", ], }), )`}, }) } func TestCcLibraryStaticArchSrcsExcludeSrcsGeneratedFiles(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static arch srcs/exclude_srcs with generated files", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{ "common.cpp": "", "for-x86.cpp": "", "not-for-x86.cpp": "", "not-for-everything.cpp": "", "dep/Android.bp": ` genrule { name: "generated_src_other_pkg", out: ["generated_src_other_pkg.cpp"], cmd: "nothing to see here", } genrule { name: "generated_hdr_other_pkg", out: ["generated_hdr_other_pkg.cpp"], cmd: "nothing to see here", } genrule { name: "generated_hdr_other_pkg_x86", out: ["generated_hdr_other_pkg_x86.cpp"], cmd: "nothing to see here", }`, }, blueprint: soongCcLibraryStaticPreamble + ` genrule { name: "generated_src", out: ["generated_src.cpp"], cmd: "nothing to see here", } genrule { name: "generated_src_x86", out: ["generated_src_x86.cpp"], cmd: "nothing to see here", } genrule { name: "generated_hdr", out: ["generated_hdr.h"], cmd: "nothing to see here", } cc_library_static { name: "foo_static3", srcs: ["common.cpp", "not-for-*.cpp"], exclude_srcs: ["not-for-everything.cpp"], generated_sources: ["generated_src", "generated_src_other_pkg"], generated_headers: ["generated_hdr", "generated_hdr_other_pkg"], arch: { x86: { srcs: ["for-x86.cpp"], exclude_srcs: ["not-for-x86.cpp"], generated_sources: ["generated_src_x86"], generated_headers: ["generated_hdr_other_pkg_x86"], }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static3", srcs = [ "//dep:generated_hdr_other_pkg", "//dep:generated_src_other_pkg", ":generated_hdr", ":generated_src", "common.cpp", ] + select({ "//build/bazel/platforms/arch:x86": [ "//dep:generated_hdr_other_pkg_x86", ":generated_src_x86", "for-x86.cpp", ], "//conditions:default": ["not-for-x86.cpp"], }), )`}, }) } func TestCcLibraryStaticGetTargetProperties(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static complex GetTargetProperties", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", target: { android: { srcs: ["android_src.c"], }, android_arm: { srcs: ["android_arm_src.c"], }, android_arm64: { srcs: ["android_arm64_src.c"], }, android_x86: { srcs: ["android_x86_src.c"], }, android_x86_64: { srcs: ["android_x86_64_src.c"], }, linux_bionic_arm64: { srcs: ["linux_bionic_arm64_src.c"], }, linux_bionic_x86_64: { srcs: ["linux_bionic_x86_64_src.c"], }, }, include_build_directory: false, }`, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", srcs_c = select({ "//build/bazel/platforms/os:android": ["android_src.c"], "//conditions:default": [], }) + select({ "//build/bazel/platforms/os_arch:android_arm": ["android_arm_src.c"], "//build/bazel/platforms/os_arch:android_arm64": ["android_arm64_src.c"], "//build/bazel/platforms/os_arch:android_x86": ["android_x86_src.c"], "//build/bazel/platforms/os_arch:android_x86_64": ["android_x86_64_src.c"], "//build/bazel/platforms/os_arch:linux_bionic_arm64": ["linux_bionic_arm64_src.c"], "//build/bazel/platforms/os_arch:linux_bionic_x86_64": ["linux_bionic_x86_64_src.c"], "//conditions:default": [], }), )`}, }) } func TestCcLibraryStaticProductVariableSelects(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static product variable selects", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c"], product_variables: { malloc_not_svelte: { cflags: ["-Wmalloc_not_svelte"], }, malloc_zero_contents: { cflags: ["-Wmalloc_zero_contents"], }, binder32bit: { cflags: ["-Wbinder32bit"], }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", copts = select({ "//build/bazel/product_variables:binder32bit": ["-Wbinder32bit"], "//conditions:default": [], }) + select({ "//build/bazel/product_variables:malloc_not_svelte": ["-Wmalloc_not_svelte"], "//conditions:default": [], }) + select({ "//build/bazel/product_variables:malloc_zero_contents": ["-Wmalloc_zero_contents"], "//conditions:default": [], }), srcs_c = ["common.c"], )`}, }) } func TestCcLibraryStaticProductVariableArchSpecificSelects(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static arch-specific product variable selects", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{}, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.c"], product_variables: { malloc_not_svelte: { cflags: ["-Wmalloc_not_svelte"], }, }, arch: { arm64: { product_variables: { malloc_not_svelte: { cflags: ["-Warm64_malloc_not_svelte"], }, }, }, }, multilib: { lib32: { product_variables: { malloc_not_svelte: { cflags: ["-Wlib32_malloc_not_svelte"], }, }, }, }, target: { android: { product_variables: { malloc_not_svelte: { cflags: ["-Wandroid_malloc_not_svelte"], }, }, } }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", copts = select({ "//build/bazel/product_variables:malloc_not_svelte": ["-Wmalloc_not_svelte"], "//conditions:default": [], }) + select({ "//build/bazel/product_variables:malloc_not_svelte-android": ["-Wandroid_malloc_not_svelte"], "//conditions:default": [], }) + select({ "//build/bazel/product_variables:malloc_not_svelte-arm": ["-Wlib32_malloc_not_svelte"], "//conditions:default": [], }) + select({ "//build/bazel/product_variables:malloc_not_svelte-arm64": ["-Warm64_malloc_not_svelte"], "//conditions:default": [], }) + select({ "//build/bazel/product_variables:malloc_not_svelte-x86": ["-Wlib32_malloc_not_svelte"], "//conditions:default": [], }), srcs_c = ["common.c"], )`}, }) } func TestCcLibraryStaticProductVariableStringReplacement(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static product variable string replacement", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, filesystem: map[string]string{}, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "foo_static", srcs: ["common.S"], product_variables: { platform_sdk_version: { asflags: ["-DPLATFORM_SDK_VERSION=%d"], }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "foo_static", asflags = select({ "//build/bazel/product_variables:platform_sdk_version": ["-DPLATFORM_SDK_VERSION=$(Platform_sdk_version)"], "//conditions:default": [], }), srcs_as = ["common.S"], )`}, }) } func TestStaticLibrary_SystemSharedLibsRootEmpty(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static system_shared_lib empty root", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "root_empty", system_shared_libs: [], include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "root_empty", system_dynamic_deps = [], )`}, }) } func TestStaticLibrary_SystemSharedLibsStaticEmpty(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static system_shared_lib empty static default", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_defaults { name: "static_empty_defaults", static: { system_shared_libs: [], }, include_build_directory: false, } cc_library_static { name: "static_empty", defaults: ["static_empty_defaults"], } `, expectedBazelTargets: []string{`cc_library_static( name = "static_empty", system_dynamic_deps = [], )`}, }) } func TestStaticLibrary_SystemSharedLibsBionicEmpty(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static system_shared_lib empty for bionic variant", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "target_bionic_empty", target: { bionic: { system_shared_libs: [], }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "target_bionic_empty", system_dynamic_deps = [], )`}, }) } func TestStaticLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) { // Note that this behavior is technically incorrect (it's a simplification). // The correct behavior would be if bp2build wrote `system_dynamic_deps = []` // only for linux_bionic, but `android` had `["libc", "libdl", "libm"]. // b/195791252 tracks the fix. runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static system_shared_lib empty for linux_bionic variant", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_library_static { name: "target_linux_bionic_empty", target: { linux_bionic: { system_shared_libs: [], }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "target_linux_bionic_empty", system_dynamic_deps = [], )`}, }) } func TestStaticLibrary_SystemSharedLibsBionic(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static system_shared_libs set for bionic variant", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_library{name: "libc"} cc_library_static { name: "target_bionic", target: { bionic: { system_shared_libs: ["libc"], }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "target_bionic", system_dynamic_deps = select({ "//build/bazel/platforms/os:android": [":libc"], "//build/bazel/platforms/os:linux_bionic": [":libc"], "//conditions:default": [], }), )`}, }) } func TestStaticLibrary_SystemSharedLibsLinuxRootAndLinuxBionic(t *testing.T) { runCcLibraryStaticTestCase(t, bp2buildTestCase{ description: "cc_library_static system_shared_libs set for root and linux_bionic variant", moduleTypeUnderTest: "cc_library_static", moduleTypeUnderTestFactory: cc.LibraryStaticFactory, moduleTypeUnderTestBp2BuildMutator: cc.CcLibraryStaticBp2Build, blueprint: soongCcLibraryStaticPreamble + ` cc_library{name: "libc"} cc_library{name: "libm"} cc_library_static { name: "target_linux_bionic", system_shared_libs: ["libc"], target: { linux_bionic: { system_shared_libs: ["libm"], }, }, include_build_directory: false, } `, expectedBazelTargets: []string{`cc_library_static( name = "target_linux_bionic", system_dynamic_deps = [":libc"] + select({ "//build/bazel/platforms/os:linux_bionic": [":libm"], "//conditions:default": [], }), )`}, }) }