If ANDROID_QUIET_BUILD environment variable is set to '1', do not show 20 lines of the environment variables. In addition, for the failing step show only the step name and output, omitting the command proper (the verbose log as well as error.log still contains it). If build succeeds, the output of the build itself consists of a single line: ``` > m androidmk [100% NN/NN] <last command> ``` When it fails, the output does not contain sometimes very long command line: ``` > m androidmk [ 97% NN/MM] test androidmk FAILED: <step> --- FAIL: TestEndToEnd (0.01s) androidmk_test.go:1025: failed testcase 'prebuilt_etc_TARGET_OUT_ETC' input: include $(CLEAR_VARS) LOCAL_MODULE := etc.test1 LOCAL_MODULE_CLASS := ETC LOCAL_MODULE_PATH := $(TARGET_OUT_ETC)/foo/bar include $(BUILD_PREBUILT) expected: prebuilt_etc { name: "etc.test1", filename: "foo/bar", } got: prebuilt_etc { name: "etc.test1", filename: "foo/bar", } FAIL 17:50:53 ninja failed with: exit status 1 ``` [The related change in build/make/envsetup.sh suppresses timing display when the same variable is set.] Change-Id: I4d3c72457de031ff58a324c2fe98f4c1d10f8239 Test: treehugger
241 lines
6.4 KiB
Go
241 lines
6.4 KiB
Go
// Copyright 2017 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package build
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"android/soong/ui/metrics"
|
|
"android/soong/ui/status"
|
|
)
|
|
|
|
// DumpMakeVars can be used to extract the values of Make variables after the
|
|
// product configurations are loaded. This is roughly equivalent to the
|
|
// `get_build_var` bash function.
|
|
//
|
|
// goals can be used to set MAKECMDGOALS, which emulates passing arguments to
|
|
// Make without actually building them. So all the variables based on
|
|
// MAKECMDGOALS can be read.
|
|
//
|
|
// vars is the list of variables to read. The values will be put in the
|
|
// returned map.
|
|
//
|
|
// variables controlled by soong_ui directly are now returned without needing
|
|
// to call into make, to retain compatibility.
|
|
func DumpMakeVars(ctx Context, config Config, goals, vars []string) (map[string]string, error) {
|
|
soongUiVars := map[string]func() string{
|
|
"OUT_DIR": func() string { return config.OutDir() },
|
|
"DIST_DIR": func() string { return config.DistDir() },
|
|
}
|
|
|
|
makeVars := make([]string, 0, len(vars))
|
|
for _, v := range vars {
|
|
if _, ok := soongUiVars[v]; !ok {
|
|
makeVars = append(makeVars, v)
|
|
}
|
|
}
|
|
|
|
var ret map[string]string
|
|
if len(makeVars) > 0 {
|
|
var err error
|
|
ret, err = dumpMakeVars(ctx, config, goals, makeVars, false)
|
|
if err != nil {
|
|
return ret, err
|
|
}
|
|
} else {
|
|
ret = make(map[string]string)
|
|
}
|
|
|
|
for _, v := range vars {
|
|
if f, ok := soongUiVars[v]; ok {
|
|
ret[v] = f()
|
|
}
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
func dumpMakeVars(ctx Context, config Config, goals, vars []string, write_soong_vars bool) (map[string]string, error) {
|
|
ctx.BeginTrace(metrics.RunKati, "dumpvars")
|
|
defer ctx.EndTrace()
|
|
|
|
cmd := Command(ctx, config, "dumpvars",
|
|
config.PrebuiltBuildTool("ckati"),
|
|
"-f", "build/make/core/config.mk",
|
|
"--color_warnings",
|
|
"--kati_stats",
|
|
"dump-many-vars",
|
|
"MAKECMDGOALS="+strings.Join(goals, " "))
|
|
cmd.Environment.Set("CALLED_FROM_SETUP", "true")
|
|
if write_soong_vars {
|
|
cmd.Environment.Set("WRITE_SOONG_VARIABLES", "true")
|
|
}
|
|
cmd.Environment.Set("DUMP_MANY_VARS", strings.Join(vars, " "))
|
|
cmd.Sandbox = dumpvarsSandbox
|
|
output := bytes.Buffer{}
|
|
cmd.Stdout = &output
|
|
pipe, err := cmd.StderrPipe()
|
|
if err != nil {
|
|
ctx.Fatalln("Error getting output pipe for ckati:", err)
|
|
}
|
|
cmd.StartOrFatal()
|
|
// TODO: error out when Stderr contains any content
|
|
status.KatiReader(ctx.Status.StartTool(), pipe)
|
|
cmd.WaitOrFatal()
|
|
|
|
ret := make(map[string]string, len(vars))
|
|
for _, line := range strings.Split(output.String(), "\n") {
|
|
if len(line) == 0 {
|
|
continue
|
|
}
|
|
|
|
if key, value, ok := decodeKeyValue(line); ok {
|
|
if value, ok = singleUnquote(value); ok {
|
|
ret[key] = value
|
|
ctx.Verboseln(key, value)
|
|
} else {
|
|
return nil, fmt.Errorf("Failed to parse make line: %q", line)
|
|
}
|
|
} else {
|
|
return nil, fmt.Errorf("Failed to parse make line: %q", line)
|
|
}
|
|
}
|
|
if ctx.Metrics != nil {
|
|
ctx.Metrics.SetMetadataMetrics(ret)
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
// Variables to print out in the top banner
|
|
var BannerVars = []string{
|
|
"PLATFORM_VERSION_CODENAME",
|
|
"PLATFORM_VERSION",
|
|
"TARGET_PRODUCT",
|
|
"TARGET_BUILD_VARIANT",
|
|
"TARGET_BUILD_TYPE",
|
|
"TARGET_BUILD_APPS",
|
|
"TARGET_ARCH",
|
|
"TARGET_ARCH_VARIANT",
|
|
"TARGET_CPU_VARIANT",
|
|
"TARGET_2ND_ARCH",
|
|
"TARGET_2ND_ARCH_VARIANT",
|
|
"TARGET_2ND_CPU_VARIANT",
|
|
"HOST_ARCH",
|
|
"HOST_2ND_ARCH",
|
|
"HOST_OS",
|
|
"HOST_OS_EXTRA",
|
|
"HOST_CROSS_OS",
|
|
"HOST_CROSS_ARCH",
|
|
"HOST_CROSS_2ND_ARCH",
|
|
"HOST_BUILD_TYPE",
|
|
"BUILD_ID",
|
|
"OUT_DIR",
|
|
"AUX_OS_VARIANT_LIST",
|
|
"TARGET_BUILD_PDK",
|
|
"PDK_FUSION_PLATFORM_ZIP",
|
|
"PRODUCT_SOONG_NAMESPACES",
|
|
}
|
|
|
|
func Banner(make_vars map[string]string) string {
|
|
b := &bytes.Buffer{}
|
|
|
|
fmt.Fprintln(b, "============================================")
|
|
for _, name := range BannerVars {
|
|
if make_vars[name] != "" {
|
|
fmt.Fprintf(b, "%s=%s\n", name, make_vars[name])
|
|
}
|
|
}
|
|
fmt.Fprint(b, "============================================")
|
|
|
|
return b.String()
|
|
}
|
|
|
|
func runMakeProductConfig(ctx Context, config Config) {
|
|
// Variables to export into the environment of Kati/Ninja
|
|
exportEnvVars := []string{
|
|
// So that we can use the correct TARGET_PRODUCT if it's been
|
|
// modified by PRODUCT-*/APP-* arguments
|
|
"TARGET_PRODUCT",
|
|
"TARGET_BUILD_VARIANT",
|
|
"TARGET_BUILD_APPS",
|
|
|
|
// compiler wrappers set up by make
|
|
"CC_WRAPPER",
|
|
"CXX_WRAPPER",
|
|
"JAVAC_WRAPPER",
|
|
|
|
// ccache settings
|
|
"CCACHE_COMPILERCHECK",
|
|
"CCACHE_SLOPPINESS",
|
|
"CCACHE_BASEDIR",
|
|
"CCACHE_CPP2",
|
|
}
|
|
|
|
allVars := append(append([]string{
|
|
// Used to execute Kati and Ninja
|
|
"NINJA_GOALS",
|
|
"KATI_GOALS",
|
|
|
|
// To find target/product/<DEVICE>
|
|
"TARGET_DEVICE",
|
|
|
|
// So that later Kati runs can find BoardConfig.mk faster
|
|
"TARGET_DEVICE_DIR",
|
|
|
|
// Whether --werror_overriding_commands will work
|
|
"BUILD_BROKEN_DUP_RULES",
|
|
|
|
// Used to turn on --werror_ options in Kati
|
|
"BUILD_BROKEN_PHONY_TARGETS",
|
|
|
|
// Not used, but useful to be in the soong.log
|
|
"BUILD_BROKEN_ANDROIDMK_EXPORTS",
|
|
"BUILD_BROKEN_DUP_COPY_HEADERS",
|
|
"BUILD_BROKEN_ENG_DEBUG_TAGS",
|
|
}, exportEnvVars...), BannerVars...)
|
|
|
|
make_vars, err := dumpMakeVars(ctx, config, config.Arguments(), allVars, true)
|
|
if err != nil {
|
|
ctx.Fatalln("Error dumping make vars:", err)
|
|
}
|
|
|
|
env := config.Environment()
|
|
// Print the banner like make does
|
|
if !env.IsEnvTrue("ANDROID_QUIET_BUILD") {
|
|
ctx.Writer.Print(Banner(make_vars))
|
|
}
|
|
|
|
// Populate the environment
|
|
for _, name := range exportEnvVars {
|
|
if make_vars[name] == "" {
|
|
env.Unset(name)
|
|
} else {
|
|
env.Set(name, make_vars[name])
|
|
}
|
|
}
|
|
|
|
config.SetKatiArgs(strings.Fields(make_vars["KATI_GOALS"]))
|
|
config.SetNinjaArgs(strings.Fields(make_vars["NINJA_GOALS"]))
|
|
config.SetTargetDevice(make_vars["TARGET_DEVICE"])
|
|
config.SetTargetDeviceDir(make_vars["TARGET_DEVICE_DIR"])
|
|
|
|
config.SetPdkBuild(make_vars["TARGET_BUILD_PDK"] == "true")
|
|
config.SetBuildBrokenDupRules(make_vars["BUILD_BROKEN_DUP_RULES"] == "true")
|
|
config.SetBuildBrokenPhonyTargets(make_vars["BUILD_BROKEN_PHONY_TARGETS"] == "true")
|
|
}
|