042504f7d6
Device binaries currently are linked statically by default. Instead we should be linking these dynamic by default. To avoid conflicts when manually specifying rlib dependencies on modules, we always link libstd dynamically for all device modules except static libraries. This removes the "prefer_dynamic" property entirely to avoid confusion. Bug: 165161105 Test: m profcollectd is built dynamically. Test: cd external/rust/; mma Test: cd external/crosvm/; mma Change-Id: I25ac897040acbcc2d97c791a33e8e01610632272
81 lines
2.4 KiB
Go
81 lines
2.4 KiB
Go
// Copyright 2019 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rust
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"android/soong/android"
|
|
)
|
|
|
|
// Test that rustlibs default linkage is correct for binaries.
|
|
func TestBinaryLinkage(t *testing.T) {
|
|
ctx := testRust(t, `
|
|
rust_binary {
|
|
name: "fizz-buzz",
|
|
srcs: ["foo.rs"],
|
|
rustlibs: ["libfoo"],
|
|
host_supported: true,
|
|
}
|
|
rust_library {
|
|
name: "libfoo",
|
|
srcs: ["foo.rs"],
|
|
crate_name: "foo",
|
|
host_supported: true,
|
|
}`)
|
|
|
|
fizzBuzzHost := ctx.ModuleForTests("fizz-buzz", "linux_glibc_x86_64").Module().(*Module)
|
|
fizzBuzzDevice := ctx.ModuleForTests("fizz-buzz", "android_arm64_armv8-a").Module().(*Module)
|
|
|
|
if !android.InList("libfoo", fizzBuzzHost.Properties.AndroidMkRlibs) {
|
|
t.Errorf("rustlibs dependency libfoo should be an rlib dep for host modules")
|
|
}
|
|
|
|
if !android.InList("libfoo", fizzBuzzDevice.Properties.AndroidMkDylibs) {
|
|
t.Errorf("rustlibs dependency libfoo should be an dylib dep for device modules")
|
|
}
|
|
}
|
|
|
|
// Test that the path returned by HostToolPath is correct
|
|
func TestHostToolPath(t *testing.T) {
|
|
ctx := testRust(t, `
|
|
rust_binary_host {
|
|
name: "fizz-buzz",
|
|
srcs: ["foo.rs"],
|
|
}`)
|
|
|
|
path := ctx.ModuleForTests("fizz-buzz", "linux_glibc_x86_64").Module().(*Module).HostToolPath()
|
|
if g, w := path.String(), "/host/linux-x86/bin/fizz-buzz"; !strings.Contains(g, w) {
|
|
t.Errorf("wrong host tool path, expected %q got %q", w, g)
|
|
}
|
|
}
|
|
|
|
// Test that the flags being passed to rust_binary modules are as expected
|
|
func TestBinaryFlags(t *testing.T) {
|
|
ctx := testRust(t, `
|
|
rust_binary_host {
|
|
name: "fizz-buzz",
|
|
srcs: ["foo.rs"],
|
|
}`)
|
|
|
|
fizzBuzz := ctx.ModuleForTests("fizz-buzz", "linux_glibc_x86_64").Output("fizz-buzz")
|
|
|
|
flags := fizzBuzz.Args["rustcFlags"]
|
|
if strings.Contains(flags, "--test") {
|
|
t.Errorf("extra --test flag, rustcFlags: %#v", flags)
|
|
}
|
|
}
|