Sample output: [bp2build] cc_library_headers: 5 targets [bp2build] cc_object: 5 targets [bp2build] filegroup: 4 targets [bp2build] genrule: 4 targets [bp2build] sh_binary: 1 targets [bp2build] Generated 19 total BUILD targets from 39270 Android.bp modules. This CL adds an additional CodegenMetrics return value to GenerateBazelTargets calls, which are called from bp2build, queryview, and their tests. For this UI, we only want to use it for bp2build, and not queryview or tests, since it's not useful for the former, and can pollute the CLI for the latter. Test: build/bazel/scripts/milestone-2/demo.sh Change-Id: Ic84307a1ed1a25e360c9b23459e5449d932bc2e7
188 lines
4.9 KiB
Go
188 lines
4.9 KiB
Go
// Copyright 2021 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bp2build
|
|
|
|
import (
|
|
"android/soong/android"
|
|
"android/soong/cc"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestCcObjectBp2Build(t *testing.T) {
|
|
testCases := []struct {
|
|
description string
|
|
moduleTypeUnderTest string
|
|
moduleTypeUnderTestFactory android.ModuleFactory
|
|
moduleTypeUnderTestBp2BuildMutator func(android.TopDownMutatorContext)
|
|
blueprint string
|
|
expectedBazelTargets []string
|
|
filesystem map[string]string
|
|
}{
|
|
{
|
|
description: "simple cc_object generates cc_object with include header dep",
|
|
moduleTypeUnderTest: "cc_object",
|
|
moduleTypeUnderTestFactory: cc.ObjectFactory,
|
|
moduleTypeUnderTestBp2BuildMutator: cc.ObjectBp2Build,
|
|
filesystem: map[string]string{
|
|
"a/b/foo.h": "",
|
|
"a/b/bar.h": "",
|
|
"a/b/c.c": "",
|
|
},
|
|
blueprint: `cc_object {
|
|
name: "foo",
|
|
local_include_dirs: ["include"],
|
|
cflags: [
|
|
"-Wno-gcc-compat",
|
|
"-Wall",
|
|
"-Werror",
|
|
],
|
|
srcs: [
|
|
"a/b/*.h",
|
|
"a/b/c.c"
|
|
],
|
|
|
|
bazel_module: { bp2build_available: true },
|
|
}
|
|
`,
|
|
expectedBazelTargets: []string{`cc_object(
|
|
name = "foo",
|
|
copts = [
|
|
"-fno-addrsig",
|
|
"-Wno-gcc-compat",
|
|
"-Wall",
|
|
"-Werror",
|
|
],
|
|
local_include_dirs = [
|
|
"include",
|
|
],
|
|
srcs = [
|
|
"a/b/bar.h",
|
|
"a/b/foo.h",
|
|
"a/b/c.c",
|
|
],
|
|
)`,
|
|
},
|
|
},
|
|
{
|
|
description: "simple cc_object with defaults",
|
|
moduleTypeUnderTest: "cc_object",
|
|
moduleTypeUnderTestFactory: cc.ObjectFactory,
|
|
moduleTypeUnderTestBp2BuildMutator: cc.ObjectBp2Build,
|
|
blueprint: `cc_object {
|
|
name: "foo",
|
|
local_include_dirs: ["include"],
|
|
srcs: [
|
|
"a/b/*.h",
|
|
"a/b/c.c"
|
|
],
|
|
|
|
defaults: ["foo_defaults"],
|
|
bazel_module: { bp2build_available: true },
|
|
}
|
|
|
|
cc_defaults {
|
|
name: "foo_defaults",
|
|
defaults: ["foo_bar_defaults"],
|
|
// TODO(b/178130668): handle configurable attributes that depend on the platform
|
|
arch: {
|
|
x86: {
|
|
cflags: ["-fPIC"],
|
|
},
|
|
x86_64: {
|
|
cflags: ["-fPIC"],
|
|
},
|
|
},
|
|
}
|
|
|
|
cc_defaults {
|
|
name: "foo_bar_defaults",
|
|
cflags: [
|
|
"-Wno-gcc-compat",
|
|
"-Wall",
|
|
"-Werror",
|
|
],
|
|
}
|
|
`,
|
|
expectedBazelTargets: []string{`cc_object(
|
|
name = "foo",
|
|
copts = [
|
|
"-Wno-gcc-compat",
|
|
"-Wall",
|
|
"-Werror",
|
|
"-fno-addrsig",
|
|
],
|
|
local_include_dirs = [
|
|
"include",
|
|
],
|
|
srcs = [
|
|
"a/b/c.c",
|
|
],
|
|
)`,
|
|
},
|
|
},
|
|
}
|
|
|
|
dir := "."
|
|
for _, testCase := range testCases {
|
|
filesystem := make(map[string][]byte)
|
|
toParse := []string{
|
|
"Android.bp",
|
|
}
|
|
for f, content := range testCase.filesystem {
|
|
if strings.HasSuffix(f, "Android.bp") {
|
|
toParse = append(toParse, f)
|
|
}
|
|
filesystem[f] = []byte(content)
|
|
}
|
|
config := android.TestConfig(buildDir, nil, testCase.blueprint, filesystem)
|
|
ctx := android.NewTestContext(config)
|
|
// Always register cc_defaults module factory
|
|
ctx.RegisterModuleType("cc_defaults", func() android.Module { return cc.DefaultsFactory() })
|
|
|
|
ctx.RegisterModuleType(testCase.moduleTypeUnderTest, testCase.moduleTypeUnderTestFactory)
|
|
ctx.RegisterBp2BuildMutator(testCase.moduleTypeUnderTest, testCase.moduleTypeUnderTestBp2BuildMutator)
|
|
ctx.RegisterForBazelConversion()
|
|
|
|
_, errs := ctx.ParseFileList(dir, toParse)
|
|
if Errored(t, testCase.description, errs) {
|
|
continue
|
|
}
|
|
_, errs = ctx.ResolveDependencies(config)
|
|
if Errored(t, testCase.description, errs) {
|
|
continue
|
|
}
|
|
|
|
codegenCtx := NewCodegenContext(config, *ctx.Context, Bp2Build)
|
|
bazelTargets := GenerateBazelTargetsForDir(codegenCtx, dir)
|
|
if actualCount, expectedCount := len(bazelTargets), len(testCase.expectedBazelTargets); actualCount != expectedCount {
|
|
fmt.Println(bazelTargets)
|
|
t.Errorf("%s: Expected %d bazel target, got %d", testCase.description, expectedCount, actualCount)
|
|
} else {
|
|
for i, target := range bazelTargets {
|
|
if w, g := testCase.expectedBazelTargets[i], target.content; w != g {
|
|
t.Errorf(
|
|
"%s: Expected generated Bazel target to be '%s', got '%s'",
|
|
testCase.description,
|
|
w,
|
|
g,
|
|
)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|