Currently, all bpf programs require a cflags field which defines -Wall and -Werror. This change enables this by default, and also enables -Wextra. This removes boilerplate required for every bpf program, and improves code quality. Additionally, this change enables the default of 'btf: true' further reducing the boilerplate required for most bpf programs in their Android.bp file. BTF should be enabled by default, with only limited mainlined bpf programs requiring BTF being disabled for compatibility with older bpfloader releases. Test: Treehugger Change-Id: I8efd0f63115030d40c0ff7fe81d5345ff3436e5a Signed-off-by: Neill Kapron <nkapron@google.com>
279 lines
7.8 KiB
Go
279 lines
7.8 KiB
Go
// Copyright (C) 2018 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bpf
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
|
|
"android/soong/android"
|
|
"android/soong/cc"
|
|
|
|
"github.com/google/blueprint"
|
|
"github.com/google/blueprint/proptools"
|
|
)
|
|
|
|
func init() {
|
|
registerBpfBuildComponents(android.InitRegistrationContext)
|
|
pctx.Import("android/soong/cc/config")
|
|
pctx.StaticVariable("relPwd", cc.PwdPrefix())
|
|
}
|
|
|
|
var (
|
|
pctx = android.NewPackageContext("android/soong/bpf")
|
|
|
|
ccRule = pctx.AndroidRemoteStaticRule("ccRule", android.RemoteRuleSupports{Goma: true},
|
|
blueprint.RuleParams{
|
|
Depfile: "${out}.d",
|
|
Deps: blueprint.DepsGCC,
|
|
Command: "$relPwd $ccCmd --target=bpf -c $cFlags -MD -MF ${out}.d -o $out $in",
|
|
CommandDeps: []string{"$ccCmd"},
|
|
},
|
|
"ccCmd", "cFlags")
|
|
|
|
stripRule = pctx.AndroidStaticRule("stripRule",
|
|
blueprint.RuleParams{
|
|
Command: `$stripCmd --strip-unneeded --remove-section=.rel.BTF ` +
|
|
`--remove-section=.rel.BTF.ext --remove-section=.BTF.ext $in -o $out`,
|
|
CommandDeps: []string{"$stripCmd"},
|
|
},
|
|
"stripCmd")
|
|
)
|
|
|
|
func registerBpfBuildComponents(ctx android.RegistrationContext) {
|
|
ctx.RegisterModuleType("bpf", BpfFactory)
|
|
}
|
|
|
|
var PrepareForTestWithBpf = android.FixtureRegisterWithContext(registerBpfBuildComponents)
|
|
|
|
// BpfModule interface is used by the apex package to gather information from a bpf module.
|
|
type BpfModule interface {
|
|
android.Module
|
|
|
|
// Returns the sub install directory if the bpf module is included by apex.
|
|
SubDir() string
|
|
}
|
|
|
|
type BpfProperties struct {
|
|
// source paths to the files.
|
|
Srcs []string `android:"path"`
|
|
|
|
// additional cflags that should be used to build the bpf variant of
|
|
// the C/C++ module.
|
|
Cflags []string
|
|
|
|
// directories (relative to the root of the source tree) that will
|
|
// be added to the include paths using -I.
|
|
Include_dirs []string
|
|
|
|
// optional subdirectory under which this module is installed into.
|
|
Sub_dir string
|
|
|
|
// if set to true, generate BTF debug info for maps & programs.
|
|
Btf *bool
|
|
|
|
Vendor *bool
|
|
|
|
VendorInternal bool `blueprint:"mutated"`
|
|
}
|
|
|
|
type bpf struct {
|
|
android.ModuleBase
|
|
|
|
properties BpfProperties
|
|
|
|
objs android.Paths
|
|
}
|
|
|
|
var _ android.ImageInterface = (*bpf)(nil)
|
|
|
|
func (bpf *bpf) ImageMutatorBegin(ctx android.BaseModuleContext) {}
|
|
|
|
func (bpf *bpf) VendorVariantNeeded(ctx android.BaseModuleContext) bool {
|
|
return proptools.Bool(bpf.properties.Vendor)
|
|
}
|
|
|
|
func (bpf *bpf) ProductVariantNeeded(ctx android.BaseModuleContext) bool {
|
|
return false
|
|
}
|
|
|
|
func (bpf *bpf) CoreVariantNeeded(ctx android.BaseModuleContext) bool {
|
|
return !proptools.Bool(bpf.properties.Vendor)
|
|
}
|
|
|
|
func (bpf *bpf) RamdiskVariantNeeded(ctx android.BaseModuleContext) bool {
|
|
return false
|
|
}
|
|
|
|
func (bpf *bpf) VendorRamdiskVariantNeeded(ctx android.BaseModuleContext) bool {
|
|
return false
|
|
}
|
|
|
|
func (bpf *bpf) DebugRamdiskVariantNeeded(ctx android.BaseModuleContext) bool {
|
|
return false
|
|
}
|
|
|
|
func (bpf *bpf) RecoveryVariantNeeded(ctx android.BaseModuleContext) bool {
|
|
return false
|
|
}
|
|
|
|
func (bpf *bpf) ExtraImageVariations(ctx android.BaseModuleContext) []string {
|
|
return nil
|
|
}
|
|
|
|
func (bpf *bpf) SetImageVariation(ctx android.BaseModuleContext, variation string) {
|
|
bpf.properties.VendorInternal = variation == "vendor"
|
|
}
|
|
|
|
func (bpf *bpf) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
|
cflags := []string{
|
|
"-nostdlibinc",
|
|
|
|
// Make paths in deps files relative
|
|
"-no-canonical-prefixes",
|
|
|
|
"-O2",
|
|
"-Wall",
|
|
"-Werror",
|
|
"-Wextra",
|
|
|
|
"-isystem bionic/libc/include",
|
|
"-isystem bionic/libc/kernel/uapi",
|
|
// The architecture doesn't matter here, but asm/types.h is included by linux/types.h.
|
|
"-isystem bionic/libc/kernel/uapi/asm-arm64",
|
|
"-isystem bionic/libc/kernel/android/uapi",
|
|
"-I packages/modules/Connectivity/staticlibs/native/bpf_headers/include/bpf",
|
|
// TODO(b/149785767): only give access to specific file with AID_* constants
|
|
"-I system/core/libcutils/include",
|
|
"-I " + ctx.ModuleDir(),
|
|
}
|
|
|
|
for _, dir := range android.PathsForSource(ctx, bpf.properties.Include_dirs) {
|
|
cflags = append(cflags, "-I "+dir.String())
|
|
}
|
|
|
|
cflags = append(cflags, bpf.properties.Cflags...)
|
|
|
|
if proptools.BoolDefault(bpf.properties.Btf, true) {
|
|
cflags = append(cflags, "-g")
|
|
if runtime.GOOS != "darwin" {
|
|
cflags = append(cflags, "-fdebug-prefix-map=/proc/self/cwd=")
|
|
}
|
|
}
|
|
|
|
srcs := android.PathsForModuleSrc(ctx, bpf.properties.Srcs)
|
|
|
|
for _, src := range srcs {
|
|
if strings.ContainsRune(filepath.Base(src.String()), '_') {
|
|
ctx.ModuleErrorf("invalid character '_' in source name")
|
|
}
|
|
obj := android.ObjPathWithExt(ctx, "unstripped", src, "o")
|
|
|
|
ctx.Build(pctx, android.BuildParams{
|
|
Rule: ccRule,
|
|
Input: src,
|
|
Output: obj,
|
|
Args: map[string]string{
|
|
"cFlags": strings.Join(cflags, " "),
|
|
"ccCmd": "${config.ClangBin}/clang",
|
|
},
|
|
})
|
|
|
|
if proptools.BoolDefault(bpf.properties.Btf, true) {
|
|
objStripped := android.ObjPathWithExt(ctx, "", src, "o")
|
|
ctx.Build(pctx, android.BuildParams{
|
|
Rule: stripRule,
|
|
Input: obj,
|
|
Output: objStripped,
|
|
Args: map[string]string{
|
|
"stripCmd": "${config.ClangBin}/llvm-strip",
|
|
},
|
|
})
|
|
bpf.objs = append(bpf.objs, objStripped.WithoutRel())
|
|
} else {
|
|
bpf.objs = append(bpf.objs, obj.WithoutRel())
|
|
}
|
|
|
|
}
|
|
|
|
installDir := android.PathForModuleInstall(ctx, "etc", "bpf")
|
|
if len(bpf.properties.Sub_dir) > 0 {
|
|
installDir = installDir.Join(ctx, bpf.properties.Sub_dir)
|
|
}
|
|
for _, obj := range bpf.objs {
|
|
ctx.PackageFile(installDir, obj.Base(), obj)
|
|
}
|
|
|
|
android.SetProvider(ctx, blueprint.SrcsFileProviderKey, blueprint.SrcsFileProviderData{SrcPaths: srcs.Strings()})
|
|
|
|
ctx.SetOutputFiles(bpf.objs, "")
|
|
}
|
|
|
|
func (bpf *bpf) AndroidMk() android.AndroidMkData {
|
|
return android.AndroidMkData{
|
|
Custom: func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) {
|
|
var names []string
|
|
fmt.Fprintln(w)
|
|
fmt.Fprintln(w, "LOCAL_PATH :=", moduleDir)
|
|
fmt.Fprintln(w)
|
|
var localModulePath string
|
|
if bpf.properties.VendorInternal {
|
|
localModulePath = "LOCAL_MODULE_PATH := $(TARGET_OUT_VENDOR_ETC)/bpf"
|
|
} else {
|
|
localModulePath = "LOCAL_MODULE_PATH := $(TARGET_OUT_ETC)/bpf"
|
|
}
|
|
if len(bpf.properties.Sub_dir) > 0 {
|
|
localModulePath += "/" + bpf.properties.Sub_dir
|
|
}
|
|
for _, obj := range bpf.objs {
|
|
objName := name + "_" + obj.Base()
|
|
names = append(names, objName)
|
|
fmt.Fprintln(w, "include $(CLEAR_VARS)", " # bpf.bpf.obj")
|
|
fmt.Fprintln(w, "LOCAL_MODULE := ", objName)
|
|
fmt.Fprintln(w, "LOCAL_PREBUILT_MODULE_FILE :=", obj.String())
|
|
fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", obj.Base())
|
|
fmt.Fprintln(w, "LOCAL_MODULE_CLASS := ETC")
|
|
fmt.Fprintln(w, localModulePath)
|
|
// AconfigUpdateAndroidMkData may have added elements to Extra. Process them here.
|
|
for _, extra := range data.Extra {
|
|
extra(w, nil)
|
|
}
|
|
fmt.Fprintln(w, "include $(BUILD_PREBUILT)")
|
|
fmt.Fprintln(w)
|
|
}
|
|
fmt.Fprintln(w, "include $(CLEAR_VARS)", " # bpf.bpf")
|
|
fmt.Fprintln(w, "LOCAL_MODULE := ", name)
|
|
android.AndroidMkEmitAssignList(w, "LOCAL_REQUIRED_MODULES", names)
|
|
fmt.Fprintln(w, "include $(BUILD_PHONY_PACKAGE)")
|
|
},
|
|
}
|
|
}
|
|
|
|
func (bpf *bpf) SubDir() string {
|
|
return bpf.properties.Sub_dir
|
|
}
|
|
|
|
func BpfFactory() android.Module {
|
|
module := &bpf{}
|
|
|
|
module.AddProperties(&module.properties)
|
|
|
|
android.InitAndroidArchModule(module, android.DeviceSupported, android.MultilibCommon)
|
|
return module
|
|
}
|