41955e8895
There are cases where a module needs to refer to an intermediate
output of another module instead of its final output. For example,
a module may want to use the .jar containing .class files from
another module whose final output is a .jar containing classes.dex
files. Support a new ":module{.tag}" format in any property that
is annotated with `android:"path"`, which will query the target
module for its ".tag" output(s).
Test: path_properties_test.go, paths_test.go
Test: no unexpected changes in build.ninja
Change-Id: Icd3c9b0d83ff125771767c04046fcffb9fc3f65a
140 lines
3.0 KiB
Go
140 lines
3.0 KiB
Go
// Copyright 2019 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package android
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
type pathDepsMutatorTestModule struct {
|
|
ModuleBase
|
|
props struct {
|
|
Foo string `android:"path"`
|
|
Bar []string `android:"path,arch_variant"`
|
|
Baz *string `android:"path"`
|
|
Qux string
|
|
}
|
|
|
|
sourceDeps []string
|
|
}
|
|
|
|
func pathDepsMutatorTestModuleFactory() Module {
|
|
module := &pathDepsMutatorTestModule{}
|
|
module.AddProperties(&module.props)
|
|
InitAndroidArchModule(module, DeviceSupported, MultilibBoth)
|
|
return module
|
|
}
|
|
|
|
func (p *pathDepsMutatorTestModule) GenerateAndroidBuildActions(ctx ModuleContext) {
|
|
ctx.VisitDirectDeps(func(dep Module) {
|
|
if _, ok := ctx.OtherModuleDependencyTag(dep).(sourceOrOutputDependencyTag); ok {
|
|
p.sourceDeps = append(p.sourceDeps, ctx.OtherModuleName(dep))
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestPathDepsMutator(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
bp string
|
|
deps []string
|
|
}{
|
|
{
|
|
name: "all",
|
|
bp: `
|
|
test {
|
|
name: "foo",
|
|
foo: ":a",
|
|
bar: [":b"],
|
|
baz: ":c{.bar}",
|
|
qux: ":d",
|
|
}`,
|
|
deps: []string{"a", "b", "c"},
|
|
},
|
|
{
|
|
name: "arch variant",
|
|
bp: `
|
|
test {
|
|
name: "foo",
|
|
arch: {
|
|
arm64: {
|
|
bar: [":a"],
|
|
},
|
|
arm: {
|
|
bar: [":b"],
|
|
},
|
|
},
|
|
bar: [":c"],
|
|
}`,
|
|
deps: []string{"c", "a"},
|
|
},
|
|
}
|
|
|
|
buildDir, err := ioutil.TempDir("", "soong_path_properties_test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(buildDir)
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
config := TestArchConfig(buildDir, nil)
|
|
ctx := NewTestArchContext()
|
|
|
|
ctx.RegisterModuleType("test", ModuleFactoryAdaptor(pathDepsMutatorTestModuleFactory))
|
|
ctx.RegisterModuleType("filegroup", ModuleFactoryAdaptor(FileGroupFactory))
|
|
|
|
bp := test.bp + `
|
|
filegroup {
|
|
name: "a",
|
|
}
|
|
|
|
filegroup {
|
|
name: "b",
|
|
}
|
|
|
|
filegroup {
|
|
name: "c",
|
|
}
|
|
|
|
filegroup {
|
|
name: "d",
|
|
}
|
|
`
|
|
|
|
mockFS := map[string][]byte{
|
|
"Android.bp": []byte(bp),
|
|
}
|
|
|
|
ctx.MockFileSystem(mockFS)
|
|
|
|
ctx.Register()
|
|
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
|
|
FailIfErrored(t, errs)
|
|
_, errs = ctx.PrepareBuildActions(config)
|
|
FailIfErrored(t, errs)
|
|
|
|
m := ctx.ModuleForTests("foo", "android_arm64_armv8-a").Module().(*pathDepsMutatorTestModule)
|
|
|
|
if g, w := m.sourceDeps, test.deps; !reflect.DeepEqual(g, w) {
|
|
t.Errorf("want deps %q, got %q", w, g)
|
|
}
|
|
})
|
|
}
|
|
}
|