This builds cap_names.list.h, which uses an eponymous filegroup "generate_cap_names_list.awk" in Soong, but uses the file target directly in Bazel. This also improve filegroup support for mixed builds, by issuing a cquery call _without_ arch. Filegroups in Soong don't have configurable properties, so don't generate Bazel filegroups into buildroot's config_nodes (which was x86_64 by default). The mixed_build_root now looks like this: ``` config_node(...) config_node(...) config_node(...) config_node(...) ... filegroup(name = "common", srcs = ["@//bionic/linker:linker_sources_x86", "@//bionic/libc:kernel_input_headers", "@//system/timezone/apex:com.android.tzdata-androidManifest", "@//external/libcap:generate_cap_names_list.awk", "@//bionic/linker:linker_sources_arm64", "@//bionic/linker:linker_sources", "@//bionic/libc:libc_sources_shared_arm", "@//bionic/linker:linker_sources_x86_64", "@//bionic/libc:all_kernel_uapi_headers", "@//build/bazel/examples/apex/minimal:build.bazel.examples.apex.minimal-file_contexts", "@//system/core/libcutils:android_filesystem_config_header", "@//bionic/libc:libc_sources_static", "@//bionic/linker:linker_sources_arm", "@//bionic/libc/tools:bionic-gensyscalls", "@//bionic/tools:bionic-generate-version-script", "@//bionic/libc:libc_sources_shared"], ) mixed_build_root(name = "buildroot", deps = [":x86", ":arm64", ":arm", ":common", ":x86_64"], ) ``` Test: CI Fixes: 198595323 Fixes: 198235838 Change-Id: I6df9a14da556cf358d96e6a99b514f66a2638295
157 lines
4.6 KiB
Go
157 lines
4.6 KiB
Go
// Copyright 2016 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package android
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"android/soong/bazel"
|
|
)
|
|
|
|
func init() {
|
|
RegisterModuleType("filegroup", FileGroupFactory)
|
|
RegisterBp2BuildMutator("filegroup", FilegroupBp2Build)
|
|
}
|
|
|
|
var PrepareForTestWithFilegroup = FixtureRegisterWithContext(func(ctx RegistrationContext) {
|
|
ctx.RegisterModuleType("filegroup", FileGroupFactory)
|
|
})
|
|
|
|
// https://docs.bazel.build/versions/master/be/general.html#filegroup
|
|
type bazelFilegroupAttributes struct {
|
|
Srcs bazel.LabelListAttribute
|
|
}
|
|
|
|
func FilegroupBp2Build(ctx TopDownMutatorContext) {
|
|
fg, ok := ctx.Module().(*fileGroup)
|
|
if !ok || !fg.ConvertWithBp2build(ctx) {
|
|
return
|
|
}
|
|
|
|
srcs := bazel.MakeLabelListAttribute(
|
|
BazelLabelForModuleSrcExcludes(ctx, fg.properties.Srcs, fg.properties.Exclude_srcs))
|
|
|
|
// For Bazel compatibility, don't generate the filegroup if there is only 1
|
|
// source file, and that the source file is named the same as the module
|
|
// itself. In Bazel, eponymous filegroups like this would be an error.
|
|
//
|
|
// Instead, dependents on this single-file filegroup can just depend
|
|
// on the file target, instead of rule target, directly.
|
|
//
|
|
// You may ask: what if a filegroup has multiple files, and one of them
|
|
// shares the name? The answer: we haven't seen that in the wild, and
|
|
// should lock Soong itself down to prevent the behavior. For now,
|
|
// we raise an error if bp2build sees this problem.
|
|
for _, f := range srcs.Value.Includes {
|
|
if f.Label == fg.Name() {
|
|
if len(srcs.Value.Includes) > 1 {
|
|
ctx.ModuleErrorf("filegroup '%s' cannot contain a file with the same name", fg.Name())
|
|
}
|
|
return
|
|
}
|
|
}
|
|
|
|
attrs := &bazelFilegroupAttributes{
|
|
Srcs: srcs,
|
|
}
|
|
|
|
props := bazel.BazelTargetModuleProperties{
|
|
Rule_class: "filegroup",
|
|
Bzl_load_location: "//build/bazel/rules:filegroup.bzl",
|
|
}
|
|
|
|
ctx.CreateBazelTargetModule(fg.Name(), props, attrs)
|
|
}
|
|
|
|
type fileGroupProperties struct {
|
|
// srcs lists files that will be included in this filegroup
|
|
Srcs []string `android:"path"`
|
|
|
|
Exclude_srcs []string `android:"path"`
|
|
|
|
// The base path to the files. May be used by other modules to determine which portion
|
|
// of the path to use. For example, when a filegroup is used as data in a cc_test rule,
|
|
// the base path is stripped off the path and the remaining path is used as the
|
|
// installation directory.
|
|
Path *string
|
|
|
|
// Create a make variable with the specified name that contains the list of files in the
|
|
// filegroup, relative to the root of the source tree.
|
|
Export_to_make_var *string
|
|
}
|
|
|
|
type fileGroup struct {
|
|
ModuleBase
|
|
BazelModuleBase
|
|
properties fileGroupProperties
|
|
srcs Paths
|
|
}
|
|
|
|
var _ SourceFileProducer = (*fileGroup)(nil)
|
|
|
|
// filegroup contains a list of files that are referenced by other modules
|
|
// properties (such as "srcs") using the syntax ":<name>". filegroup are
|
|
// also be used to export files across package boundaries.
|
|
func FileGroupFactory() Module {
|
|
module := &fileGroup{}
|
|
module.AddProperties(&module.properties)
|
|
InitAndroidModule(module)
|
|
InitBazelModule(module)
|
|
return module
|
|
}
|
|
|
|
func (fg *fileGroup) GenerateBazelBuildActions(ctx ModuleContext) bool {
|
|
if !fg.MixedBuildsEnabled(ctx) {
|
|
return false
|
|
}
|
|
|
|
bazelCtx := ctx.Config().BazelContext
|
|
filePaths, ok := bazelCtx.GetOutputFiles(fg.GetBazelLabel(ctx, fg), Common)
|
|
if !ok {
|
|
return false
|
|
}
|
|
|
|
bazelOuts := make(Paths, 0, len(filePaths))
|
|
for _, p := range filePaths {
|
|
src := PathForBazelOut(ctx, p)
|
|
bazelOuts = append(bazelOuts, src)
|
|
}
|
|
|
|
fg.srcs = bazelOuts
|
|
|
|
return true
|
|
}
|
|
|
|
func (fg *fileGroup) GenerateAndroidBuildActions(ctx ModuleContext) {
|
|
if fg.GenerateBazelBuildActions(ctx) {
|
|
return
|
|
}
|
|
|
|
fg.srcs = PathsForModuleSrcExcludes(ctx, fg.properties.Srcs, fg.properties.Exclude_srcs)
|
|
if fg.properties.Path != nil {
|
|
fg.srcs = PathsWithModuleSrcSubDir(ctx, fg.srcs, String(fg.properties.Path))
|
|
}
|
|
}
|
|
|
|
func (fg *fileGroup) Srcs() Paths {
|
|
return append(Paths{}, fg.srcs...)
|
|
}
|
|
|
|
func (fg *fileGroup) MakeVars(ctx MakeVarsModuleContext) {
|
|
if makeVar := String(fg.properties.Export_to_make_var); makeVar != "" {
|
|
ctx.StrictRaw(makeVar, strings.Join(fg.srcs.Strings(), " "))
|
|
}
|
|
}
|