From c3a46252ee6b4b6116ae4a6a681d90acaf9a942a Mon Sep 17 00:00:00 2001
From: Sebastiano Barezzi <seba@sebaubuntu.dev>
Date: Mon, 22 Jul 2024 01:45:20 +0200
Subject: [PATCH] apns: Add a XML schema and check apns-conf.xml against it

Change-Id: Id115dd7beeafffcdf24e9ff1732490f0ca808279
---
 .github/workflows/build/action.yml |   4 +
 prebuilt/common/Android.bp         |   1 +
 tools/Android.bp                   |   4 +
 tools/apns-conf.xsd                | 159 +++++++++++++++++++++++++++++
 4 files changed, 168 insertions(+)
 create mode 100644 tools/Android.bp
 create mode 100644 tools/apns-conf.xsd

diff --git a/.github/workflows/build/action.yml b/.github/workflows/build/action.yml
index b808aa0b..d46853f9 100644
--- a/.github/workflows/build/action.yml
+++ b/.github/workflows/build/action.yml
@@ -8,6 +8,10 @@ runs:
       shell: bash
       run: sudo apt -y install libxml2-utils
 
+    - name: Validate apns-conf.xml
+      shell: bash
+      run: xmllint --noout --schema ./tools/apns-conf.xsd ./prebuilt/common/etc/apns-conf.xml
+
     - name: Validate sensitive_pn.xml
       shell: bash
       run: xmllint --noout --schema ./spn/SpnInfo.xsd ./prebuilt/common/etc/sensitive_pn.xml
diff --git a/prebuilt/common/Android.bp b/prebuilt/common/Android.bp
index a6cf55fd..3985af01 100644
--- a/prebuilt/common/Android.bp
+++ b/prebuilt/common/Android.bp
@@ -2,6 +2,7 @@ prebuilt_etc_xml {
     name: "apns-conf.xml",
     product_specific: true,
     src: "etc/apns-conf.xml",
+    schema: ":apns-conf-schema",
 }
 
 prebuilt_etc_xml {
diff --git a/tools/Android.bp b/tools/Android.bp
new file mode 100644
index 00000000..de18c32d
--- /dev/null
+++ b/tools/Android.bp
@@ -0,0 +1,4 @@
+filegroup {
+    name: "apns-conf-schema",
+    srcs: ["apns-conf.xsd"],
+}
diff --git a/tools/apns-conf.xsd b/tools/apns-conf.xsd
new file mode 100644
index 00000000..4dbb06f3
--- /dev/null
+++ b/tools/apns-conf.xsd
@@ -0,0 +1,159 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+     SPDX-FileCopyrightText: 2024 The LineageOS Project
+     SPDX-License-Identifier: Apache-2.0
+-->
+<xs:schema version="2.0"
+    elementFormDefault="qualified"
+    attributeFormDefault="unqualified"
+    xmlns:xs="http://www.w3.org/2001/XMLSchema">
+
+    <xs:simpleType name="mcc">
+        <xs:restriction base="xs:integer">
+            <xs:pattern value="\d{3}"/>
+        </xs:restriction>
+    </xs:simpleType>
+
+    <xs:simpleType name="mnc">
+        <xs:union>
+            <xs:simpleType>
+              <xs:restriction base='xs:token'>
+                <xs:pattern value=""/>
+              </xs:restriction>
+            </xs:simpleType>
+            <xs:simpleType>
+              <xs:restriction base="xs:integer">
+                <xs:pattern value="\d{2,3}"/>
+              </xs:restriction>
+            </xs:simpleType>
+        </xs:union>
+    </xs:simpleType>
+
+    <!--
+         frameworks/base/telephony/java/android/telephony/data/ApnSetting.java,
+         TYPE_*_STRING
+    -->
+    <xs:simpleType name="apnType">
+        <xs:restriction base="xs:token">
+            <xs:pattern value="(\*|default|mms|supl|dun|hipri|fota|ims|cbs|ia|emergency|mcx|xcap|vsim|bip|enterprise|rcs)(,(\*|default|mms|supl|dun|hipri|fota|ims|cbs|ia|emergency|mcx|xcap|vsim|bip|enterprise|rcs))*"/>
+        </xs:restriction>
+    </xs:simpleType>
+
+    <!--
+         frameworks/base/telephony/java/android/telephony/data/ApnSetting.java,
+         PROTOCOL_INT_MAP
+    -->
+    <xs:simpleType name="protocol">
+        <xs:restriction base="xs:string">
+            <xs:enumeration value="IP" />
+            <xs:enumeration value="IPV6" />
+            <xs:enumeration value="IPV4V6" />
+            <xs:enumeration value="PPP" />
+            <xs:enumeration value="NON-IP" />
+            <xs:enumeration value="UNSTRUCTURED" />
+        </xs:restriction>
+    </xs:simpleType>
+
+    <!--
+         frameworks/base/telephony/java/android/telephony/data/ApnSetting.java,
+         AUTH_TYPE_*
+    -->
+    <xs:simpleType name="authtype">
+        <xs:restriction base="xs:integer">
+            <xs:minInclusive value="0" />
+            <xs:maxInclusive value="3" />
+        </xs:restriction>
+    </xs:simpleType>
+
+    <!--
+         frameworks/base/core/java/android/provider/Telephony.java,
+         SKIP_464XLAT_*
+    -->
+    <xs:simpleType name="skip_464xlat">
+        <xs:restriction base="xs:integer">
+            <xs:minInclusive value="0" />
+            <xs:maxInclusive value="1" />
+        </xs:restriction>
+    </xs:simpleType>
+
+    <!--
+         frameworks/base/telephony/java/android/telephony/data/ApnSetting.java,
+         MVNO_TYPE_STRING
+    -->
+    <xs:simpleType name="mvnoType">
+        <xs:restriction base="xs:string">
+            <xs:enumeration value="spn" />
+            <xs:enumeration value="imsi" />
+            <xs:enumeration value="gid" />
+            <xs:enumeration value="iccid" />
+        </xs:restriction>
+    </xs:simpleType>
+
+    <!--
+         packages/providers/TelephonyProvider/src/com/android/providers/telephony/TelephonyProvider.java,
+         TelephonyProvider::getInfrastructureListFromString
+    -->
+    <xs:simpleType name="infrastructure_bitmask">
+        <xs:restriction base="xs:token">
+            <xs:pattern value="(cellular|satellite)(\|(cellular|satellite))*" />
+        </xs:restriction>
+    </xs:simpleType>
+
+    <xs:simpleType name="bitmask">
+        <xs:restriction base="xs:token">
+            <xs:pattern value="\d+(\|\d+)*" />
+        </xs:restriction>
+    </xs:simpleType>
+
+    <xs:complexType name="apn">
+        <xs:attribute name="mcc" type="mcc" />
+        <xs:attribute name="mnc" type="mnc" />
+        <xs:attribute name="carrier" type="xs:string" />
+        <xs:attribute name="apn" type="xs:string" />
+        <xs:attribute name="user" type="xs:string" />
+        <xs:attribute name="server" type="xs:anyURI" />
+        <xs:attribute name="password" type="xs:string" />
+        <xs:attribute name="proxy" type="xs:anyURI" />
+        <xs:attribute name="port" type="xs:string" />
+        <xs:attribute name="mmsproxy" type="xs:anyURI" />
+        <xs:attribute name="mmsport" type="xs:string" />
+        <xs:attribute name="mmsc" type="xs:anyURI" />
+        <xs:attribute name="type" type="apnType" />
+        <xs:attribute name="protocol" type="protocol" />
+        <xs:attribute name="roaming_protocol" type="protocol" />
+        <xs:attribute name="authtype" type="authtype" />
+        <xs:attribute name="bearer" type="xs:integer" />
+        <xs:attribute name="profile_id" type="xs:integer" />
+        <xs:attribute name="max_conns" type="xs:integer" />
+        <xs:attribute name="wait_time" type="xs:integer" />
+        <xs:attribute name="max_conns_time" type="xs:integer" />
+        <xs:attribute name="mtu" type="xs:integer" />
+        <xs:attribute name="mtu_v4" type="xs:integer" />
+        <xs:attribute name="mtu_v6" type="xs:integer" />
+        <xs:attribute name="apn_set_id" type="xs:integer" />
+        <xs:attribute name="carrier_id" type="xs:integer" />
+        <xs:attribute name="skip_464xlat" type="skip_464xlat" />
+        <xs:attribute name="carrier_enabled" type="xs:boolean" />
+        <xs:attribute name="modem_cognitive" type="xs:boolean" />
+        <xs:attribute name="user_visible" type="xs:boolean" />
+        <xs:attribute name="user_editable" type="xs:boolean" />
+        <xs:attribute name="always_on" type="xs:boolean" />
+        <xs:attribute name="esim_bootstrap_provisioning" type="xs:boolean" />
+        <xs:attribute name="infrastructure_bitmask" type="infrastructure_bitmask" />
+        <xs:attribute name="network_type_bitmask" type="bitmask" />
+        <xs:attribute name="lingering_network_type_bitmask" type="bitmask" />
+        <xs:attribute name="bearer_bitmask" type="bitmask" />
+        <xs:attribute name="mvno_type" type="mvnoType" />
+        <xs:attribute name="mvno_match_data" type="xs:string" />
+    </xs:complexType>
+
+    <xs:element name="apns">
+        <xs:complexType>
+            <xs:sequence>
+                <xs:element name="apn" type="apn" maxOccurs="unbounded" />
+            </xs:sequence>
+            <xs:attribute name="version" type="xs:integer" use="required" />
+        </xs:complexType>
+    </xs:element>
+
+</xs:schema>