mirror/android-debloat-list
1
0
Fork 0
mirror of https://github.com/MuntashirAkon/android-debloat-list.git synced 2025-10-10 06:57:23 +08:00
Code Issues Releases Wiki Activity

Fix mislabeled items

Browse Source 
Signed-off-by: Muntashir Al-Islam <muntashirakon@riseup.net>
This commit is contained in:
Muntashir Al-Islam
2023-07-21 00:53:51 +06:00
parent aa67496dc6
commit 754c35cc16
5 changed files with 152 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
scripts/lint.php
View File

@@ -3,6 +3,8 @@
const SUPPORTED_REMOVAL_TYPES = ['delete', 'replace', 'caution', 'unsafe'];
const SUPPORTED_TAGS = [];
const SUPPRESS_LINT_CONST_LABEL_SAME_AS_ID = 'LabelSameAsId';
const SUPPRESS_LINT_CONSTS = [SUPPRESS_LINT_CONST_LABEL_SAME_AS_ID];
const REPO_DIR = __DIR__ . "/..";
const SUGGESTIONS_DIR = REPO_DIR . '/suggestions';
const LINT_DIR = __DIR__ . "/../build";
@@ -70,6 +72,7 @@ if ($error_count != 0) {
function validate_bloatware_item(array $item): int {
global $lint_writer;
$suppressed = isset($item['suppress']) ? parse_suppress($item['suppress']) : [];
$error_count = 0;
// `id` is a string
if (gettype($item['id']) != 'string') {
@@ -81,6 +84,10 @@ function validate_bloatware_item(array $item): int {
if (gettype($item['label']) != 'string') {
fprintf($lint_writer, "{$item['id']}: Expected `label` field to be a string, found: " . gettype($item['label']) . "\n");
++$error_count;
} else if ($item['label'] == $item['id']) {
if (!in_array(SUPPRESS_LINT_CONST_LABEL_SAME_AS_ID, $suppressed)) {
fprintf(STDERR, "{$item['id']}: `label` is the same as ID.\n");
}
}
} else {
fprintf(STDERR, "{$item['id']}: Missing `label`\n");
@@ -213,3 +220,8 @@ function validate_suggestion_item(array $item): int {
}
return $error_count;
}
function parse_suppress(?string $str): array {
if ($str == null) return [];
return preg_split("/,\\s*/", $str);
}