StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Improve docs about //visibility:public" into main

Browse Source
This commit is contained in:
Treehugger Robot
2024-09-10 18:48:06 +00:00
committed by Gerrit Code Review
parent 58e82f6c9c 8a847c409c
commit 2545872a68
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
sdk/update.go
View File

@@ -1118,12 +1118,14 @@ func (s *snapshotBuilder) AddPrebuiltModule(member android.SdkMember, moduleType
// Since module sdks are generated from release branches and dropped to development
// branches, there might be a visibility skew between the sources and prebuilts
// of a specific module.
// To reconcile this potential skew, change the visibility to public
// To reconcile this potential skew, change the visibility to public.
//
// This is safe for (1) since these are stub libraries.
// This is ok for (2) since these are host and test exports and are intended for
// ART development.
// TODO (b/361303067): This can be removed if ART uses full manifests.
// This means dependencies can bypass visibility restrictions when prebuilts are used, so we rely
// on source builds in CI to check them.
//
// TODO (b/361303067): This special case for category (2) can be removed if existing usages
// of host/test prebuilts of modules like conscrypt,tzdata,i18n are switched to source builds.
// It will also require ART switching to full manifests.
m.AddProperty("visibility", []string{"//visibility:public"})
}