StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Additional heuristics: variables with names ending with _LIST are lists

Browse Source 
Bug: 193540681
Test: internal
Change-Id: Ic23bf0f0eadb159285650f0b7e20307788c12387
This commit is contained in:
Sasha Smundak
2021-08-26 09:10:23 -07:00
parent 5eeb6fc3f2
commit 468e11fbbe
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mk2rbc/mk2rbc_test.go
View File

@@ -414,7 +414,7 @@ endif
def init(g, handle): def init(g, handle):
cfg = rblf.cfg(handle) cfg = rblf.cfg(handle)
if rblf.filter(g.get("PRODUCT_LIST", ""), g["TARGET_PRODUCT"]): if rblf.filter(g.get("PRODUCT_LIST", []), g["TARGET_PRODUCT"]):
pass pass
`, `,
}, },

4
mk2rbc/variable.go
View File

@@ -299,6 +299,10 @@ func (ctx *parseContext) addVariable(name string) variable {
vt = vi.valueType vt = vi.valueType
} }
} }
if strings.HasSuffix(name, "_LIST") && vt == starlarkTypeUnknown {
// Heuristics: Variables with "_LIST" suffix are lists
vt = starlarkTypeList
}
v = &otherGlobalVariable{baseVariable{nam: name, typ: vt}} v = &otherGlobalVariable{baseVariable{nam: name, typ: vt}}
} }
ctx.variables[name] = v ctx.variables[name] = v