Add a property to rust_ffi targets to exclude them from APEXes.

This is a temporary measure until stubs are properly supported by rust_ffi targets.

Bug: 361441210
Bug: 362509506
Change-Id: Ieabd4e3abf442de660f39ec6c5776f5832b25e14
Test: manual
This commit is contained in:
Ashutosh Agarwal
2024-08-27 17:13:12 +00:00
parent 4b98396c64
commit 46e4fad202
3 changed files with 30 additions and 0 deletions

View File

@@ -2230,6 +2230,10 @@ func (a *apexBundle) depVisitor(vctx *visitorContext, ctx android.ModuleContext,
addAconfigFiles(vctx, ctx, child)
return true // track transitive dependencies
} else if rm, ok := child.(*rust.Module); ok {
if !android.IsDepInSameApex(ctx, am, am) {
return false
}
af := apexFileForRustLibrary(ctx, rm)
af.transitiveDep = true
vctx.filesInfo = append(vctx.filesInfo, af)
@@ -2249,6 +2253,10 @@ func (a *apexBundle) depVisitor(vctx *visitorContext, ctx android.ModuleContext,
}
} else if rust.IsDylibDepTag(depTag) {
if rustm, ok := child.(*rust.Module); ok && rustm.IsInstallableToApex() {
if !android.IsDepInSameApex(ctx, am, am) {
return false
}
af := apexFileForRustLibrary(ctx, rustm)
af.transitiveDep = true
vctx.filesInfo = append(vctx.filesInfo, af)

View File

@@ -70,6 +70,10 @@ type LibraryCompilerProperties struct {
// Whether this library is part of the Rust toolchain sysroot.
Sysroot *bool
// Exclude this rust_ffi target from being included in APEXes.
// TODO(b/362509506): remove this once stubs are properly supported by rust_ffi targets.
Apex_exclude *bool
}
type LibraryMutatedProperties struct {
@@ -122,6 +126,7 @@ type libraryInterface interface {
shared() bool
sysroot() bool
source() bool
apexExclude() bool
// Returns true if the build options for the module have selected a particular build type
buildRlib() bool
@@ -186,6 +191,10 @@ func (library *libraryDecorator) source() bool {
return library.MutatedProperties.VariantIsSource
}
func (library *libraryDecorator) apexExclude() bool {
return Bool(library.Properties.Apex_exclude)
}
func (library *libraryDecorator) buildRlib() bool {
return library.MutatedProperties.BuildRlib && BoolDefault(library.Properties.Rlib.Enabled, true)
}

View File

@@ -294,6 +294,15 @@ func (mod *Module) StaticExecutable() bool {
return mod.StaticallyLinked()
}
func (mod *Module) ApexExclude() bool {
if mod.compiler != nil {
if library, ok := mod.compiler.(libraryInterface); ok {
return library.apexExclude()
}
}
return false
}
func (mod *Module) Object() bool {
// Rust has no modules which produce only object files.
return false
@@ -1863,6 +1872,10 @@ func (mod *Module) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Mo
return false
}
if rustDep, ok := dep.(*Module); ok && rustDep.ApexExclude() {
return false
}
return true
}