Disallow linking against updatable-media.

Test: make
Bug: 123253805
Change-Id: I93a86bd8210cf72dbcaa8f7dde96c72acd660934
This commit is contained in:
Dongwon Kang
2019-02-04 09:00:51 -08:00
parent 99ef1573ee
commit 50a299f7c7
2 changed files with 20 additions and 0 deletions

View File

@@ -51,6 +51,7 @@ func createNeverAllows() []*rule {
rules := []*rule{}
rules = append(rules, createTrebleRules()...)
rules = append(rules, createLibcoreRules()...)
rules = append(rules, createMediaRules()...)
return rules
}
@@ -125,6 +126,14 @@ func createLibcoreRules() []*rule {
return rules
}
func createMediaRules() []*rule {
return []*rule{
neverallow().
with("libs", "updatable-media").
because("updatable-media includes private APIs. Use updatable_media_stubs instead."),
}
}
func neverallowMutator(ctx BottomUpMutatorContext) {
m, ok := ctx.Module().(Module)
if !ok {

View File

@@ -148,6 +148,17 @@ var neverallowTests = []struct {
},
expectedError: "Only core libraries projects can depend on core-libart",
},
{
name: "dependency on updatable-media",
fs: map[string][]byte{
"Blueprints": []byte(`
java_library {
name: "needs_updatable_media",
libs: ["updatable-media"],
}`),
},
expectedError: "updatable-media includes private APIs. Use updatable_media_stubs instead.",
},
}
func TestNeverallow(t *testing.T) {