StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

no out/soong/... in default header-filter

Browse Source 
* There are too many warnings from out/.../*.pb.h
  and other generated header files.

Bug: 180862582
Bug: 231245501
Test: WITH_TIDY=1 make
Change-Id: Ibabc1040666b50c6dec4fd66ae999a3441324fbd
This commit is contained in:
Chih-Hung Hsieh
2022-05-09 11:02:25 -07:00
parent 8b9c23ec2d
commit 5fe637aadb
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cc/tidy.go
View File

@@ -96,10 +96,15 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags {
if !android.SubstringInList(flags.TidyFlags, "-header-filter=") {
defaultDirs := ctx.Config().Getenv("DEFAULT_TIDY_HEADER_DIRS")
headerFilter := "-header-filter="
// Default header filter should include only the module directory,
// not the out/soong/.../ModuleDir/...
// Otherwise, there will be too many warnings from generated files in out/...
// If a module wants to see warnings in the generated source files,
// it should specify its own -header-filter flag.
if defaultDirs == "" {
headerFilter += ctx.ModuleDir() + "/"
headerFilter += "^" + ctx.ModuleDir() + "/"
} else {
headerFilter += "\"(" + ctx.ModuleDir() + "/|" + defaultDirs + ")\""
headerFilter += "\"(^" + ctx.ModuleDir() + "/|" + defaultDirs + ")\""
}
flags.TidyFlags = append(flags.TidyFlags, headerFilter)
}